Skip to contentSkip to conversation

staging: media: davinci_vpfe: fix spin_lock/unlock imbalance

PATCH New Gustavo A. R. Silva 1 participant 1 message Apr 18, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: davinci_vpfe: fix spin_lock/unlock imbalance

It seems that this is a copy-paste error and that the proper variable to use in this particular case is video_out2 instead of video_out.

Addresses-Coverity-ID: 1467961 ("Copy-paste error")

Fixes 45e46b3bbe18 ("[media] davinci: vpfe: dm365: resizer driver based on media framework")
---
 drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/davinci_vpfe/dm365_resizer.c +1 -1
index df6d55e..2b79747 100644
@@ -1060,7 +1060,7 @@ static void resizer_ss_isr(struct vpfe_resizer_device *resizer)
 	/* If resizer B is enabled */
 	if (pipe->output_num > 1 && resizer->resizer_b.output ==
 	    RESIZER_OUTPUT_MEMORY) {
-		spin_lock(&video_out->dma_queue_lock);
+		spin_lock(&video_out2->dma_queue_lock);
 		vpfe_video_process_buffer_complete(video_out2);
 		video_out2->state = VPFE_VIDEO_BUFFER_NOT_QUEUED;
 		vpfe_video_schedule_next_buffer(video_out2);
Signature · 1 line
2.7.4