Skip to contentSkip to conversation

Documentation: add manpage entry for connect's --ctrl-loss-tmo setting

PATCH New Johannes Thumshirn 3 participants 4 messages Apr 10, 2018 – Apr 18, 2018

Subsystems (2)
Documentation NVMe
lore
Share & tools
lore

Johannes Thumshirn

author
#0 lore raw

PATCH 1/1 Documentation: add manpage entry for connect's --ctrl-loss-tmo setting

When adding nvme connect's --ctrl-loss-tmo flag we forgot to update the manpage accordingly.

Signed-off-by Johannes Thumshirn <jthumshirn at suse.de>
Reported-by Matt Schulte <matt.schulte at netapp.com>
---
 Documentation/nvme-connect.txt | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/nvme-connect.txt +5 -0
index a746a3a721ed..af78b2a8238f 100644
@@ -19,6 +19,7 @@ SYNOPSIS
 		[--queue-size=<#>         | -Q <#>]
 		[--keep-alive-tmo=<#>     | -k <#>]
 		[--reconnect-delay=<#>    | -c <#>]
+		[--ctrl-loss-tmo=<#>      | -l <#>]
 
 DESCRIPTION
 -----------

@@ -88,6 +89,10 @@ OPTIONS
 	Overrides the default delay (in seconds) before reconnect is attempted
 	after a connect loss.
 
+-l <#>::
+--ctrl-loss-tmo=<#>::
+	Overrides the default controller loss timeout period (in seconds).
+
 EXAMPLES
 --------
 * Connect to a subsystem named nqn.2014-08.com.example:nvme:nvm-subsystem-sn-d78432
Signature · 1 line
2.16.2
Applied
#1 lore raw

PATCH 1/1 Documentation: add manpage entry for connect's --ctrl-loss-tmo setting

Thanks, applied.

#2 lore raw

PATCH 1/1 Documentation: add manpage entry for connect's --ctrl-loss-tmo setting

Quoted 7 lines

Sent: Tuesday, April 10, 2018 12:26 PM
To: Johannes Thumshirn <jthumshirn at suse.de>
Cc: Schulte, Matt <Matt.Schulte at netapp.com>; Linux NVMe Mailinglist <linux-nvme at lists.infradead.org>
Subject: Re: [PATCH nvme-cli] Documentation: add manpage entry for connect's --ctrl-loss-tmo setting

Thanks, applied.

Keith, I'm not seeing this patch on github. Can you double check that it got applied?

Thanks,
Steve

#3 lore raw

PATCH 1/1 Documentation: add manpage entry for connect's --ctrl-loss-tmo setting

Quoted 9 lines · Steven
Quoted 7 lines

Sent: Tuesday, April 10, 2018 12:26 PM
To: Johannes Thumshirn <jthumshirn at suse.de>
Cc: Schulte, Matt <Matt.Schulte at netapp.com>; Linux NVMe Mailinglist <linux-nvme at lists.infradead.org>
Subject: Re: [PATCH nvme-cli] Documentation: add manpage entry for connect's --ctrl-loss-tmo setting

Thanks, applied.

Keith, I'm not seeing this patch on github. Can you double check that it got applied?

Oops, thanks for the notice. In my haste, I didn't see the push failed and needed to merge. Should be there now.