sunxi: A64/H5 devices: enable usb keyboard support

PATCH New Peter Robinson 2 participants 4 messages Apr 18, 2018

Share & tools

Peter Robinson

author

2018-04-18 15:19 UTC #0 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.

Tested on Pine64.

Signed-off-by Peter Robinson <[email protected]>

---
 configs/a64-olinuxino_defconfig       | 2 ++
 configs/bananapi_m64_defconfig        | 2 ++
 configs/nanopi_a64_defconfig          | 2 ++
 configs/orangepi_pc2_defconfig        | 2 ++
 configs/orangepi_win_defconfig        | 2 ++
 configs/orangepi_zero_plus2_defconfig | 2 ++
 configs/pine64_plus_defconfig         | 2 ++
 configs/sopine_baseboard_defconfig    | 2 ++
 8 files changed, 16 insertions(+)

configs/a64-olinuxino_defconfig +2 -0

index b32df990a0..b0e23fc630 100644
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/bananapi_m64_defconfig +2 -0

index 47f31c6d9d..c2997223ab 100644
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/nanopi_a64_defconfig +2 -0

index 0a04911c81..458fcc6f8e 100644
@@ -11,3 +11,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_pc2_defconfig +2 -0

index dd5f2c78ab..f89b67894d 100644
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_win_defconfig +2 -0

index d7211b5823..de014a2766 100644
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_zero_plus2_defconfig +2 -0

index fdb6bb4ed9..fb5f1b2388 100644
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/pine64_plus_defconfig +2 -0

index 21ce06f370..b4dbc7d03e 100644
@@ -14,3 +14,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/sopine_baseboard_defconfig +2 -0

index 05436a1b43..a7db99d1e2 100644
@@ -18,3 +18,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

Signature · 1 line

2.17.0

Andre Przywara

2018-04-18 15:29 UTC #1 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

Hi,

Quoted 4 lines · Peter Robinson

Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.

Mmmh, as Maxime mentioned before: That should be already enabled?

$ git describe HEAD
v2018.03
$ make -s pine64_plus_defconfig
$ grep KEYBOARD .config
CONFIG_DM_KEYBOARD=y
CONFIG_USB_KEYBOARD=y

Plus I use this for ages with *_defconfig on various Allwinner boards.

So what am I missing here?

Cheers,
Andre.

Quoted 93 lines

Signed-off-by Peter Robinson <[email protected]>

---
 configs/a64-olinuxino_defconfig       | 2 ++
 configs/bananapi_m64_defconfig        | 2 ++
 configs/nanopi_a64_defconfig          | 2 ++
 configs/orangepi_pc2_defconfig        | 2 ++
 configs/orangepi_win_defconfig        | 2 ++
 configs/orangepi_zero_plus2_defconfig | 2 ++
 configs/pine64_plus_defconfig         | 2 ++
 configs/sopine_baseboard_defconfig    | 2 ++
 8 files changed, 16 insertions(+)

configs/a64-olinuxino_defconfig +2 -0

index b32df990a0..b0e23fc630 100644
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/bananapi_m64_defconfig +2 -0

index 47f31c6d9d..c2997223ab 100644
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/nanopi_a64_defconfig +2 -0

index 0a04911c81..458fcc6f8e 100644
@@ -11,3 +11,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_pc2_defconfig +2 -0

index dd5f2c78ab..f89b67894d 100644
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_win_defconfig +2 -0

index d7211b5823..de014a2766 100644
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_zero_plus2_defconfig +2 -0

index fdb6bb4ed9..fb5f1b2388 100644
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/pine64_plus_defconfig +2 -0

index 21ce06f370..b4dbc7d03e 100644
@@ -14,3 +14,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/sopine_baseboard_defconfig +2 -0

index 05436a1b43..a7db99d1e2 100644
@@ -18,3 +18,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

Peter Robinson

author

2018-04-18 16:17 UTC #2 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

Quoted 17 lines · Andre Przywara

Hi,
Quoted 4 lines · Peter Robinson
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Mmmh, as Maxime mentioned before: That should be already enabled?
$ git describe HEAD
v2018.03
$ make -s pine64_plus_defconfig
$ grep KEYBOARD .config
CONFIG_DM_KEYBOARD=y
CONFIG_USB_KEYBOARD=y

Quoted 3 lines

Plus I use this for ages with *_defconfig on various Allwinner boards.
So what am I missing here?

I couldn't see where it came from in the config and it wasn't working for me when I tested it on 2018.03

Quoted 96 lines

Cheers,
Andre.

Quoted 93 lines

Signed-off-by Peter Robinson <[email protected]>

---
 configs/a64-olinuxino_defconfig       | 2 ++
 configs/bananapi_m64_defconfig        | 2 ++
 configs/nanopi_a64_defconfig          | 2 ++
 configs/orangepi_pc2_defconfig        | 2 ++
 configs/orangepi_win_defconfig        | 2 ++
 configs/orangepi_zero_plus2_defconfig | 2 ++
 configs/pine64_plus_defconfig         | 2 ++
 configs/sopine_baseboard_defconfig    | 2 ++
 8 files changed, 16 insertions(+)

configs/a64-olinuxino_defconfig +2 -0

index b32df990a0..b0e23fc630 100644
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-olinuxino"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/bananapi_m64_defconfig +2 -0

index 47f31c6d9d..c2997223ab 100644
@@ -13,3 +13,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-bananapi-m64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/nanopi_a64_defconfig +2 -0

index 0a04911c81..458fcc6f8e 100644
@@ -11,3 +11,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-nanopi-a64"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_pc2_defconfig +2 -0

index dd5f2c78ab..f89b67894d 100644
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_win_defconfig +2 -0

index d7211b5823..de014a2766 100644
@@ -12,3 +12,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-orangepi-win"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/orangepi_zero_plus2_defconfig +2 -0

index fdb6bb4ed9..fb5f1b2388 100644
@@ -14,3 +14,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/pine64_plus_defconfig +2 -0

index 21ce06f370..b4dbc7d03e 100644
@@ -14,3 +14,5 @@ CONFIG_RTL8211E_PINE64_GIGABIT_FIX=y
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

configs/sopine_baseboard_defconfig +2 -0

index 05436a1b43..a7db99d1e2 100644
@@ -18,3 +18,5 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus"
 CONFIG_SUN8I_EMAC=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y
+CONFIG_DM_KEYBOARD=y
+CONFIG_USB_KEYBOARD=y

Andre Przywara

2018-04-18 16:30 UTC #3 lore raw

PATCH 1/1 sunxi: A64/H5 devices: enable usb keyboard support

Hi,

Quoted 18 lines · Peter Robinson

Quoted 17 lines · Andre Przywara
Hi,
Quoted 4 lines · Peter Robinson
Now the A64/H5 SoCs support video output it's useful to enable usb keyboard support so console can be used via standard keyboard/video interface.
Tested on Pine64.
Mmmh, as Maxime mentioned before: That should be already enabled?
$ git describe HEAD
v2018.03
$ make -s pine64_plus_defconfig
$ grep KEYBOARD .config
CONFIG_DM_KEYBOARD=y
CONFIG_USB_KEYBOARD=y

Quoted 5 lines

Quoted 3 lines
Plus I use this for ages with *_defconfig on various Allwinner boards.
So what am I missing here?
I couldn't see where it came from in the config

As Maxime mentioned the other day [1]:
arch/arm/Kconfig:
config ARCH_SUNXI

	....
	select DM_KEYBOARD
	....
        select USB_KEYBOARD if DISTRO_DEFAULTS
Kconfig:
config DISTRO_DEFAULTS
        default y if ARCH_SUNXI || TEGRA

Quoted 1 line

and it wasn't working for me when I tested it on 2018.03

That is weird. Are you sure the USB port you connected the keyboard to actually works? I found this to be a problem on some boards, due to missing regulator support. I think I used the lower port on the Pine64 and that worked fine.

Cheers,
Andre.

[1]: https://lists.denx.de/pipermail/u-boot/2018-April/324976.html