Skip to contentSkip to conversation

pixiewps: added missing dependency

PATCH New Guillaume W. Bres 2 participants 3 messages Apr 18, 2018

lore
Share & tools
lore

Guillaume W. Bres

author
#0 lore raw

PATCH 1/1 pixiewps: added missing dependency

Fix problem encountered by autobuild. 22/46 toolchains have been successfully tested here.

Signed-off-by Guillaume W. Bres <[email protected]>
---
 package/pixiewps/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/pixiewps/Config.in +4 -0
index 97240f5..5354dd9 100644
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_PIXIEWPS
 	bool "pixiewps"
+	depends on BR2_TOOLCHAIN_HAS_THREADS=y
 	help
 	  Pixie WPS is a C based tool to audit networks against the so
 	  called "Pixie Dust" attack.
 
 	  https://github.com/wiire-a/pixiewps/wiki
+
+comment "pixiewps needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 pixiewps: added missing dependency

Hello Guillaume,

package/pixiewps/Config.in line 3

Quoted 1 line · Guillaume W. Bres
package/pixiewps/Config.in +1 -0
+	depends on BR2_TOOLCHAIN_HAS_THREADS=y

Should be just depends on BR2_TOOLCHAIN_HAS_THREADS. You can look at all the other packages to have examples on how to do things like that.

Also, please add in the commit log something like this:

"""
Fixes:

http://autobuild.buildroot.org/results/...
"""

with an actual error to a build failure reported by the autobuilders. The mention "22/46 toolchains have been successfully tested here." is not useful because we don't know what "here" means, nor which toolchains have been tested.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
Applied
#2 lore raw

PATCH 1/1 pixiewps: added missing dependency

In reply to Guillaume W. Bres

Hello,

Quoted 6 lines · Guillaume W. Bres

Fix problem encountered by autobuild. 22/46 toolchains have been successfully tested here.

Signed-off-by Guillaume W. Bres <[email protected]>
---
 package/pixiewps/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com