Skip to contentSkip to conversation

pixiewps: added missing dependency

PATCH New Guillaume W. Bres 2 participants 2 messages Apr 18, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pixiewps: added missing dependency

Fixes

	http://autobuild.buildroot.net/results/0c8d0eeb693ac29739845f489caffc2f9fa3b262/
---
 package/pixiewps/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/pixiewps/Config.in +4 -0
index 97240f5..05719f4 100644
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_PIXIEWPS
 	bool "pixiewps"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Pixie WPS is a C based tool to audit networks against the so
 	  called "Pixie Dust" attack.
 
 	  https://github.com/wiire-a/pixiewps/wiki
+
+comment "pixiewps needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 pixiewps: added missing dependency

Hello,

Quoted 5 lines · Guillaume W. Bres

Fixes

	http://autobuild.buildroot.net/results/0c8d0eeb693ac29739845f489caffc2f9fa3b262/

Thanks, I'll apply. Just a few more comments for future contributions, as suggestions to improve them:

- Don't use the past tense in the commit log. Your commit has not "added" something, but it's *adding* something. So please always use forms like "add missing dependency", "remove this", "change that", and not a past tense.

- The commit title could be more specific: "add missing dependency on threads"

- When you send a second iteration of a patch, please generate it with "git format-patch -v2", which will change the patch prefix to:

     [PATCH v2]

And also include a changelog of what changed since the previous iteration under the "---" that is below the Signed-off-by line. This helps people reviewing your patches understand what were the changes between each iteration. For a simple patch like this one, this is not a big deal of course, but I thought I should mention this best practice.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com