Skip to contentSkip to conversation

net/i40e:fix missing some offload capabilities

PATCH Superseded Yanglong Wu 3 participants 6 messages Apr 19, 2018 – May 8, 2018 Network drivers

lore
Share & tools
lore

Yanglong Wu

author
#0 lore raw

PATCH 1/1 net/i40e:fix missing some offload capabilities

MULTI_SEGS and JUMBO_FRAME offload capability
should be exposed both VF and PF since i40e
does support it.

Fixes fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
---
 drivers/net/i40e/i40e_ethdev.c    | 3 ++-
 drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index c3bd254ae..d069a3ebe 100644
@@ -3244,7 +3244,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
 		DEV_TX_OFFLOAD_GRE_TNL_TSO |
 		DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-		DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+		DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 	dev_info->hash_key_size = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 						sizeof(uint32_t);
 	dev_info->reta_size = pf->hash_lut_size;
drivers/net/i40e/i40e_ethdev_vf.c +4 -2
index 031c70680..bf9e14ee3 100644
@@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
-		DEV_RX_OFFLOAD_SCATTER;
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =

@@ -2215,7 +2216,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
 		DEV_TX_OFFLOAD_GRE_TNL_TSO |
 		DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-		DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+		DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 
 	dev_info->default_rxconf = (struct rte_eth_rxconf) {
 		.rx_thresh = {
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH v2 1/1 net/i40e: fix missing some offload capabilities

MULTI_SEGS and JUMBO_FRAME offload capability
should be exposed both VF and PF since i40e
does support it.

Fixes fbf959fe61e7 ("net/i40e: convert to new Rx offloads API")
Fixes b43290f1ade2 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
rework fix line

---
 drivers/net/i40e/i40e_ethdev.c    | 3 ++-
 drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index c3bd254ae..d069a3ebe 100644
@@ -3244,7 +3244,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
 		DEV_TX_OFFLOAD_GRE_TNL_TSO |
 		DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-		DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+		DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 	dev_info->hash_key_size = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 						sizeof(uint32_t);
 	dev_info->reta_size = pf->hash_lut_size;
drivers/net/i40e/i40e_ethdev_vf.c +4 -2
index 031c70680..bf9e14ee3 100644
@@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
-		DEV_RX_OFFLOAD_SCATTER;
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =

@@ -2215,7 +2216,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
 		DEV_TX_OFFLOAD_GRE_TNL_TSO |
 		DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-		DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+		DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 
 	dev_info->default_rxconf = (struct rte_eth_rxconf) {
 		.rx_thresh = {
Signature · 1 line
2.11.0
author
#2 lore raw

PATCH v2 1/1 net/i40e: fix missing some offload capabilities

In reply to Yanglong Wu

MULTI_SEGS and JUMBO_FRAME offload capability
should be exposed both VF and PF since i40e
does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Fixes 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
rework fix line

---
 drivers/net/i40e/i40e_ethdev.c    | 3 ++-
 drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index c3bd254ae..d069a3ebe 100644
@@ -3244,7 +3244,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
 		DEV_TX_OFFLOAD_GRE_TNL_TSO |
 		DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-		DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+		DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 	dev_info->hash_key_size = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
 						sizeof(uint32_t);
 	dev_info->reta_size = pf->hash_lut_size;
drivers/net/i40e/i40e_ethdev_vf.c +4 -2
index 031c70680..bf9e14ee3 100644
@@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
-		DEV_RX_OFFLOAD_SCATTER;
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =

@@ -2215,7 +2216,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
 		DEV_TX_OFFLOAD_GRE_TNL_TSO |
 		DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-		DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+		DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 
 	dev_info->default_rxconf = (struct rte_eth_rxconf) {
 		.rx_thresh = {
Signature · 1 line
2.11.0
author
#3 lore raw

PATCH v2 1/1 net/i40e: fix missing some offload capabilities

In reply to Yanglong Wu

MULTI_SEGS and JUMBO_FRAME offload capability
should be exposed both VF and PF since i40e
does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Fixes 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>

---
v2:
rework fix line

---
 drivers/net/i40e/i40e_ethdev.c    | 3 ++-
 drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
drivers/net/i40e/i40e_ethdev.c +2 -1
index d869add95..2e454566a 100644
@@ -3316,7 +3316,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
 		DEV_TX_OFFLOAD_GRE_TNL_TSO |
 		DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-		DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+		DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 	dev_info->dev_capa =
 		RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP |
 		RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP;
drivers/net/i40e/i40e_ethdev_vf.c +4 -2
index 48e7ac21e..dba28bb90 100644
@@ -2200,7 +2200,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_RX_OFFLOAD_TCP_CKSUM |
 		DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |
 		DEV_RX_OFFLOAD_CRC_STRIP |
-		DEV_RX_OFFLOAD_SCATTER;
+		DEV_RX_OFFLOAD_SCATTER |
+		DEV_RX_OFFLOAD_JUMBO_FRAME;
 
 	dev_info->tx_queue_offload_capa = 0;
 	dev_info->tx_offload_capa =

@@ -2215,7 +2216,8 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 		DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
 		DEV_TX_OFFLOAD_GRE_TNL_TSO |
 		DEV_TX_OFFLOAD_IPIP_TNL_TSO |
-		DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
+		DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 
 	dev_info->default_rxconf = (struct rte_eth_rxconf) {
 		.rx_thresh = {
Signature · 1 line
2.11.0
Acked-by on v2 1/1
#4 lore raw

Re: [PATCH v2] net/i40e: fix missing some offload capabilities

Quoted 9 lines

-----Original Message-----
From: Wu, Yanglong
Sent: Saturday, April 28, 2018 5:37 PM
To: [email protected]
Cc: Zhang, Helin <[email protected]>; Zhang, Qi Z <[email protected]>; Dai, Wei <[email protected]>; Wu, Yanglong <[email protected]>
Subject: [PATCH v2] net/i40e: fix missing some offload capabilities

Quoted 6 lines

MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both VF and PF since i40e does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Fixes 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
Acked-by Qi Zhang <[email protected]>
Applied
#5 lore raw

Re: [PATCH v2] net/i40e: fix missing some offload capabilities

Quoted 18 lines

-----Original Message-----
From: Zhang, Qi Z
Sent: Wednesday, May 2, 2018 1:40 PM
To: Wu, Yanglong; [email protected]
Cc: Zhang, Helin; Dai, Wei
Subject: RE: [PATCH v2] net/i40e: fix missing some offload capabilities

Quoted 9 lines

-----Original Message-----
From: Wu, Yanglong
Sent: Saturday, April 28, 2018 5:37 PM
To: [email protected]
Cc: Zhang, Helin <[email protected]>; Zhang, Qi Z <[email protected]>; Dai, Wei <[email protected]>; Wu, Yanglong <[email protected]>
Subject: [PATCH v2] net/i40e: fix missing some offload capabilities

Quoted 8 lines
Quoted 6 lines

MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both VF and PF since i40e does support it.

Fixes c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
Fixes 7497d3e2f777 ("net/i40e: convert to new Tx offloads API")
Signed-off-by Yanglong Wu <[email protected]>
Acked-by Qi Zhang <[email protected]>

Applied to dpdk-next-net-intel, thanks!

/Helin