Skip to contentSkip to conversation

drm/stm: ltdc: fix warnings in ltdc_plane_create()

PATCH In review Philippe Cornu 2 participants 3 messages Apr 19, 2018 – Apr 27, 2018

Subsystems (4)
DRM drivers DRM misc Arm STM32 DRM drivers for stm
lore
Share & tools
lore

Philippe Cornu

author
#0 lore raw

PATCH 1/1 drm/stm: ltdc: fix warnings in ltdc_plane_create()

"make C=1" returns 2 warnings in ltdc_plane_create() ("Using plain integer as NULL pointer"). This patch fixes them.

Signed-off-by Philippe Cornu <[email protected]>
---
 drivers/gpu/drm/stm/ltdc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/stm/ltdc.c +2 -2
index 616191fe98ae..d997a6014d6c 100644
@@ -860,13 +860,13 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev,
 
 	plane = devm_kzalloc(dev, sizeof(*plane), GFP_KERNEL);
 	if (!plane)
-		return 0;
+		return NULL;
 
 	ret = drm_universal_plane_init(ddev, plane, possible_crtcs,
 				       &ltdc_plane_funcs, formats, nb_fmt,
 				       NULL, type, NULL);
 	if (ret < 0)
-		return 0;
+		return NULL;
 
 	drm_plane_helper_add(plane, &ltdc_plane_helper_funcs);
Signature · 6 lines
2.15.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

Hi Philippe,

Reviewed-by Yannick Fertré <[email protected]>
Quoted 30 lines · Philippe Cornu

"make C=1" returns 2 warnings in ltdc_plane_create() ("Using plain integer as NULL pointer"). This patch fixes them.

Signed-off-by Philippe Cornu <[email protected]>
---
  drivers/gpu/drm/stm/ltdc.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/stm/ltdc.c +2 -2
index 616191fe98ae..d997a6014d6c 100644
@@ -860,13 +860,13 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev,
 
  	plane = devm_kzalloc(dev, sizeof(*plane), GFP_KERNEL);
  	if (!plane)
-		return 0;
+		return NULL;
 
  	ret = drm_universal_plane_init(ddev, plane, possible_crtcs,
  				       &ltdc_plane_funcs, formats, nb_fmt,
  				       NULL, type, NULL);
  	if (ret < 0)
-		return 0;
+		return NULL;
 
  	drm_plane_helper_add(plane, &ltdc_plane_helper_funcs);
author
#2 lore raw
Quoted 4 lines · Yannick FERTRE

Hi Philippe,

Reviewed-by Yannick Fertré <[email protected]>

Applied on drm-misc-next.
Many thanks,
Philippe :-)

Quoted 31 lines · Philippe Cornu
Quoted 29 lines

"make C=1" returns 2 warnings in ltdc_plane_create() ("Using plain integer as NULL pointer"). This patch fixes them.

Signed-off-by Philippe Cornu <[email protected]>
---
   drivers/gpu/drm/stm/ltdc.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/stm/ltdc.c +2 -2
index 616191fe98ae..d997a6014d6c 100644
@@ -860,13 +860,13 @@ static struct drm_plane *ltdc_plane_create(struct drm_device *ddev,
 
   	plane = devm_kzalloc(dev, sizeof(*plane), GFP_KERNEL);
   	if (!plane)
-		return 0;
+		return NULL;
 
   	ret = drm_universal_plane_init(ddev, plane, possible_crtcs,
   				       &ltdc_plane_funcs, formats, nb_fmt,
   				       NULL, type, NULL);
   	if (ret < 0)
-		return 0;
+		return NULL;
 
   	drm_plane_helper_add(plane, &ltdc_plane_helper_funcs);