Skip to contentSkip to conversation

ARM: dts: da850-lego-ev3: Fix battery voltage gpio

PATCH In review David Lechner 2 participants 2 messages Apr 14, 2018 – Apr 19, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: da850-lego-ev3: Fix battery voltage gpio

This fixes the battery voltage monitoring gpio-hog settings.

When the gpio is low, it turns off the battery voltage to the ADC chip. However, this needs to be on all of the time so that we can monitor battery voltage.

Also, there was a typo that prevented pinmuxing from working correctly.

---

This has already been picked up in mainline in 4.15 (c5a88cd2e1c5). However, I forgot to cc stable when I originally submitted the patch. It would be nice to get this in the linux-4.14.y branch.

 arch/arm/boot/dts/da850-lego-ev3.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/da850-lego-ev3.dts +2 -2
index 413dbd5d9f64..81942ae83e1f 100644
@@ -178,7 +178,7 @@
 	 */
 	battery {
 		pinctrl-names = "default";
-		pintctrl-0 = <&battery_pins>;
+		pinctrl-0 = <&battery_pins>;
 		compatible = "lego,ev3-battery";
 		io-channels = <&adc 4>, <&adc 3>;
 		io-channel-names = "voltage", "current";
@@ -392,7 +392,7 @@
 	batt_volt_en {
 		gpio-hog;
 		gpios = <6 GPIO_ACTIVE_HIGH>;
-		output-low;
+		output-high;
 	};
 };
 
Signature · 1 line
2.17.0
maintainer
#1 lore raw
Quoted 8 lines · David Lechner

This fixes the battery voltage monitoring gpio-hog settings.

When the gpio is low, it turns off the battery voltage to the ADC chip. However, this needs to be on all of the time so that we can monitor battery voltage.

Also, there was a typo that prevented pinmuxing from working correctly.

Quoted 7 lines

---

This has already been picked up in mainline in 4.15 (c5a88cd2e1c5). However, I forgot to cc stable when I originally submitted the patch. It would be nice to get this in the linux-4.14.y branch.

Now applied, thanks.

greg k-h