Skip to contentSkip to conversation

ixgbe: return error on upsupported SFP module when resetting

PATCH New Emil Tantilov 2 participants 2 messages Apr 20, 2018 – Apr 23, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: return error on upsupported SFP module when resetting

Add check for unsupported module and return the error code. This fixes a Coverity hit due to unused return status from setup_sfp.

---
 drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c +3 -0
index beec1d0..a8148c7 100644
@@ -3408,6 +3408,9 @@ static s32 ixgbe_reset_hw_X550em(struct ixgbe_hw *hw)
 		hw->phy.sfp_setup_needed = false;
 	}
 
+	if (status == IXGBE_ERR_SFP_NOT_SUPPORTED)
+		return status;
+
 	/* Reset PHY */
 	if (!hw->phy.reset_disable && hw->phy.ops.reset)
 		hw->phy.ops.reset(hw);
#1 lore raw

PATCH 1/1 ixgbe: return error on upsupported SFP module when resetting

Quoted 8 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Emil Tantilov
Sent: Thursday, April 19, 2018 5:07 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbe: return error on upsupported SFP module when resetting

Quoted 7 lines

Add check for unsupported module and return the error code. This fixes a Coverity hit due to unused return status from setup_sfp.

---
 drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c |    3 +++
 1 file changed, 3 insertions(+)