Skip to contentSkip to conversation

ARM: dts: sun4i: Fix incorrect clocks for displays

PATCH In review Pascal Roeleven 2 participants 4 messages Apr 20, 2018 – Apr 23, 2018

Subsystems (2)
Device tree bindings Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Pascal Roeleven

author
#0 lore raw

PATCH 1/1 ARM: dts: sun4i: Fix incorrect clocks for displays

Some displays on SUN4i devices wouldn't properly stay on unless 'clk_ignore_unused' is used.

Change the duplicate clocks to the probably intended ones.

Signed-off-by Pascal Roeleven <[email protected]>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/sun4i-a10.dtsi +3 -3
index 77e8436b..3a1c6b45 100644
@@ -76,7 +76,7 @@
 			allwinner,pipeline = "de_fe0-de_be0-lcd0-hdmi";
 			clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_HDMI0>,
 				 <&ccu CLK_AHB_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
-				 <&ccu CLK_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
+				 <&ccu CLK_DE_BE0>, <&ccu CLK_DE_FE0>,
 				 <&ccu CLK_TCON0_CH1>, <&ccu CLK_HDMI>,
 				 <&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
 			status = "disabled";

@@ -88,7 +88,7 @@
 			allwinner,pipeline = "de_fe0-de_be0-lcd0";
 			clocks = <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_DE_BE0>,
 				 <&ccu CLK_AHB_DE_FE0>, <&ccu CLK_DE_BE0>,
-				 <&ccu CLK_AHB_DE_FE0>, <&ccu CLK_TCON0_CH0>,
+				 <&ccu CLK_DE_FE0>, <&ccu CLK_TCON0_CH0>,
 				 <&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
 			status = "disabled";
 		};

@@ -99,7 +99,7 @@
 			allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
 			clocks = <&ccu CLK_AHB_TVE0>, <&ccu CLK_AHB_LCD0>,
 				 <&ccu CLK_AHB_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
-				 <&ccu CLK_DE_BE0>, <&ccu CLK_AHB_DE_FE0>,
+				 <&ccu CLK_DE_BE0>, <&ccu CLK_DE_FE0>,
 				 <&ccu CLK_TCON0_CH1>, <&ccu CLK_DRAM_TVE0>,
 				 <&ccu CLK_DRAM_DE_FE0>, <&ccu CLK_DRAM_DE_BE0>;
 			status = "disabled";
Signature · 1 line
2.14.1
#1 lore raw
Quoted 6 lines · Pascal Roeleven

Some displays on SUN4i devices wouldn't properly stay on unless 'clk_ignore_unused' is used.

Change the duplicate clocks to the probably intended ones.

Signed-off-by Pascal Roeleven <[email protected]>

What was the difference with the first patch you sent?

Anyway, I've applied it, thanks

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180423/10a8cb19/attachment.sig>
author
#2 lore raw
Quoted 10 lines · Maxime Ripard
Quoted 6 lines · Pascal Roeleven

Some displays on SUN4i devices wouldn't properly stay on unless 'clk_ignore_unused' is used.

Change the duplicate clocks to the probably intended ones.

Signed-off-by Pascal Roeleven <[email protected]>

What was the difference with the first patch you sent?

Quoted 8 lines

Anyway, I've applied it, thanks

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

I'm sorry there isn't any.
It's the first patch I have ever send so had some git-send-email issues and
didn't know the correct procedure to resend a patch.

#3 lore raw
Quoted 15 lines · Pascal Roeleven
Quoted 14 lines · Maxime Ripard
Quoted 6 lines · Pascal Roeleven

Some displays on SUN4i devices wouldn't properly stay on unless 'clk_ignore_unused' is used.

Change the duplicate clocks to the probably intended ones.

Signed-off-by Pascal Roeleven <[email protected]>

What was the difference with the first patch you sent?

Anyway, I've applied it, thanks

Maxime

Quoted 8 lines
Quoted 4 lines

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

I'm sorry there isn't any.
It's the first patch I have ever send so had some git-send-email issues and didn't know the correct procedure to resend a patch.

Just set RESEND in the subject prefix (using --subject-prefix="PATCH RESEND"), and say why you resent it in the patch / cover letter after the --- and before the diffstat.

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180423/0ef32c25/attachment.sig>