Add two IR keymaps for NVIDIA devices
Subsystems (2)
cover Add two IR keymaps for NVIDIA devices
Adds two IR keymaps for NVIDIA devices.
The RC types are SONY12 and NEC.
Jun Yan (1):
media: rc: Add NVIDIA IR keymapping
drivers/media/rc/keymaps/Makefile | 2 + drivers/media/rc/keymaps/rc-nvidia-nec.c | 66 ++++++++++++++++++++++++ drivers/media/rc/keymaps/rc-nvidia.c | 66 ++++++++++++++++++++++++ include/media/rc-map.h | 2 + 4 files changed, 136 insertions(+) create mode 100644 drivers/media/rc/keymaps/rc-nvidia-nec.c create mode 100644 drivers/media/rc/keymaps/rc-nvidia.c
Signature · 1 line
2.17.0
PATCH 1/1 media: rc: Add NVIDIA IR keymapping
From: Jun Yan <[email protected]>
Add keymap with NEC and SONY12 protocol for NVIDIA IR
--- drivers/media/rc/keymaps/Makefile | 2 + drivers/media/rc/keymaps/rc-nvidia-nec.c | 66 ++++++++++++++++++++++++ drivers/media/rc/keymaps/rc-nvidia.c | 66 ++++++++++++++++++++++++ include/media/rc-map.h | 2 + 4 files changed, 136 insertions(+) create mode 100644 drivers/media/rc/keymaps/rc-nvidia-nec.c create mode 100644 drivers/media/rc/keymaps/rc-nvidia.c
drivers/media/rc/keymaps/Makefile +2 -0
@@ -75,6 +75,8 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \ rc-nec-terratec-cinergy-xs.o \ rc-norwood.o \ rc-npgtech.o \ + rc-nvidia.o \ + rc-nvidia-nec.o \ rc-pctv-sedna.o \ rc-pinnacle-color.o \ rc-pinnacle-grey.o \
drivers/media/rc/keymaps/rc-nvidia-nec.c new file +66 -0
66 lines not on this page · raw message
drivers/media/rc/keymaps/rc-nvidia.c new file +66 -0
66 lines not on this page · raw message
include/media/rc-map.h +2 -0
@@ -235,6 +235,8 @@ struct rc_map *rc_map_get(const char *name);#define RC_MAP_NEC_TERRATEC_CINERGY_XS "rc-nec-terratec-cinergy-xs"#define RC_MAP_NORWOOD "rc-norwood"#define RC_MAP_NPGTECH "rc-npgtech" +#define RC_MAP_NVIDIA "rc-nvidia" +#define RC_MAP_NVIDIA_NEC "rc-nvidia-nec"#define RC_MAP_PCTV_SEDNA "rc-pctv-sedna"#define RC_MAP_PINNACLE_COLOR "rc-pinnacle-color"#define RC_MAP_PINNACLE_GREY "rc-pinnacle-grey"
Signature · 1 line
2.17.0
kbuild test robot
build botRe: [PATCH 1/1] media: rc: Add NVIDIA IR keymapping
Thank you for the patch! Yet something to improve:
Hi Jun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17-rc1 next-20180420]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vladislav-Zhurba/media-rc-Add-NVIDIA-IR-keymapping/20180423-023840 base: git://linuxtv.org/media_tree.git master config: x86_64-allyesdebian (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/media/rc/keymaps/rc-nvidia.c:47:5: error: 'struct rc_map' has no member named 'rc_type'
.rc_type = RC_TYPE_SONY12,
^~~~~~~
>> drivers/media/rc/keymaps/rc-nvidia.c:47:15: error: 'RC_TYPE_SONY12' undeclared here (not in a function); did you mean 'RC_PROTO_SONY12'?
.rc_type = RC_TYPE_SONY12,
^~~~~~~~~~~~~~
RC_PROTO_SONY12
--
>> drivers/media/rc/keymaps/rc-nvidia-nec.c:47:5: error: 'struct rc_map' has no member named 'rc_type'
.rc_type = RC_TYPE_NEC,
^~~~~~~
>> drivers/media/rc/keymaps/rc-nvidia-nec.c:47:15: error: 'RC_TYPE_NEC' undeclared here (not in a function); did you mean 'RC_MAP_CEC'?
.rc_type = RC_TYPE_NEC,
^~~~~~~~~~~
RC_MAP_CECvim +47 drivers/media/rc/keymaps/rc-nvidia.c
42
43 static struct rc_map_list nvidia_map = {
44 .map = {
45 .scan = foster_table,
46 .size = ARRAY_SIZE(foster_table),
> 47 .rc_type = RC_TYPE_SONY12,
48 .name = RC_MAP_NVIDIA,
49 }
50 };
51 ---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
kbuild test robot
build botRe: [PATCH 1/1] media: rc: Add NVIDIA IR keymapping
In reply to Vladislav ZhurbaThank you for the patch! Yet something to improve:
Hi Jun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17-rc1 next-20180420]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vladislav-Zhurba/media-rc-Add-NVIDIA-IR-keymapping/20180423-023840 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-s1-201816 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386
All errors (new ones prefixed by >>):
>> drivers/media/rc/keymaps/rc-nvidia.c:47:4: error: unknown field 'rc_type' specified in initializer
.rc_type = RC_TYPE_SONY12,
^
>> drivers/media/rc/keymaps/rc-nvidia.c:47:15: error: 'RC_TYPE_SONY12' undeclared here (not in a function)
.rc_type = RC_TYPE_SONY12,
^~~~~~~~~~~~~~
--
>> drivers/media/rc/keymaps/rc-nvidia-nec.c:47:4: error: unknown field 'rc_type' specified in initializer
.rc_type = RC_TYPE_NEC,
^
>> drivers/media/rc/keymaps/rc-nvidia-nec.c:47:15: error: 'RC_TYPE_NEC' undeclared here (not in a function)
.rc_type = RC_TYPE_NEC,
^~~~~~~~~~~vim +/rc_type +47 drivers/media/rc/keymaps/rc-nvidia.c
42
43 static struct rc_map_list nvidia_map = {
44 .map = {
45 .scan = foster_table,
46 .size = ARRAY_SIZE(foster_table),
> 47 .rc_type = RC_TYPE_SONY12,
48 .name = RC_MAP_NVIDIA,
49 }
50 };
51 ---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Sean Young
maintainerRe: [PATCH 1/1] media: rc: Add NVIDIA IR keymapping
In reply to Vladislav ZhurbaQuoted 43 lines · Vladislav Zhurba
From: Jun Yan <[email protected]>
Add keymap with NEC and SONY12 protocol for NVIDIA IR
Signed-off-by Jun Yan <[email protected]>Signed-off-by marting <[email protected]>Signed-off-by Daniel Fu <[email protected]>Signed-off-by Vladislav Zhurba <[email protected]>--- drivers/media/rc/keymaps/Makefile | 2 + drivers/media/rc/keymaps/rc-nvidia-nec.c | 66 ++++++++++++++++++++++++ drivers/media/rc/keymaps/rc-nvidia.c | 66 ++++++++++++++++++++++++ include/media/rc-map.h | 2 + 4 files changed, 136 insertions(+) create mode 100644 drivers/media/rc/keymaps/rc-nvidia-nec.c create mode 100644 drivers/media/rc/keymaps/rc-nvidia.cdrivers/media/rc/keymaps/Makefile +2
-0@@ -75,6 +75,8 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \ rc-nec-terratec-cinergy-xs.o \ rc-norwood.o \ rc-npgtech.o \ + rc-nvidia.o \ + rc-nvidia-nec.o \ rc-pctv-sedna.o \ rc-pinnacle-color.o \ rc-pinnacle-grey.o \drivers/media/rc/keymaps/rc-nvidia-nec.c new file +7
-0@@ -0,0 +1,66 @@ +/* Keytable for NVIDIA Remote Controller +* +* Copyright (c) 2014-2018, NVIDIA CORPORATION. All rights reserved. +* +* This program is free software; you can redistribute it and/or modify it +* under the terms and conditions of the GNU General Public License, +* version 2, as published by the Free Software Foundation.
drivers/media/rc/keymaps/rc-nvidia-nec.c line 17
Quoted 10 lines
drivers/media/rc/keymaps/rc-nvidia-nec.c new file +10
-0+* +* This program is distributed in the hope it will be useful, but WITHOUT +* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for +* more details. +* +* You should have received a copy of the GNU General Public License +* along with this program. If not, see <http://www.gnu.org/licenses/>. +* +*/
Would it be possible to use the SPDX-License-Identifier please.
Quoted 20 lines
drivers/media/rc/keymaps/rc-nvidia-nec.c new file +20
-0+#include <media/rc-map.h> +#include <linux/module.h> + +static struct rc_map_table foster_table[] = { + {0x807e12 ,KEY_VOLUMEUP }, + {0x807e15 ,KEY_VOLUMEDOWN }, + {0x807e0c ,KEY_UP }, + {0x807e0e ,KEY_DOWN }, + {0x807e0b ,KEY_LEFT }, + {0x807e0d ,KEY_RIGHT }, + {0x807e09 ,KEY_HOMEPAGE }, + {0x807e06 ,KEY_POWER }, + {0x807e03 ,KEY_SELECT }, + {0x807e02 ,KEY_BACK }, + {0x807e14 ,KEY_MUTE }, + {0x807e20 ,KEY_PLAYPAUSE }, + {0x807e11 ,KEY_PLAYCD }, + {0x807e08 ,KEY_PAUSECD }, + {0x807e07 ,KEY_STOP }, + {0x807e0f ,KEY_FASTFORWARD },
drivers/media/rc/keymaps/rc-nvidia-nec.c line 47
Quoted 10 lines
drivers/media/rc/keymaps/rc-nvidia-nec.c new file +10
-0+ { 0x807e0a, KEY_REWIND }, + { 0x807e41, KEY_SLEEP }, + { 0x807e45, KEY_WAKEUP }, +}; + +static struct rc_map_list nvidia_map = { + .map = { + .scan = foster_table, + .size = ARRAY_SIZE(foster_table), + .rc_type = RC_TYPE_NEC,
This does not compile against mainline any more. Should be RC_PROTO_NEC.
drivers/media/rc/keymaps/rc-nvidia-nec.c line 48
Quoted 1 line
drivers/media/rc/keymaps/rc-nvidia-nec.c new file +1
-0+ .name = RC_MAP_NVIDIA_NEC,
Would it be possible to give it a more descriptive name, not just nvidia but also the product name.
drivers/media/rc/keymaps/rc-nvidia.c
Quoted 23 lines
drivers/media/rc/keymaps/rc-nvidia-nec.c new file +18
-0+ } +}; + +static int __init init_rc_map_nvidia (void ) +{ +return rc_map_register (&nvidia_map); +} + +static void __exit exit_rc_map_nvidia(void) +{ +rc_map_unregister (&nvidia_map); +} + +module_init (init_rc_map_nvidia); +module_exit (exit_rc_map_nvidia); + +MODULE_LICENSE ("GPL" ); +MODULE_AUTHOR ("Daniel Fu <[email protected]>" );drivers/media/rc/keymaps/rc-nvidia.c new file +0
-0
Same comments for this file.
Quoted 82 lines
drivers/media/rc/keymaps/rc-nvidia.c new file +66
-0@@ -0,0 +1,66 @@ +/* Keytable for NVIDIA Remote Controller +* +* Copyright (c) 2014-2018, NVIDIA CORPORATION. All rights reserved. +* +* This program is free software; you can redistribute it and/or modify it +* under the terms and conditions of the GNU General Public License, +* version 2, as published by the Free Software Foundation. +* +* This program is distributed in the hope it will be useful, but WITHOUT +* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for +* more details. +* +* You should have received a copy of the GNU General Public License +* along with this program. If not, see <http://www.gnu.org/licenses/>. +* +*/ +#include <media/rc-map.h> +#include <linux/module.h> + +static struct rc_map_table foster_table[] = { + {0x10009 ,KEY_0 }, + {0x10000 ,KEY_1 }, + {0x10001 ,KEY_2 }, + {0x10002 ,KEY_3 }, + {0x10003 ,KEY_4 }, + {0x10004 ,KEY_5 }, + {0x10005 ,KEY_6 }, + {0x10006 ,KEY_7 }, + {0x10007 ,KEY_8 }, + {0x10008 ,KEY_9 }, + {0x10012 ,KEY_VOLUMEUP }, + {0x10013 ,KEY_VOLUMEDOWN }, + {0x10010 ,KEY_CHANNELUP }, + {0x10011 ,KEY_CHANNELDOWN }, + {0x10074 ,KEY_UP }, + {0x10075 ,KEY_DOWN }, + {0x10034 ,KEY_LEFT }, + {0x10033 ,KEY_RIGHT }, + {0x10060 ,KEY_HOME }, +}; + +static struct rc_map_list nvidia_map = { + .map = { + .scan = foster_table, + .size =ARRAY_SIZE (foster_table), + .rc_type =RC_TYPE_SONY12 , + .name =RC_MAP_NVIDIA , + } +}; + +static int __init init_rc_map_nvidia (void ) +{ +return rc_map_register (&nvidia_map); +} + +static void __exit exit_rc_map_nvidia(void) +{ +rc_map_unregister (&nvidia_map); +} + +module_init (init_rc_map_nvidia); +module_exit (exit_rc_map_nvidia); + +MODULE_LICENSE ("GPL" ); +MODULE_AUTHOR ("Jun Yan <[email protected]>" );include/media/rc-map.h +2
-0@@ -235,6 +235,8 @@ struct rc_map *rc_map_get(const char *name);#define RC_MAP_NEC_TERRATEC_CINERGY_XS "rc-nec-terratec-cinergy-xs"#define RC_MAP_NORWOOD "rc-norwood"#define RC_MAP_NPGTECH "rc-npgtech" +#define RC_MAP_NVIDIA "rc-nvidia" +#define RC_MAP_NVIDIA_NEC "rc-nvidia-nec"#define RC_MAP_PCTV_SEDNA "rc-pctv-sedna"#define RC_MAP_PINNACLE_COLOR "rc-pinnacle-color"#define RC_MAP_PINNACLE_GREY "rc-pinnacle-grey"Signature · 1 line
2.17.0