Skip to contentSkip to conversation

vfs fixes

GIT PULL Al Viro 2 participants 4 messages Apr 20, 2018 VFS

lore
Share & tools
lore

Al Viro

author maintainer
#0 lore raw

Assorted fixes. Some of that is only a matter with fault injection
(broken handling of small allocation failure in various mount-related places), but the last one is a root-triggerable stack overflow, and combined with userns it gets really nasty ;-/

The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:

Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

for you to fetch changes up to 16a34adb9392b2fe4195267475ab5b472e55292c:

Don't leak MNT_INTERNAL away from internal mounts (2018-04-19 23:52:15 -0400)

----------------------------------------------------------------
Al Viro (5):
hypfs_kill_super(): deal with failed allocations jffs2_kill_sb(): deal with failed allocations orangefs_kill_sb(): deal with allocation failures
rpc_pipefs: fix double-dput()
Don't leak MNT_INTERNAL away from internal mounts

Tetsuo Handa (1):
mm,vmscan: Allow preallocating memory for register_shrinker().

 arch/s390/hypfs/inode.c  |  2 +-
 fs/jffs2/super.c         |  2 +-
 fs/namespace.c           |  3 ++-
 fs/orangefs/super.c      |  5 +++++
 fs/super.c               |  9 ++++-----
 include/linux/shrinker.h |  7 +++++--
 mm/vmscan.c              | 21 ++++++++++++++++++++-
 net/sunrpc/rpc_pipe.c    |  1 +
 8 files changed, 39 insertions(+), 11 deletions(-)
#1 lore raw
Quoted 13 lines · On Fri, 20 Apr 2018 16:58:46 +0100 Al Viro <[email protected]> wrote:

Assorted fixes. Some of that is only a matter with fault injection
(broken handling of small allocation failure in various mount-related places), but the last one is a root-triggerable stack overflow, and combined with userns it gets really nasty ;-/

The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:

Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

Quoted 7 lines

for you to fetch changes up to 16a34adb9392b2fe4195267475ab5b472e55292c:

Don't leak MNT_INTERNAL away from internal mounts (2018-04-19 23:52:15 -0400)
...

Tetsuo Handa (1):
mm,vmscan: Allow preallocating memory for register_shrinker().

Confused. You had a bunch of issues with this patch
(http://lkml.kernel.org/r/[email protected])
and Tetsuo sent out a v2 but now we've merged the v1. Deliberate?

Also, it would be nice if you could get the Link: thing working in your commits please - this one took a bit of hunting down.

author maintainer
#2 lore raw
Quoted 20 lines · Andrew Morton
Quoted 18 lines · On Fri, 20 Apr 2018 16:58:46 +0100 Al Viro <[email protected]> wrote:

Assorted fixes. Some of that is only a matter with fault injection
(broken handling of small allocation failure in various mount-related places), but the last one is a root-triggerable stack overflow, and combined with userns it gets really nasty ;-/

The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:

Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

for you to fetch changes up to 16a34adb9392b2fe4195267475ab5b472e55292c:

Don't leak MNT_INTERNAL away from internal mounts (2018-04-19 23:52:15 -0400)
...

Quoted 6 lines
Quoted 2 lines

Tetsuo Handa (1):
mm,vmscan: Allow preallocating memory for register_shrinker().

Confused. You had a bunch of issues with this patch
(http://lkml.kernel.org/r/[email protected])
and Tetsuo sent out a v2 but now we've merged the v1. Deliberate?

I think by that time I'd applied v1 and fixed those issues myself (same as his variant, modulo slightly different names).

Quoted 2 lines

Also, it would be nice if you could get the Link: thing working in your commits please - this one took a bit of hunting down.

*blink*

What Link: thing? You mean lkml.kernel.org references to original postings? Or is it something else? Never done that, actually; any tips re tools needed for that? Normally it's save a bunch of postings into a local file in mutt, scp it over to development box, then git am -s - either all at once, or step by step with ediiting and git commit --amend in between...

I realize that message-id can be picked and massaged into Link: ... form, of course, but I'd rather not reinvent the wheel if it's already done by somebody...

#3 lore raw
Quoted 24 lines · On Fri, 20 Apr 2018 20:09:56 +0100 Al Viro <[email protected]> wrote:
Quoted 23 lines · Andrew Morton
Quoted 20 lines · On Fri, 20 Apr 2018 16:58:46 +0100 Al Viro <[email protected]> wrote:

Assorted fixes. Some of that is only a matter with fault injection
(broken handling of small allocation failure in various mount-related places), but the last one is a root-triggerable stack overflow, and combined with userns it gets really nasty ;-/

The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:

Linux 4.17-rc1 (2018-04-15 18:24:20 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

for you to fetch changes up to 16a34adb9392b2fe4195267475ab5b472e55292c:

Don't leak MNT_INTERNAL away from internal mounts (2018-04-19 23:52:15 -0400)
...

Tetsuo Handa (1):
mm,vmscan: Allow preallocating memory for register_shrinker().

Quoted 6 lines
Quoted 3 lines

Confused. You had a bunch of issues with this patch
(http://lkml.kernel.org/r/[email protected])
and Tetsuo sent out a v2 but now we've merged the v1. Deliberate?

I think by that time I'd applied v1 and fixed those issues myself (same as his variant, modulo slightly different names).

AH.

Quoted 6 lines
Quoted 2 lines

Also, it would be nice if you could get the Link: thing working in your commits please - this one took a bit of hunting down.

*blink*

What Link: thing? You mean lkml.kernel.org references to original postings?

yup. It's often fairly useful.

Quoted 4 lines

Or is it something else? Never done that, actually; any tips re tools needed for that? Normally it's save a bunch of postings into a local file in mutt, scp it over to development box, then git am -s - either all at once, or step by step with ediiting and git commit --amend in between...

I'd have expected git-am to have a way of doing that by now.

Quoted 3 lines

I realize that message-id can be picked and massaged into Link: ... form, of course, but I'd rather not reinvent the wheel if it's already done by somebody...

I just do this:

message_url()

{
	pname="$1"

	idline=$(grep -i "^Message-Id:" "$pname" | head -1)
	if [ x"$idline" != "x" ]
	then
		msgid=$(echo "$idline" | sed -e 's/[^<]*<\([^>]*\).*/\1/')
		if [ x"$msgid" != "x" ]
		then
			echo "http://lkml.kernel.org/r/$msgid"
		fi
	fi
}