Skip to contentSkip to conversation

reaver: add missing dependency on non static lib.

PATCH New Guillaume W. Bres 3 participants 4 messages Apr 20, 2018 – Apr 21, 2018

lore
Share & tools
lore

Guillaume W. Bres

author
#0 lore raw

PATCH v2 1/1 reaver: add missing dependency on non static lib.

Fixes

	http://autobuild.buildroot.net/results/0fb387f0544e962e5080ea966864f325fbaf4117
Signed-off-by Guillaume W. Bres <[email protected]>

---

v2: static libs are now allowed. I used Arnout's suggestion which caused ./configure to pass. Then there was a linker problem that was solved by using the trick on LDFLAGS this time. Build now passes.

 package/reaver/reaver.mk | 5 +++++
 1 file changed, 5 insertions(+)
package/reaver/reaver.mk +5 -0
index 90d1727..8dfec32 100644
@@ -14,4 +14,9 @@ REAVER_LICENSE_FILES = docs/LICENSE
 REAVER_SUBDIR = src
 REAVER_DEPENDENCIES = libpcap
 
+ifeq ($(BR2_STATIC_LIBS),y)
+REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
+REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 reaver: add missing dependency on non static lib.

Hello,

package/reaver/reaver.mk REAVER_LICENSE_FILES = docs/LICENSE · line 20

Quoted 4 lines · Guillaume W. Bres
package/reaver/reaver.mk +4 -0
+ifeq ($(BR2_STATIC_LIBS),y)
+REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
+REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
+endif

Are you sure you need both LIBS and LDFLAGS ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH v2 1/1 reaver: add missing dependency on non static lib.

2018-04-20 20:56 GMT+02:00 Thomas Petazzoni <[email protected]>:

Quoted 4 lines

Hello,

On Fri, 20 Apr 2018 20:27:15 +0200, Guillaume W. Bres wrote:

Quoted 10 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+ifeq ($(BR2_STATIC_LIBS),y)
+REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static

--additional-libs`"

Quoted 1 line

+REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config

--static --additional-libs`"

Quoted 1 line

+endif

Are you sure you need both LIBS and LDFLAGS ?

yes I confirm this configuration does not build without these two lines.
"LIBS+=" caused "./configure" to pass, but then "make" failed with missing reference to -ldbus-1.
"LDFLAGS+=" caused "make" to pass. LDFLAGS on its own does not solve the "./configure" issue
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180421/7f4bbc88/attachment.html>

#3 lore raw

PATCH v2 1/1 reaver: add missing dependency on non static lib.

In reply to Guillaume W. Bres

Hi Guillaume,

Quoted 10 lines · Guillaume W. Bres

Fixes

	http://autobuild.buildroot.net/results/0fb387f0544e962e5080ea966864f325fbaf4117
Signed-off-by Guillaume W. Bres <[email protected]>

---

v2: static libs are now allowed. I used Arnout's suggestion which caused ./configure to pass. Then there was a linker problem that was solved by using the trick on LDFLAGS this time. Build now passes.

The patch title is wrong now. Should be something like "fix static build".

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -