autofs: mount point create should honour passed in mode
PATCH 9/15 autofs: mount point create should honour passed in mode
From: Ian Kent <[email protected]>
Subject: autofs: mount point create should honour passed in mode
The autofs file system mkdir inode operation blindly sets the created directory mode to S_IFDIR | 0555, ingoring the passed in mode, which can cause selinux dac_override denials.
But the function also checks if the caller is the daemon (as no-one else should be able to do anything here) so there's no point in not honouring the passed in mode, allowing the daemon to set appropriate mode when required.
Signed-off-by Ian Kent <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
fs/autofs4/root.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/autofs4/root.c renamed from fs/autofs4/root.c~autofs-mount-point-create-should-honour-passed-in-mode +1 -1
@@ -749,7 +749,7 @@ static int autofs4_dir_mkdir(struct inodautofs4_del_active (dentry); - inode =autofs4_get_inode (dir->i_sb,S_IFDIR |0555 ); + inode =autofs4_get_inode (dir->i_sb,S_IFDIR | mode);if (!inode)return -ENOMEM ;d_add (dentry, inode);
_