Revert "f2fs: introduce f2fs_set_page_dirty_nobuffer"
Jaegeuk Kim
maintainerPATCH 1/1 Revert "f2fs: introduce f2fs_set_page_dirty_nobuffer"
This patch reverts copied f2fs_set_page_dirty_nobuffer to use generic function for stability.
This reverts commit fe76b796fc5194cc3d57265002e3a748566d073f.
Signed-off-by Jaegeuk Kim <[email protected]>
--- fs/f2fs/checkpoint.c | 2 +- fs/f2fs/data.c | 33 +-------------------------------- fs/f2fs/f2fs.h | 1 - fs/f2fs/node.c | 2 +- 4 files changed, 3 insertions(+), 35 deletions(-)
fs/f2fs/checkpoint.c +1 -1
@@ -384,7 +384,7 @@ static int f2fs_set_meta_page_dirty(struct page *page)if (!PageUptodate (page))SetPageUptodate (page);if (!PageDirty (page)) { -f2fs_set_page_dirty_nobuffers (page); +__set_page_dirty_nobuffers (page);inc_page_count (F2FS_P_SB (page),F2FS_DIRTY_META );SetPagePrivate (page);f2fs_trace_pid (page);
fs/f2fs/data.c +1 -32
@@ -19,8 +19,6 @@#include <linux/bio.h> #include <linux/prefetch.h> #include <linux/uio.h> -#include <linux/mm.h> -#include <linux/memcontrol.h> #include <linux/cleancache.h> #include <linux/sched/signal.h>
@@ -2471,35 +2469,6 @@ int f2fs_release_page(struct page *page, gfp_t wait)return 1 ; } -/* -* This was copied from __set_page_dirty_buffers which gives higher performance -* in very high speed storages. (e.g., pmem) -*/ -void f2fs_set_page_dirty_nobuffers (struct page *page) -{ -struct address_space *mapping = page->mapping; -unsigned long flags; - -if (unlikely (!mapping)) -return ; - -spin_lock (&mapping->private_lock); -lock_page_memcg (page); -SetPageDirty (page); -spin_unlock (&mapping->private_lock); - -xa_lock_irqsave (&mapping->i_pages, flags); -WARN_ON_ONCE (!PageUptodate (page)); -account_page_dirtied (page, mapping); -radix_tree_tag_set (&mapping->i_pages, -page_index (page),PAGECACHE_TAG_DIRTY ); -xa_unlock_irqrestore (&mapping->i_pages, flags); -unlock_page_memcg (page); - -__mark_inode_dirty (mapping->host,I_DIRTY_PAGES ); -return ; -} -static int f2fs_set_data_page_dirty (struct page *page) {struct address_space *mapping = page->mapping;
@@ -2523,7 +2492,7 @@ static int f2fs_set_data_page_dirty(struct page *page) }if (!PageDirty (page)) { -f2fs_set_page_dirty_nobuffers (page); +__set_page_dirty_nobuffers (page);update_dirty_page (inode, page);return 1 ; }
fs/f2fs/f2fs.h +0 -1
@@ -2939,7 +2939,6 @@ int f2fs_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, u64 start, u64 len);bool should_update_inplace (struct inode *inode,struct f2fs_io_info *fio);bool should_update_outplace (struct inode *inode,struct f2fs_io_info *fio); -void f2fs_set_page_dirty_nobuffers (struct page *page);int __f2fs_write_data_pages (struct address_space *mapping,struct writeback_control *wbc,enum iostat_type io_type);
fs/f2fs/node.c +1 -1
@@ -1753,7 +1753,7 @@ static int f2fs_set_node_page_dirty(struct page *page)if (!PageUptodate (page))SetPageUptodate (page);if (!PageDirty (page)) { -f2fs_set_page_dirty_nobuffers (page); +__set_page_dirty_nobuffers (page);inc_page_count (F2FS_P_SB (page),F2FS_DIRTY_NODES );SetPagePrivate (page);f2fs_trace_pid (page);
Signature · 1 line
2.17.0.484.g0c8726318c-goog
Quoted 6 lines · Jaegeuk Kim
This patch reverts copied
f2fs_set_page_dirty_nobufferto use generic function for stability.This reverts commit
fe76b796fc5194cc3d57265002e3a748566d073f.Signed-off-by Jaegeuk Kim <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,