Skip to contentSkip to conversation

android: binder: Change return type to vm_fault_t

PATCH In review Souptick Joarder 2 participants 3 messages Apr 16, 2018 – Apr 23, 2018 Android drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 android: binder: Change return type to vm_fault_t

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference commit id-> 1c8f422059ae5da07db7406ab916203f9417e396

---
 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/android/binder.c +1 -1
index 15e3d3c..65be4ec 100644
@@ -4671,7 +4671,7 @@ static void binder_vma_close(struct vm_area_struct *vma)
 	binder_defer_work(proc, BINDER_DEFERRED_PUT_FILES);
 }
 
-static int binder_vm_fault(struct vm_fault *vmf)
+static vm_fault_t binder_vm_fault(struct vm_fault *vmf)
 {
 	return VM_FAULT_SIGBUS;
 }

--
1.9.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

maintainer
#1 lore raw
Quoted 9 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Reference commit id-> 1c8f422059ae5da07db7406ab916203f9417e396

As you know, that is not how you reference git commit ids. Please fix up and resend.

thanks,

greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

#2 lore raw
Quoted 8 lines · Greg KH
Quoted 7 lines · Souptick Joarder

Use new return type vm_fault_t for fault handler in struct vm_operations_struct. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type.

Quoted 5 lines
Quoted 2 lines

Reference commit id-> 1c8f422059ae5da07db7406ab916203f9417e396

As you know, that is not how you reference git commit ids. Please fix up and resend.

Sure, I will send v2.