Skip to contentSkip to conversation

staging: mt7621-eth: fix line over 80 char issue in mtk_set_link_ksettings()

PATCH In review Jefferson Capovilla 2 participants 2 messages Apr 4, 2018 – Apr 23, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: mt7621-eth: fix line over 80 char issue in mtk_set_link_ksettings()

Fix 'line over 80 characters' issue found by checkpatch.pl script in mtk_set_link_ksettings().

---
 drivers/staging/mt7621-eth/ethtool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/mt7621-eth/ethtool.c +2 -2
index 38ba0c0..e9f4092 100644
@@ -52,7 +52,8 @@ static int mtk_set_link_ksettings(struct net_device *dev,
 			mac->phy_dev = mac->hw->phy->phy[cmd->base.phy_address];
 			mac->phy_flags = MTK_PHY_FLAG_PORT;
 		} else if (mac->hw->mii_bus) {
-			mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus, cmd->base.phy_address);
+			mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus,
+						       cmd->base.phy_address);
 			if (!mac->phy_dev)
 				return -ENODEV;
 			mac->phy_flags = MTK_PHY_FLAG_ATTACH;
@@ -62,7 +63,6 @@ static int mtk_set_link_ksettings(struct net_device *dev,
 	}
 
 	return phy_ethtool_ksettings_set(mac->phy_dev, cmd);
-
 }
 
 static void mtk_get_drvinfo(struct net_device *dev,
Signature · 6 lines
2.7.4

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
maintainer
#1 lore raw
Quoted 23 lines · Jefferson Capovilla

Fix 'line over 80 characters' issue found by checkpatch.pl script in mtk_set_link_ksettings().

---
 drivers/staging/mt7621-eth/ethtool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/mt7621-eth/ethtool.c +2 -1
index 38ba0c0..e9f4092 100644
@@ -52,7 +52,8 @@ static int mtk_set_link_ksettings(struct net_device *dev,
 			mac->phy_dev = mac->hw->phy->phy[cmd->base.phy_address];
 			mac->phy_flags = MTK_PHY_FLAG_PORT;
 		} else if (mac->hw->mii_bus) {
-			mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus, cmd->base.phy_address);
+			mac->phy_dev = mdiobus_get_phy(mac->hw->mii_bus,
+						       cmd->base.phy_address);
 			if (!mac->phy_dev)
 				return -ENODEV;
 			mac->phy_flags = MTK_PHY_FLAG_ATTACH;

drivers/staging/mt7621-eth/ethtool.c static int mtk_set_link_ksettings(struct net_device *dev, · line 65

Quoted 4 lines
drivers/staging/mt7621-eth/ethtool.c +0 -1
@@ -62,7 +63,6 @@ static int mtk_set_link_ksettings(struct net_device *dev,
 	}
 
 	return phy_ethtool_ksettings_set(mac->phy_dev, cmd);
-

You did this too :(

Don't lie in a changelog text, please fix up and resend.

greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel