staging: pi433: break long lines in pi433_if.c
PATCH 1/1 staging: pi433: break long lines in pi433_if.c
Breaks long lines in pi433_if.c, fixing checkpatch.pl warnings:
"WARNING: line over 80 characters"
Signed-off-by Simon Sandström <[email protected]>
--- drivers/staging/pi433/pi433_if.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)
drivers/staging/pi433/pi433_if.c +14 -5
@@ -593,14 +593,18 @@ pi433_tx_thread(void *data) retval =kfifo_out (&device->tx_fifo, &tx_cfg,sizeof (tx_cfg));if (retval !=sizeof (tx_cfg)) { -dev_dbg (device->dev,"reading tx_cfg from fifo failed: got %d byte(s), expected %d" , retval, (unsigned int )sizeof (tx_cfg)); +dev_dbg (device->dev, +"reading tx_cfg from fifo failed: got %d byte(s), expected %d" , + retval, (unsigned int )sizeof (tx_cfg));mutex_unlock (&device->tx_fifo_lock);continue ; } retval =kfifo_out (&device->tx_fifo, &size,sizeof (size_t ));if (retval !=sizeof (size_t )) { -dev_dbg (device->dev,"reading msg size from fifo failed: got %d, expected %d" , retval, (unsigned int )sizeof (size_t )); +dev_dbg (device->dev, +"reading msg size from fifo failed: got %d, expected %d" , + retval, (unsigned int )sizeof (size_t ));mutex_unlock (&device->tx_fifo_lock);continue ; }
@@ -623,7 +627,11 @@ pi433_tx_thread(void *data)/* add length byte, if requested */ if (tx_cfg.enable_length_byte ==OPTION_ON ) - device->buffer[position++] = size -1 ;/* according to spec length byte itself must be excluded from the length calculation */ +/* +* according to spec, length byte itself must be +* excluded from the length calculation +*/ + device->buffer[position++] = size -1 ;/* add adr byte, if requested */ if (tx_cfg.enable_address_byte ==OPTION_ON )
@@ -856,7 +864,8 @@ pi433_write(struct file *filp, const char __user *buf, abort:dev_dbg (device->dev,"write to fifo failed: 0x%x" , retval); -kfifo_reset (&device->tx_fifo);// TODO: maybe find a solution, not to discard already stored, valid entries +/* TODO: find a solution to not discard already stored valid entries */ +kfifo_reset (&device->tx_fifo);mutex_unlock (&device->tx_fifo_lock);return -EAGAIN ; }
@@ -1042,7 +1051,7 @@ static int setup_gpio(struct pi433_device *device)/* configure irq */ device->irq_num[i] =gpiod_to_irq (device->gpiod[i]);if (device->irq_num[i] <0 ) { - device->gpiod[i] =ERR_PTR (-EINVAL );//(struct gpio_desc *)device->irq_num[i]; + device->gpiod[i] =ERR_PTR (-EINVAL );return device->irq_num[i]; } retval = request_irq(device->irq_num[i],
Signature · 6 lines
2.11.0 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greg KH
maintainerQuoted 7 lines · Simon Sandström
Breaks long lines in
pi433_if.c, fixing checkpatch.pl warnings:
"WARNING: line over 80 characters"Signed-off-by Simon Sandström <[email protected]>--- drivers/staging/pi433/pi433_if.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-)
This patch did not apply, please fix up and resend.
thanks,
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel