drm: mali-dp: Enable Global SE interrupts mask for DP500
Subsystems (3)
PATCH 1/1 drm: mali-dp: Enable Global SE interrupts mask for DP500
In the situation that DE and SE aren’t shared the same interrupt number, the Global SE interrupts mask bit MASK_IRQ_EN in MASKIRQ must be set, or else other mask bits will not work and no SE interrupt will occur. This patch enables MASK_IRQ_EN for SE to fix this problem.
Signed-off-by Alison Wang <[email protected]>
--- drivers/gpu/drm/arm/malidp_hw.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/gpu/drm/arm/malidp_hw.c +2 -1
@@ -634,7 +634,8 @@ static int malidp650_query_hw(struct malidp_hw_device *hwdev) .vsync_irq = MALIDP500_DE_IRQ_VSYNC, }, .se_irq_map = { - .irq_mask = MALIDP500_SE_IRQ_CONF_MODE, + .irq_mask =MALIDP500_SE_IRQ_CONF_MODE | + MALIDP500_SE_IRQ_GLOBAL, .vsync_irq = 0, }, .dc_irq_map = {
Signature · 6 lines
1.7.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 6 lines · Alison Wang
In the situation that DE and SE aren’t shared the same interrupt number, the Global SE interrupts mask bit
MASK_IRQ_ENin MASKIRQ must be set, or else other mask bits will not work and no SE interrupt will occur. This patch enablesMASK_IRQ_ENfor SE to fix this problem.Signed-off-by Alison Wang <[email protected]>
Acked-by Liviu Dudau <[email protected]>
Thanks for catching this! I'll pull the patch into the mali-dp tree.
Best regards,
Liviu
Quoted 21 lines
--- drivers/gpu/drm/arm/malidp_hw.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)drivers/gpu/drm/arm/malidp_hw.c +2
-1@@ -634,7 +634,8 @@ static int malidp650_query_hw(struct malidp_hw_device *hwdev) .vsync_irq = MALIDP500_DE_IRQ_VSYNC, }, .se_irq_map = { - .irq_mask = MALIDP500_SE_IRQ_CONF_MODE, + .irq_mask =MALIDP500_SE_IRQ_CONF_MODE | + MALIDP500_SE_IRQ_GLOBAL, .vsync_irq = 0, }, .dc_irq_map = {Signature · 1 line
1.7.1
Signature · 12 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel