Skip to contentSkip to conversation

drm/edid: Reset more of the display info

PATCH In review Ville Syrjala 4 participants 9 messages Apr 24, 2018 – Apr 25, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/edid: Reset more of the display info

From: Ville Syrjälä <[email protected]>

We're currently failing to reset everything in display_info.hdmi which will potentially cause us to use stale information when swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor with a HDMI 1.x monitor we will continue to think that the monitor supports scrambling. That will lead to a black screen since the HDMI 1.x monitor won't understand the scrambled signal.

Fix the problem by clearing display_info.hdmi fully. And while at eliminate some duplicated code by calling drm_reset_display_info() in drm_add_display_info().

Cc: Antony Chen <[email protected]>
Cc: Shashank Sharma <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105655

---
 drivers/gpu/drm/drm_edid.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/gpu/drm/drm_edid.c +3 -8
index 134069f36482..39f1db4acda4 100644
@@ -4451,6 +4451,7 @@ drm_reset_display_info(struct drm_connector *connector)
 	info->max_tmds_clock = 0;
 	info->dvi_dual = false;
 	info->has_hdmi_infoframe = false;
+	memset(&info->hdmi, 0, sizeof(info->hdmi));
 
 	info->non_desktop = 0;
 }
@@ -4462,17 +4463,11 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
 
 	u32 quirks = edid_get_quirks(edid);
 
+	drm_reset_display_info(connector);
+
 	info->width_mm = edid->width_cm * 10;
 	info->height_mm = edid->height_cm * 10;
 
-	/* driver figures it out in this case */
-	info->bpc = 0;
-	info->color_formats = 0;
-	info->cea_rev = 0;
-	info->max_tmds_clock = 0;
-	info->dvi_dual = false;
-	info->has_hdmi_infoframe = false;
-
 	info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP);
 
 	DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop);
Signature · 6 lines
2.16.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 34 lines · Ville Syrjala

From: Ville Syrjälä <[email protected]>

We're currently failing to reset everything in display_info.hdmi which will potentially cause us to use stale information when swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor with a HDMI 1.x monitor we will continue to think that the monitor supports scrambling. That will lead to a black screen since the HDMI 1.x monitor won't understand the scrambled signal.

Fix the problem by clearing display_info.hdmi fully. And while at eliminate some duplicated code by calling drm_reset_display_info() in drm_add_display_info().

Cc: Antony Chen <[email protected]>
Cc: Shashank Sharma <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105655

---
 drivers/gpu/drm/drm_edid.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/gpu/drm/drm_edid.c +1 -0
index 134069f36482..39f1db4acda4 100644
@@ -4451,6 +4451,7 @@ drm_reset_display_info(struct drm_connector *connector)
 	info->max_tmds_clock = 0;
 	info->dvi_dual = false;
 	info->has_hdmi_infoframe = false;
+	memset(&info->hdmi, 0, sizeof(info->hdmi));
 
 	info->non_desktop = 0;
 }

drivers/gpu/drm/drm_edid.c u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi · line 4467

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +2 -0
@@ -4462,17 +4463,11 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
 
 	u32 quirks = edid_get_quirks(edid);
 
+	drm_reset_display_info(connector);
+

Strictly speaking this is a separate bugfix, for the case where you immediately go from one output to a different one. Keith already fixed the case where at least somewhere in between you go to the disconnected state in:

commit 170178fe99dd212bf25e70c89bc4b6e195564ffc

Author: Keith Packard <[email protected]>
Date:   Wed Dec 13 00:44:26 2017 -0800

drm: Update edid-derived drm_display_info fields at edid property set [v2]

With the above explained in the commit message:

Quoted 21 lines
drivers/gpu/drm/drm_edid.c +0 -8
 	info->width_mm = edid->width_cm * 10;
 	info->height_mm = edid->height_cm * 10;
 
-	/* driver figures it out in this case */
-	info->bpc = 0;
-	info->color_formats = 0;
-	info->cea_rev = 0;
-	info->max_tmds_clock = 0;
-	info->dvi_dual = false;
-	info->has_hdmi_infoframe = false;
-
 	info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP);
 
 	DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop);
Signature · 6 lines
2.16.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 46 lines · Daniel Vetter
Quoted 34 lines · Ville Syrjala

From: Ville Syrjälä <[email protected]>

We're currently failing to reset everything in display_info.hdmi which will potentially cause us to use stale information when swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor with a HDMI 1.x monitor we will continue to think that the monitor supports scrambling. That will lead to a black screen since the HDMI 1.x monitor won't understand the scrambled signal.

Fix the problem by clearing display_info.hdmi fully. And while at eliminate some duplicated code by calling drm_reset_display_info() in drm_add_display_info().

Cc: Antony Chen <[email protected]>
Cc: Shashank Sharma <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105655

---
 drivers/gpu/drm/drm_edid.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/gpu/drm/drm_edid.c +1 -0
index 134069f36482..39f1db4acda4 100644
@@ -4451,6 +4451,7 @@ drm_reset_display_info(struct drm_connector *connector)
 	info->max_tmds_clock = 0;
 	info->dvi_dual = false;
 	info->has_hdmi_infoframe = false;
+	memset(&info->hdmi, 0, sizeof(info->hdmi));
 
 	info->non_desktop = 0;
 }

drivers/gpu/drm/drm_edid.c u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi · line 4467

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +2 -0
@@ -4462,17 +4463,11 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
 
 	u32 quirks = edid_get_quirks(edid);
 
+	drm_reset_display_info(connector);
+

Strictly speaking this is a separate bugfix, for the case where you immediately go from one output to a different one. Keith already fixed the case where at least somewhere in between you go to the disconnected state in:

Quoted 7 lines

commit 170178fe99dd212bf25e70c89bc4b6e195564ffc

Author: Keith Packard <[email protected]>
Date:   Wed Dec 13 00:44:26 2017 -0800

drm: Update edid-derived drm_display_info fields at edid property set [v2]

With the above explained in the commit message:

The drm_reset_display_info() call is just the "deduplicate the code" part. The memset() is the bugfix, and applies in all cases.

Quoted 29 lines
Quoted 21 lines
drivers/gpu/drm/drm_edid.c +0 -8
 	info->width_mm = edid->width_cm * 10;
 	info->height_mm = edid->height_cm * 10;
 
-	/* driver figures it out in this case */
-	info->bpc = 0;
-	info->color_formats = 0;
-	info->cea_rev = 0;
-	info->max_tmds_clock = 0;
-	info->dvi_dual = false;
-	info->has_hdmi_infoframe = false;
-
 	info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP);
 
 	DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop);
Signature · 6 lines
2.16.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by
#3 lore raw
Quoted 51 lines · Ville Syrjälä
Quoted 50 lines · Daniel Vetter
Quoted 34 lines · Ville Syrjala

From: Ville Syrjälä <[email protected]>

We're currently failing to reset everything in display_info.hdmi which will potentially cause us to use stale information when swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor with a HDMI 1.x monitor we will continue to think that the monitor supports scrambling. That will lead to a black screen since the HDMI 1.x monitor won't understand the scrambled signal.

Fix the problem by clearing display_info.hdmi fully. And while at eliminate some duplicated code by calling drm_reset_display_info() in drm_add_display_info().

Cc: Antony Chen <[email protected]>
Cc: Shashank Sharma <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105655

---
 drivers/gpu/drm/drm_edid.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/gpu/drm/drm_edid.c +1 -0
index 134069f36482..39f1db4acda4 100644
@@ -4451,6 +4451,7 @@ drm_reset_display_info(struct drm_connector *connector)
 	info->max_tmds_clock = 0;
 	info->dvi_dual = false;
 	info->has_hdmi_infoframe = false;
+	memset(&info->hdmi, 0, sizeof(info->hdmi));
 
 	info->non_desktop = 0;
 }

drivers/gpu/drm/drm_edid.c u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi · line 4467

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +2 -0
@@ -4462,17 +4463,11 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
 
 	u32 quirks = edid_get_quirks(edid);
 
+	drm_reset_display_info(connector);
+

Strictly speaking this is a separate bugfix, for the case where you immediately go from one output to a different one. Keith already fixed the case where at least somewhere in between you go to the disconnected state in:

commit 170178fe99dd212bf25e70c89bc4b6e195564ffc

Author: Keith Packard <[email protected]>
Date:   Wed Dec 13 00:44:26 2017 -0800
Quoted 6 lines
Quoted 3 lines

drm: Update edid-derived drm_display_info fields at edid property set [v2]

With the above explained in the commit message:

The drm_reset_display_info() call is just the "deduplicate the code" part. The memset() is the bugfix, and applies in all cases.

Hm ... I guess my brain wasn't fully working.

as-is.
-Daniel

Quoted 34 lines
Quoted 30 lines
Quoted 21 lines
drivers/gpu/drm/drm_edid.c +0 -8
 	info->width_mm = edid->width_cm * 10;
 	info->height_mm = edid->height_cm * 10;
 
-	/* driver figures it out in this case */
-	info->bpc = 0;
-	info->color_formats = 0;
-	info->cea_rev = 0;
-	info->max_tmds_clock = 0;
-	info->dvi_dual = false;
-	info->has_hdmi_infoframe = false;
-
 	info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP);
 
 	DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop);
Signature · 6 lines
2.16.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Signature · 2 lines
Ville Syrjälä
Intel
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

Hi all,

The patch works: drivers/gpu/drm/drm_edid.c
I switch 4K@60 and 4K@30 monitors some times, monitors show correct output. Thanks for your help.

What are the steps to close the issue in freedesktop? Append the patch by Ville Syrjälä, then I close it?

Antony

2018-04-25 3:36 GMT+08:00 Daniel Vetter <[email protected]>:

Quoted 102 lines · Ville Syrjälä
Quoted 23 lines · Daniel Vetter
Quoted 22 lines · Ville Syrjala
Quoted 21 lines

From: Ville Syrjälä <[email protected]>

We're currently failing to reset everything in display_info.hdmi which will potentially cause us to use stale information when swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor with a HDMI 1.x monitor we will continue to think that the monitor supports scrambling. That will lead to a black screen since the HDMI 1.x monitor won't understand the scrambled signal.

Fix the problem by clearing display_info.hdmi fully. And while at eliminate some duplicated code by calling drm_reset_display_info() in drm_add_display_info().

Cc: Antony Chen <[email protected]>
Cc: Shashank Sharma <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105655

---
 drivers/gpu/drm/drm_edid.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/drm_edid.c drm_reset_display_info(struct drm_connector

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +0 -0
index 134069f36482..39f1db4acda4 100644
@@ -4451,6 +4451,7 @@ drm_reset_display_info(struct drm_connector

*connector)

Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/drm_edid.c u32 drm_add_display_info(struct

Quoted 8 lines
drivers/gpu/drm/drm_edid.c +1 -0
  info->max_tmds_clock = 0;
  info->dvi_dual = false;
  info->has_hdmi_infoframe = false;
+ memset(&info->hdmi, 0, sizeof(info->hdmi));
 
  info->non_desktop = 0;
 }
@@ -4462,17 +4463,11 @@ u32 drm_add_display_info(struct

drm_connector *connector, const struct edid *edi

Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/drm_edid.c u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi · line 4467

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +2 -0
  u32 quirks = edid_get_quirks(edid);
 
+ drm_reset_display_info(connector);
+

Strictly speaking this is a separate bugfix, for the case where you immediately go from one output to a different one. Keith already fixed

the

Quoted 1 line
Quoted 1 line

case where at least somewhere in between you go to the disconnected

state

Quoted 7 lines
Quoted 7 lines

in:

commit 170178fe99dd212bf25e70c89bc4b6e195564ffc

Author: Keith Packard <[email protected]>
Date:   Wed Dec 13 00:44:26 2017 -0800

drm: Update edid-derived drm_display_info fields at edid property

set [v2]

Quoted 5 lines
Quoted 2 lines

With the above explained in the commit message:

The drm_reset_display_info() call is just the "deduplicate the code" part. The memset() is the bugfix, and applies in all cases.

Hm ... I guess my brain wasn't fully working.

as-is.
-Daniel

Quoted 31 lines
Quoted 30 lines
Quoted 17 lines
drivers/gpu/drm/drm_edid.c +0 -9
  info->width_mm = edid->width_cm * 10;
  info->height_mm = edid->height_cm * 10;
 
- /* driver figures it out in this case */
- info->bpc = 0;
- info->color_formats = 0;
- info->cea_rev = 0;
- info->max_tmds_clock = 0;
- info->dvi_dual = false;
- info->has_hdmi_infoframe = false;
-
  info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP);
 
  DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop);
--

2.16.1

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Quoted 9 lines
Quoted 3 lines

--
Ville Syrjälä
Intel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw
Quoted 8 lines · Antony Chen

Hi all,

The patch works: drivers/gpu/drm/drm_edid.c
I switch 4K@60 and 4K@30 monitors some times, monitors show correct output. Thanks for your help.

What are the steps to close the issue in freedesktop? Append the patch by Ville Syrjälä, then I close it?

The bug is now resolved. Thanks for reporting the problem and testing the fix.

Quoted 116 lines

Antony

2018-04-25 3:36 GMT+08:00 Daniel Vetter <[email protected]>:

Quoted 111 lines · Ville Syrjälä
Quoted 23 lines · Daniel Vetter
Quoted 22 lines · Ville Syrjala
Quoted 21 lines

From: Ville Syrjälä <[email protected]>

We're currently failing to reset everything in display_info.hdmi which will potentially cause us to use stale information when swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor with a HDMI 1.x monitor we will continue to think that the monitor supports scrambling. That will lead to a black screen since the HDMI 1.x monitor won't understand the scrambled signal.

Fix the problem by clearing display_info.hdmi fully. And while at eliminate some duplicated code by calling drm_reset_display_info() in drm_add_display_info().

Cc: Antony Chen <[email protected]>
Cc: Shashank Sharma <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105655

---
 drivers/gpu/drm/drm_edid.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
Quoted 5 lines
Quoted 5 lines

drivers/gpu/drm/drm_edid.c drm_reset_display_info(struct drm_connector

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +0 -0
index 134069f36482..39f1db4acda4 100644
@@ -4451,6 +4451,7 @@ drm_reset_display_info(struct drm_connector

*connector)

Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/drm_edid.c u32 drm_add_display_info(struct

Quoted 8 lines
drivers/gpu/drm/drm_edid.c +1 -0
  info->max_tmds_clock = 0;
  info->dvi_dual = false;
  info->has_hdmi_infoframe = false;
+ memset(&info->hdmi, 0, sizeof(info->hdmi));
 
  info->non_desktop = 0;
 }
@@ -4462,17 +4463,11 @@ u32 drm_add_display_info(struct

drm_connector *connector, const struct edid *edi

Quoted 8 lines
Quoted 8 lines

drivers/gpu/drm/drm_edid.c u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi · line 4467

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +2 -0
  u32 quirks = edid_get_quirks(edid);
 
+ drm_reset_display_info(connector);
+

Strictly speaking this is a separate bugfix, for the case where you immediately go from one output to a different one. Keith already fixed

the

Quoted 1 line
Quoted 1 line

case where at least somewhere in between you go to the disconnected

state

Quoted 7 lines
Quoted 7 lines

in:

commit 170178fe99dd212bf25e70c89bc4b6e195564ffc

Author: Keith Packard <[email protected]>
Date:   Wed Dec 13 00:44:26 2017 -0800

drm: Update edid-derived drm_display_info fields at edid property

set [v2]

Quoted 5 lines
Quoted 2 lines

With the above explained in the commit message:

The drm_reset_display_info() call is just the "deduplicate the code" part. The memset() is the bugfix, and applies in all cases.

Hm ... I guess my brain wasn't fully working.

as-is.
-Daniel

Quoted 26 lines
Quoted 26 lines
Quoted 21 lines
drivers/gpu/drm/drm_edid.c +0 -9
  info->width_mm = edid->width_cm * 10;
  info->height_mm = edid->height_cm * 10;
 
- /* driver figures it out in this case */
- info->bpc = 0;
- info->color_formats = 0;
- info->cea_rev = 0;
- info->max_tmds_clock = 0;
- info->dvi_dual = false;
- info->has_hdmi_infoframe = false;
-
  info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP);
 
  DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop);
--

2.16.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Quoted 8 lines
Quoted 4 lines

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

--
Ville Syrjälä
Intel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author Tested-by Antony Chen Applied
#6 lore raw
In reply to Daniel Vetter
Quoted 56 lines · Daniel Vetter
Quoted 55 lines · Ville Syrjälä
Quoted 53 lines · Daniel Vetter
Quoted 34 lines · Ville Syrjala

From: Ville Syrjälä <[email protected]>

We're currently failing to reset everything in display_info.hdmi which will potentially cause us to use stale information when swapping monitors. Eg. if the user replaces a HDMI 2.0 monitor with a HDMI 1.x monitor we will continue to think that the monitor supports scrambling. That will lead to a black screen since the HDMI 1.x monitor won't understand the scrambled signal.

Fix the problem by clearing display_info.hdmi fully. And while at eliminate some duplicated code by calling drm_reset_display_info() in drm_add_display_info().

Cc: Antony Chen <[email protected]>
Cc: Shashank Sharma <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105655

---
 drivers/gpu/drm/drm_edid.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/gpu/drm/drm_edid.c +1 -0
index 134069f36482..39f1db4acda4 100644
@@ -4451,6 +4451,7 @@ drm_reset_display_info(struct drm_connector *connector)
 	info->max_tmds_clock = 0;
 	info->dvi_dual = false;
 	info->has_hdmi_infoframe = false;
+	memset(&info->hdmi, 0, sizeof(info->hdmi));
 
 	info->non_desktop = 0;
 }

drivers/gpu/drm/drm_edid.c u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi · line 4467

Quoted 5 lines
drivers/gpu/drm/drm_edid.c +2 -0
@@ -4462,17 +4463,11 @@ u32 drm_add_display_info(struct drm_connector *connector, const struct edid *edi
 
 	u32 quirks = edid_get_quirks(edid);
 
+	drm_reset_display_info(connector);
+

Strictly speaking this is a separate bugfix, for the case where you immediately go from one output to a different one. Keith already fixed the case where at least somewhere in between you go to the disconnected state in:

commit 170178fe99dd212bf25e70c89bc4b6e195564ffc

Author: Keith Packard <[email protected]>
Date:   Wed Dec 13 00:44:26 2017 -0800

drm: Update edid-derived drm_display_info fields at edid property set [v2]

With the above explained in the commit message:

Quoted 8 lines
Quoted 2 lines

The drm_reset_display_info() call is just the "deduplicate the code" part. The memset() is the bugfix, and applies in all cases.

Hm ... I guess my brain wasn't fully working.

as-is.

Cool. Thanks.

Pushed to drm-misc-fixes with

Quoted 41 lines

-Daniel

Quoted 34 lines
Quoted 30 lines
Quoted 21 lines
drivers/gpu/drm/drm_edid.c +0 -8
 	info->width_mm = edid->width_cm * 10;
 	info->height_mm = edid->height_cm * 10;
 
-	/* driver figures it out in this case */
-	info->bpc = 0;
-	info->color_formats = 0;
-	info->cea_rev = 0;
-	info->max_tmds_clock = 0;
-	info->dvi_dual = false;
-	info->has_hdmi_infoframe = false;
-
 	info->non_desktop = !!(quirks & EDID_QUIRK_NON_DESKTOP);
 
 	DRM_DEBUG_KMS("non_desktop set to %d\n", info->non_desktop);
Signature · 6 lines
2.16.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Signature · 2 lines
Ville Syrjälä
Intel
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw

✓ Fi.CI.BAT: success for drm/edid: Reset more of the display info

In reply to Ville Syrjala
== Series Details ==

== Series Details ==

Series: drm/edid: Reset more of the display info
URL : https://patchwork.freedesktop.org/series/42191/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4086 -> Patchwork_8788 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/42191/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_8788:

=== IGT changes ===

    ==== Possible regressions ====

    igt@kms_psr_sink_crc@psr_basic:
      {fi-hsw-4200u}:     NOTRUN -> FAIL

== Known issues ==

Here are the changes found in Patchwork_8788 that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-ivb-3520m:       PASS -> DMESG-WARN (fdo#106084)

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084

== Participating hosts (36 -> 34) ==

Additional (1): fi-hsw-4200u
Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq

== Build changes ==

* Linux: CI_DRM_4086 -> Patchwork_8788

CI_DRM_4086: 10d9666c9a49d47bcb5be8fa4116ef6508155aff @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4446: e5e8dafc991ee922ec159491c680caff0cfe9235 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8788: 7b7203fdea70afbb0a94169624dca292c4623d28 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4446: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit

== Linux commits ==

7b7203fdea70 drm/edid: Reset more of the display info

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8788/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✓ Fi.CI.IGT: success for drm/edid: Reset more of the display info

In reply to Ville Syrjala
== Series Details ==

== Series Details ==

Series: drm/edid: Reset more of the display info
URL : https://patchwork.freedesktop.org/series/42191/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4086_full -> Patchwork_8788_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_8788_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_8788_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/42191/revisions/1/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_8788_full:

=== IGT changes ===

    ==== Warnings ====

    igt@kms_plane@plane-panning-bottom-right-pipe-a-planes:
      shard-glk:          SKIP -> PASS +122

== Known issues ==

Here are the changes found in Patchwork_8788_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#102887, fdo#105363)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-apl:          PASS -> FAIL (fdo#103167)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-hsw:          PASS -> FAIL (fdo#103925)

    
    ==== Possible fixes ====

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#102887, fdo#105363) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
      shard-apl:          FAIL (fdo#103167) -> PASS

fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363

== Participating hosts (6 -> 4) ==

Missing (2): shard-glkb shard-kbl

== Build changes ==

* Linux: CI_DRM_4086 -> Patchwork_8788

CI_DRM_4086: 10d9666c9a49d47bcb5be8fa4116ef6508155aff @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4446: e5e8dafc991ee922ec159491c680caff0cfe9235 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8788: 7b7203fdea70afbb0a94169624dca292c4623d28 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4446: a2f486679f467cd6e82578384f56d4aabaa8cf2e @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8788/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx