Skip to contentSkip to conversation

mfd: intel-lpss: Correct names of RESETS register bits

PATCH Applied Andy Shevchenko 3 participants 4 messages Apr 24, 2018 – Jun 4, 2018

Subsystems (2)
Multifunction devices (MFD) Intel LPSS (Low Power SubSystem) drivers
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 mfd: intel-lpss: Correct names of RESETS register bits

According to documentation the function has 2 bits for reset while iDMA 64-bit has only one.

Rename it accordingly. Note, there is no functional change since we always handle them together.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mfd/intel-lpss.c +2 -2
index 4bcf117a7ba8..50bffc3382d7 100644
@@ -40,8 +40,8 @@
 
 /* Offsets from lpss->priv */
 #define LPSS_PRIV_RESETS		0x04
-#define LPSS_PRIV_RESETS_FUNC		BIT(2)
-#define LPSS_PRIV_RESETS_IDMA		0x3
+#define LPSS_PRIV_RESETS_IDMA		BIT(2)
+#define LPSS_PRIV_RESETS_FUNC		0x3
 
 #define LPSS_PRIV_ACTIVELTR		0x10
 #define LPSS_PRIV_IDLELTR		0x14
Signature · 1 line
2.17.0
author reviewer
#2 lore raw
Quoted 10 lines · Mika Westerberg
Quoted 7 lines · Andy Shevchenko

According to documentation the function has 2 bits for reset while iDMA 64-bit has only one.

Rename it accordingly. Note, there is no functional change since we always handle them together.

Signed-off-by Andy Shevchenko <[email protected]>
Acked-by Mika Westerberg <[email protected]>

Thanks, Mika!

Lee, anything about this one? (it's not stable material, though I don't see it in linux-next)

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
Applied
#3 lore raw
In reply to Andy Shevchenko
Quoted 10 lines · Andy Shevchenko

According to documentation the function has 2 bits for reset while iDMA 64-bit has only one.

Rename it accordingly. Note, there is no functional change since we always handle them together.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/mfd/intel-lpss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog