Skip to contentSkip to conversation

arm64: dts: exynos: Remove unneeded address space mapping for soc node

PATCH In review Krzysztof Kozlowski 2 participants 3 messages Apr 24, 2018 – Apr 29, 2018

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: exynos: Remove unneeded address space mapping for soc node

Remove the address space mapping between root and soc nodes to fix DTC warnings in Exynos5433 and Exynos7 like:

arch/arm64/boot/dts/exynos/exynos5433-tm2.dtb:
Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

---

Not tested.

---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
 arch/arm64/boot/dts/exynos/exynos7.dtsi    | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +3 -3
index 828996a06610..ba8157ceaa56 100644
@@ -18,8 +18,8 @@
 
 / {
 	compatible = "samsung,exynos5433";
-	#address-cells = <2>;
-	#size-cells = <2>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	interrupt-parent = <&gic>;
 
@@ -235,7 +235,7 @@
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0x0 0x0 0x0 0x18000000>;
+		ranges;
 
 		arm_a53_pmu {
 			compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3";
arch/arm64/boot/dts/exynos/exynos7.dtsi +3 -3
index 0b98d2334cad..93a84338938a 100644
@@ -12,8 +12,8 @@
 / {
 	compatible = "samsung,exynos7";
 	interrupt-parent = <&gic>;
-	#address-cells = <2>;
-	#size-cells = <2>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
 	aliases {
 		pinctrl0 = &pinctrl_alive;
@@ -70,7 +70,7 @@
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0 0 0 0x18000000>;
+		ranges;
 
 		chipid at 10000000 {
 			compatible = "samsung,exynos4210-chipid";
Signature · 1 line
2.14.1
Tested-by on v1 1/1
#1 lore raw

Hi Krzysztof,

Quoted 7 lines · Krzysztof Kozlowski

Remove the address space mapping between root and soc nodes to fix DTC warnings in Exynos5433 and Exynos7 like:

arch/arm64/boot/dts/exynos/exynos5433-tm2.dtb:
Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

Works fine on Samsung Exynos5433-based TM2e board.

Quoted 48 lines

---

Not tested.

---
  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 6 +++---
  arch/arm64/boot/dts/exynos/exynos7.dtsi    | 6 +++---
  2 files changed, 6 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/exynos/exynos5433.dtsi +3 -3
index 828996a06610..ba8157ceaa56 100644
@@ -18,8 +18,8 @@
 
  / {
  	compatible = "samsung,exynos5433";
-	#address-cells = <2>;
-	#size-cells = <2>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
  	interrupt-parent = <&gic>;
 
@@ -235,7 +235,7 @@
  		compatible = "simple-bus";
  		#address-cells = <1>;
  		#size-cells = <1>;
-		ranges = <0x0 0x0 0x0 0x18000000>;
+		ranges;
 
  		arm_a53_pmu {
  			compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3";
arch/arm64/boot/dts/exynos/exynos7.dtsi +2 -2
index 0b98d2334cad..93a84338938a 100644
@@ -12,8 +12,8 @@
  / {
  	compatible = "samsung,exynos7";
  	interrupt-parent = <&gic>;
-	#address-cells = <2>;
-	#size-cells = <2>;
+	#address-cells = <1>;
+	#size-cells = <1>;
 
  	aliases {
  		pinctrl0 = &pinctrl_alive;

arch/arm64/boot/dts/exynos/exynos7.dtsi line 76

Quoted 8 lines
arch/arm64/boot/dts/exynos/exynos7.dtsi +1 -1
@@ -70,7 +70,7 @@
  		compatible = "simple-bus";
  		#address-cells = <1>;
  		#size-cells = <1>;
-		ranges = <0 0 0 0x18000000>;
+		ranges;
 
  		chipid at 10000000 {
  			compatible = "samsung,exynos4210-chipid";

Best regards

Signature · 2 lines
Marek Szyprowski, PhD
Samsung R&D Institute Poland
author maintainer
#2 lore raw
Quoted 6 lines · Marek Szyprowski

Hi Krzysztof,

Quoted 3 lines · Krzysztof Kozlowski

Remove the address space mapping between root and soc nodes to fix DTC warnings in Exynos5433 and Exynos7 like:

Quoted 8 lines
Quoted 4 lines

arch/arm64/boot/dts/exynos/exynos5433-tm2.dtb:
Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name

Works fine on Samsung Exynos5433-based TM2e board.

Thanks for testing! Applied.

Best regards,
Krzysztof