Skip to contentSkip to conversation

fabrics: add option to supply keep-alive-timeout for connect-all

PATCH New Johannes Thumshirn 2 participants 2 messages Apr 25, 2018

Subsystems (2)
Documentation NVMe
lore
Share & tools
lore

Johannes Thumshirn

author
#0 lore raw

PATCH 1/1 fabrics: add option to supply keep-alive-timeout for connect-all

Currently we can't supply a keep-alive-timeout when doing a nvme connect-all, but we can supply it when doing nvme connect.

Bring connect-all in line with connect.

Signed-off-by Johannes Thumshirn <jthumshirn at suse.de>
---
 Documentation/nvme-connect-all.txt | 5 +++++
 fabrics.c                          | 1 +
 2 files changed, 6 insertions(+)
Documentation/nvme-connect-all.txt +5 -0
index 03adac56f9aa..217268f97559 100644
@@ -14,6 +14,7 @@ SYNOPSIS
 		[--trsvcid=<trsvcid>      | -s <trsvcid>]
 		[--host-traddr=<traddr>   | -w <traddr>]
 		[--hostnqn=<hostnqn>      | -q <hostnqn>]
+		[--keep-alive-tmo=<#>     | -k <#>]
 		[--raw=<filename>         | -r <filename>]
 
 DESCRIPTION

@@ -86,6 +87,10 @@ OPTIONS
 	Overrides the default number of elements in the I/O queues created
 	by the driver.
 
+-k <#>::
+--keep-alive-tmo=<#>::
+	Overrides the default keep alive timeout (in seconds).
+
 EXAMPLES
 --------
 * Connect to all records returned by the Discover Controller with IP4 address
fabrics.c +1 -0
index 62bd3be1636d..7e9d56c61c45 100644
@@ -821,6 +821,7 @@ int discover(const char *desc, int argc, char **argv, bool connect)
 		{"queue-size",  'Q', "LIST", CFG_STRING, &cfg.queue_size,  required_argument, "number of io queue elements to use (default 128)" },
 		{"nr-io-queues",'i', "LIST", CFG_STRING, &cfg.nr_io_queues,required_argument, "number of io queues to use (default is core count)" },
 		{"raw",         'r', "LIST", CFG_STRING, &cfg.raw,         required_argument, "raw output file" },
+		{"keep-alive-tmo",  'k', "LIST", CFG_STRING, &cfg.keep_alive_tmo,  required_argument, "keep alive timeout period in seconds" },
 		{NULL},
 	};
Signature · 1 line
2.16.3
Applied
#1 lore raw

PATCH 1/1 fabrics: add option to supply keep-alive-timeout for connect-all

Quoted 6 lines · Johannes Thumshirn

Currently we can't supply a keep-alive-timeout when doing a nvme connect-all, but we can supply it when doing nvme connect.

Bring connect-all in line with connect.

Signed-off-by Johannes Thumshirn <jthumshirn at suse.de>

Applied, thanks!