Skip to contentSkip to conversation

boot/uboot: default to kconfig buildsystem for latest version

PATCH New Yann E. MORIN 4 participants 4 messages Apr 24, 2018 – Apr 25, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 boot/uboot: default to kconfig buildsystem for latest version

By default, the builsystem for uboot defaults to 'legacy', while the default version is very well capable of using the 'kconfig' buildsystem instead.

Having the 'legacy' buildsystem be the default in that case makes it quite inconvenient for users: they would expect to be able to use e.g. uboot-menuconfig et al. with the default uboot version.

Switch to using 'kconfig' when we use the latest version. Keep the 'legacy' as default for everything else.

Also, invert the 'legacy' and 'kconfig' entries in the choice: it is nicer to have the recent and future-proodf entry first.

---
 boot/uboot/Config.in | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
boot/uboot/Config.in +7 -6
index b980745d1b..95c17e3986 100644
@@ -6,20 +6,21 @@ config BR2_TARGET_UBOOT
 if BR2_TARGET_UBOOT
 choice
 	prompt "Build system"
+	default BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG if BR2_TARGET_UBOOT_LATEST_VERSION
 	default BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
 
-config BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
-	bool "Legacy"
-	help
-	  Select this option if you use an old U-Boot (older than
-	  2015.04), so that we use the old build system.
-
 config BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG
 	bool "Kconfig"
 	help
 	  Select this option if you use a recent U-Boot version (2015.04
 	  or newer), so that we use the Kconfig build system.
 
+config BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
+	bool "Legacy"
+	help
+	  Select this option if you use an old U-Boot (older than
+	  2015.04), so that we use the old build system.
+
 endchoice
 
 if BR2_TARGET_UBOOT_BUILD_SYSTEM_LEGACY
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 boot/uboot: default to kconfig buildsystem for latest version

Hi Yann,

Quoted 8 lines

By default, the builsystem for uboot defaults to 'legacy', while the default version is very well capable of using the 'kconfig' buildsystem instead.

Having the 'legacy' buildsystem be the default in that case makes it quite inconvenient for users: they would expect to be able to use e.g. uboot-menuconfig et al. with the default uboot version.

Quoted 7 lines

Switch to using 'kconfig' when we use the latest version. Keep the 'legacy' as default for everything else.

Also, invert the 'legacy' and 'kconfig' entries in the choice: it is nicer to have the recent and future-proodf entry first.

Good idea :).

Kind regards,
Petr

#2 lore raw

PATCH 1/1 boot/uboot: default to kconfig buildsystem for latest version

Quoted 13 lines · Petr Vorel

Hi Yann,

Quoted 10 lines

By default, the builsystem for uboot defaults to 'legacy', while the default version is very well capable of using the 'kconfig' buildsystem instead.

Having the 'legacy' buildsystem be the default in that case makes it quite inconvenient for users: they would expect to be able to use e.g. uboot-menuconfig et al. with the default uboot version.

Switch to using 'kconfig' when we use the latest version. Keep the 'legacy' as default for everything else.

Quoted 7 lines
Quoted 4 lines

Also, invert the 'legacy' and 'kconfig' entries in the choice: it is nicer to have the recent and future-proodf entry first.

Good idea :).

Yegor

#3 lore raw

PATCH 1/1 boot/uboot: default to kconfig buildsystem for latest version

In reply to Yann E. MORIN

Hello,

Quoted 11 lines · Yann E. MORIN

By default, the builsystem for uboot defaults to 'legacy', while the default version is very well capable of using the 'kconfig' buildsystem instead.

Having the 'legacy' buildsystem be the default in that case makes it quite inconvenient for users: they would expect to be able to use e.g. uboot-menuconfig et al. with the default uboot version.

Switch to using 'kconfig' when we use the latest version. Keep the 'legacy' as default for everything else.

Quoted 7 lines

Also, invert the 'legacy' and 'kconfig' entries in the choice: it is nicer to have the recent and future-proodf entry first.

---
 boot/uboot/Config.in | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com