reaver: fix build errors with static lib
PATCH v3 1/1 reaver: fix build errors with static lib
---
v2: build now passes even when BR2_STATIC_LIB=y,
LIBS+=pcap-config caused "./configure" tu pass,
LDFLAGS+=pcap-config fixed problems with "make",
they're both needed.
v3: edited commit to something more releavant
package/reaver/reaver.mk | 5 +++++ 1 file changed, 5 insertions(+)
package/reaver/reaver.mk +5 -0
@@ -14,4 +14,9 @@ REAVER_LICENSE_FILES = docs/LICENSE REAVER_SUBDIR = src REAVER_DEPENDENCIES = libpcap +ifeq ($(BR2_STATIC_LIBS),y) +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" +endif + $(eval $(autotools-package))
Signature · 1 line
2.7.4
PATCH v3 1/1 reaver: fix build errors with static lib
Hello,
Quoted 1 line · Guillaume W. Bres
Signed-off-by Guillaume W. Bres <[email protected]>
This commit log was way too short, and lacked a reference to the autobuilder failure being fixed. I've fixed that when applying.
package/reaver/reaver.mk REAVER_LICENSE_FILES = docs/LICENSE · line 19
Quoted 3 lines
package/reaver/reaver.mk +3
-0+ifeq ($(BR2_STATIC_LIBS),y) +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`" +REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs`"
Other issues/improvements here:
- We generally pass such variables in <pkg>_CONF_ENV
- A single <pkg>_CONF_ENV assignment is enough
- LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still needs to be passed.
I've fixed those different problems, and applied. See the final commit at:
https://git.buildroot.org/buildroot/commit/?id=559416ffe2039d1cac94e348bd28e963adf008a4
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH v3 1/1 reaver: fix build errors with static lib
2018-04-25 22:32 GMT+02:00 Thomas Petazzoni <[email protected]>:
Quoted 29 lines
Hello,
Quoted 1 line · Guillaume W. Bres
Signed-off-by Guillaume W. Bres <[email protected]>This commit log was way too short, and lacked a reference to the autobuilder failure being fixed. I've fixed that when applying.
Review
Quoted 2 lines
(quoted diff) +2
-0+ifeq ($(BR2_STATIC_LIBS),y) +REAVER_CONF_OPTS += LIBS="`$(STAGING_DIR)/usr/bin/pcap-config --static--additional-libs`"
Quoted 1 line
+REAVER_CONF_OPTS += LDFLAGS="`$(STAGING_DIR)/usr/bin/pcap-config
--static --additional-libs`"
Other issues/improvements here:
- We generally pass such variables in <pkg>_CONF_ENV
- A single <pkg>_CONF_ENV assignment is enough
- LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still needs to be passed.
I've fixed those different problems, and applied. See the final commit at:
https://git.buildroot.org/buildroot/commit/?id=
559416ffe2039d1cac94e348bd28e963adf008a4
Quoted 8 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com
Hello,
- LDFLAGS shouldn't be overridden entirely: $(TARGET_LDFLAGS) still needs
Quoted 1 line
to be passed.
yes you're right, I should have done it
- We generally pass such variables in <pkg>_CONF_ENV
I did not know what would work, in the sense the configure command is
$CONF_ENV ./configure $CONF_OPTS
I thought these flags had to be passed after "./configure"
This commit log was way too short,
I agree & my first commits were confusing
and lacked a reference to the autobuilder failure being fixed. I've fixed
Quoted 1 line
that when applying.
honestly my first 2 versions included it, I "forgot" to add it to my last submission
Guillaume W. Bres
Software engineer - Noise XT
10a Rue Blaise Pascal,
78990 Elancourt
<[email protected]>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180426/cdda2ec6/attachment.html>