IB: make INFINIBAND_ADDR_TRANS configurable

PATCH In review Greg Thelen 2 participants 3 messages Apr 25, 2018 – Apr 26, 2018 InfiniBand

Share & tools

Greg Thelen

author

2018-04-25 22:34 UTC #0 lore raw

PATCH 5/5 IB: make INFINIBAND_ADDR_TRANS configurable

Allow INFINIBAND without INFINIBAND_ADDR_TRANS because fuzzing has been finding fair number of CM bugs. So provide option to disable it.

Signed-off-by Greg Thelen <[email protected]>

Cc Tarick Bedeir <[email protected]>

---
 drivers/infiniband/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

drivers/infiniband/Kconfig +4 -1

index ee270e065ba9..2a972ed6851b 100644
@@ -61,9 +61,12 @@ config INFINIBAND_ON_DEMAND_PAGING
 	  pages on demand instead.
 
 config INFINIBAND_ADDR_TRANS
-	bool
+	bool "RDMA/CM"
 	depends on INFINIBAND
 	default y
+	---help---
+	  Support for RDMA communication manager (CM).
+	  This allows for a generic connection abstraction over RDMA.
 
 config INFINIBAND_ADDR_TRANS_CONFIGFS
 	bool

Signature · 1 line

2.17.0.441.gb46fe60e1d-goog

Please provide a cover letter when posting a patch series. Such a cover letter is not only informative but also makes it easy for people who want to comment on a patch series as a whole. I have a question that applies to the entire patch series. The RDMA/CM code defines functions like rdma_create_id() and rdma_create_qp(). If I search through the kernel tree for callers of these functions then I find several more kernel modules than the ones that are modified by this patch series:

$ git grep -lE '[[:blank:]](rdma_create_id|rdma_create_qp)\('
drivers/infiniband/core/cma.c
drivers/infiniband/ulp/iser/iser_verbs.c
drivers/infiniband/ulp/isert/ib_isert.c
drivers/infiniband/ulp/srp/ib_srp.c
drivers/infiniband/ulp/srpt/ib_srpt.c
drivers/nvme/host/rdma.c
drivers/nvme/target/rdma.c
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
fs/cifs/smbdirect.c
include/rdma/rdma_cm.h
net/9p/trans_rdma.c
net/rds/ib.c
net/rds/ib_cm.c
net/rds/rdma_transport.c
net/sunrpc/xprtrdma/svc_rdma_transport.c
net/sunrpc/xprtrdma/verbs.c

Are you sure that this patch series is complete?

Thanks,

Bart.

Greg Thelen

author

2018-04-26 02:24 UTC #2 lore raw

Quoted 28 lines · Bart Van Assche

Quoted 14 lines · Greg Thelen
Allow INFINIBAND without INFINIBAND_ADDR_TRANS because fuzzing has been finding fair number of CM bugs. So provide option to disable it.
Signed-off-by Greg Thelen <[email protected]>
Cc Tarick Bedeir <[email protected]>
---
 drivers/infiniband/Kconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/infiniband/Kconfig +0 -0
index ee270e065ba9..2a972ed6851b 100644
drivers/infiniband/Kconfig config INFINIBAND_ON_DEMAND_PAGING · line 69
Quoted 10 lines
drivers/infiniband/Kconfig +4 -1
@@ -61,9 +61,12 @@ config INFINIBAND_ON_DEMAND_PAGING
        pages on demand instead.
 
 config INFINIBAND_ADDR_TRANS
-     bool
+     bool "RDMA/CM"
      depends on INFINIBAND
      default y
+     ---help---
+       Support for RDMA communication manager (CM).
+       This allows for a generic connection abstraction over RDMA.
Hello Greg,

Quoted 6 lines

Please provide a cover letter when posting a patch series. Such a cover letter is not only informative but also makes it easy for people who want to comment on a patch series as a whole. I have a question that applies to the entire patch series. The RDMA/CM code defines functions like rdma_create_id() and rdma_create_qp(). If I search through the kernel tree for callers of these functions then I find several more kernel modules

than

Quoted 21 lines

the ones that are modified by this patch series:

$ git grep -lE '[[:blank:]](rdma_create_id|rdma_create_qp)\('
drivers/infiniband/core/cma.c
drivers/infiniband/ulp/iser/iser_verbs.c
drivers/infiniband/ulp/isert/ib_isert.c
drivers/infiniband/ulp/srp/ib_srp.c
drivers/infiniband/ulp/srpt/ib_srpt.c
drivers/nvme/host/rdma.c
drivers/nvme/target/rdma.c
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h
fs/cifs/smbdirect.c
include/rdma/rdma_cm.h
net/9p/trans_rdma.c
net/rds/ib.c
net/rds/ib_cm.c
net/rds/rdma_transport.c
net/sunrpc/xprtrdma/svc_rdma_transport.c
net/sunrpc/xprtrdma/verbs.c

Quoted 1 line

Are you sure that this patch series is complete?

I'll check your cited files. I'll resend with cover letter.

FYI: I already rand this series through the 0-day builder, which presumably would've caught most config dep issues. But I'll research your list before reposting.