Skip to contentSkip to conversation

`NameError` is currently thrown in create_npm.py

PATCH In review [email protected] 2 participants 2 messages Apr 26, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 `NameError` is currently thrown in create_npm.py

From: Sarah Marsh <[email protected]>

This happens if an optional npm dependency does not support Linux.

---
 scripts/lib/recipetool/create_npm.py | 1 +
 1 file changed, 1 insertion(+)
scripts/lib/recipetool/create_npm.py +1 -0
index fb57e705f2..bb42a5ca5c 100644
@@ -320,6 +320,7 @@ class NpmRecipeHandler(RecipeHandler):
                     blacklist = True
                     break
             if (not blacklist and 'linux' not in pkg_os) or '!linux' in pkg_os:
+                pkg = pdata.get('name', 'Unnamed package')
                 logger.debug(2, "Skipping %s since it's incompatible with Linux" % pkg)
                 return False
         return True
Signature · 1 line
2.14.3 (Apple Git-98)
#1 lore raw

✗ patchtest: failure for `NameError` is currently thrown in create_npm.py

== Series Details ==

Series: NameError is currently thrown in create_npm.py
Revision: 1
URL : https://patchwork.openembedded.org/series/11926/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            `NameError` is currently thrown in create_npm.py
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe