dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
Subsystems (2)
PATCH v2 1/1 dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
Request IRQ with IRQF_SHARED flag. This works since the interrupt handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise.
---
Changes from v1:
- Added Lars' Acked-by
- Dropped patch [1/2] and changed accordingly
--- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/dma-axi-dmac.c +1 -1
@@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)if (ret) goto err_unregister_device; - ret =request_irq (dmac->irq, axi_dmac_interrupt_handler,0 , + ret =request_irq (dmac->irq, axi_dmac_interrupt_handler,IRQF_SHARED ,dev_name (&pdev->dev), dmac);if (ret) goto err_unregister_of;
Quoted 3 lines · Moritz Fischer
Request IRQ with
IRQF_SHAREDflag. This works since the interrupt handler already checks if there is an actual IRQ pending and returnsIRQ_NONEotherwise.
hmmm what are we trying to fix here? Is your device on a shared line or not?
Quoted 27 lines
Signed-off-by Moritz Fischer <[email protected]>---
Changes from v1:
- Added Lars' Acked-by
- Dropped patch [1/2] and changed accordingly--- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/dma-axi-dmac.c +1
-1@@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)if (ret) goto err_unregister_device; - ret =request_irq (dmac->irq, axi_dmac_interrupt_handler,0 , + ret =request_irq (dmac->irq, axi_dmac_interrupt_handler,IRQF_SHARED ,dev_name (&pdev->dev), dmac);if (ret) goto err_unregister_of;Signature · 1 line
2.17.0
Signature · 1 line
~Vinod
Lars-Peter Clausen
maintainerQuoted 6 lines · Vinod Koul
Quoted 3 lines · Moritz Fischer
Request IRQ with
IRQF_SHAREDflag. This works since the interrupt handler already checks if there is an actual IRQ pending and returnsIRQ_NONEotherwise.hmmm what are we trying to fix here? Is your device on a shared line or not?
IRQF_SHARED does not mean that the IRQ is on a shared line. It means that the driver can handle it if the IRQ is on a shared line. Since the driver can handle it setting the flag is a good idea since this enables usecases where the line is shared.
Quoted 20 lines
Quoted 20 lines
Signed-off-by Moritz Fischer <[email protected]>---
Changes from v1:
- Added Lars' Acked-by
- Dropped patch [1/2] and changed accordingly--- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/dma-axi-dmac.c +0
-0@@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)if (ret) goto err_unregister_device;
Quoted 9 lines
Quoted 8 lines
drivers/dma/dma-axi-dmac.c +1
-1- ret =request_irq (dmac->irq, axi_dmac_interrupt_handler,0 , + ret =request_irq (dmac->irq, axi_dmac_interrupt_handler,IRQF_SHARED ,dev_name (&pdev->dev), dmac);if (ret) goto err_unregister_of;Signature · 1 line
2.17.0
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Lars-Peter Clausen
Quoted 5 lines · Vinod Koul
Quoted 3 lines · Moritz Fischer
Request IRQ with
IRQF_SHAREDflag. This works since the interrupt handler already checks if there is an actual IRQ pending and returnsIRQ_NONEotherwise.
Quoted 6 lines
Quoted 1 line
hmmm what are we trying to fix here? Is your device on a shared line or not?
IRQF_SHAREDdoes not mean that the IRQ is on a shared line. It means that the driver can handle it if the IRQ is on a shared line. Since the driver can handle it setting the flag is a good idea since this enables usecases where the line is shared.
Yes that is correct indeed, but what is the motivation for the change.
If you never expect this to be in shared environment why to do this? Sorry but "it works" is not a good enough reason for this change, to enable usecases where the line is shared is a good reason :)
Signature · 1 line
~Vinod
Hi Vinod,
Quoted 14 lines · Vinod Koul
Quoted 6 lines · Lars-Peter Clausen
Quoted 5 lines · Vinod Koul
Quoted 3 lines · Moritz Fischer
Request IRQ with
IRQF_SHAREDflag. This works since the interrupt handler already checks if there is an actual IRQ pending and returnsIRQ_NONEotherwise.Quoted 6 lines
Quoted 1 line
hmmm what are we trying to fix here? Is your device on a shared line or not?
IRQF_SHAREDdoes not mean that the IRQ is on a shared line. It means that the driver can handle it if the IRQ is on a shared line. Since the driver can handle it setting the flag is a good idea since this enables usecases where the line is shared.
Quoted 5 lines
Yes that is correct indeed, but what is the motivation for the change.
If you never expect this to be in shared environment why to do this? Sorry but "it works" is not a good enough reason for this change, to enable usecases where the line is shared is a good reason :)
Remember, this is an FPGA soft core. I happen to have a design [1] where it is hooked up with multiple of them on one IRQ line, so to make this work, I need this change.
Thanks,
Moritz
[1] https://www.ettus.com/product/details/USRP-N310
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Lars-Peter Clausen
maintainerQuoted 19 lines · Moritz Fischer
Hi Vinod,
Quoted 16 lines · Vinod Koul
Quoted 6 lines · Lars-Peter Clausen
Quoted 5 lines · Vinod Koul
Quoted 3 lines · Moritz Fischer
Request IRQ with
IRQF_SHAREDflag. This works since the interrupt handler already checks if there is an actual IRQ pending and returnsIRQ_NONEotherwise.Quoted 6 lines
Quoted 1 line
hmmm what are we trying to fix here? Is your device on a shared line or not?
IRQF_SHAREDdoes not mean that the IRQ is on a shared line. It means that the driver can handle it if the IRQ is on a shared line. Since the driver can handle it setting the flag is a good idea since this enables usecases where the line is shared.Yes that is correct indeed, but what is the motivation for the change.
Quoted 7 lines
Quoted 3 lines
If you never expect this to be in shared environment why to do this? Sorry but "it works" is not a good enough reason for this change, to enable usecases where the line is shared is a good reason :)
Remember, this is an FPGA soft core. I happen to have a design [1] where it is hooked up with multiple of them on one IRQ line, so to make this work, I need this change.
I think what Vinod is asking for is a change to the commit message saying that "this change enables the driver to be used with devices where the interrupt line is shared".
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 24 lines · Lars-Peter Clausen
Quoted 23 lines · Moritz Fischer
Hi Vinod,
Quoted 19 lines · Vinod Koul
Quoted 6 lines · Lars-Peter Clausen
Quoted 5 lines · Vinod Koul
Quoted 3 lines · Moritz Fischer
Request IRQ with
IRQF_SHAREDflag. This works since the interrupt handler already checks if there is an actual IRQ pending and returnsIRQ_NONEotherwise.Quoted 6 lines
Quoted 1 line
hmmm what are we trying to fix here? Is your device on a shared line or not?
IRQF_SHAREDdoes not mean that the IRQ is on a shared line. It means that the driver can handle it if the IRQ is on a shared line. Since the driver can handle it setting the flag is a good idea since this enables usecases where the line is shared.Yes that is correct indeed, but what is the motivation for the change.
If you never expect this to be in shared environment why to do this? Sorry but "it works" is not a good enough reason for this change, to enable usecases where the line is shared is a good reason :)
Quoted 7 lines
Quoted 3 lines
Remember, this is an FPGA soft core. I happen to have a design [1] where it is hooked up with multiple of them on one IRQ line, so to make this work, I need this change.
I think what Vinod is asking for is a change to the commit message saying that "this change enables the driver to be used with devices where the interrupt line is shared".
Correct, changelog need to reflect why a change was made, down the line people need to know the reasons, sometimes it might be even you..
Signature · 1 line
~Vinod
Quoted 29 lines · Vinod Koul
Quoted 28 lines · Lars-Peter Clausen
Quoted 26 lines · Moritz Fischer
Hi Vinod,
Quoted 14 lines · Vinod Koul
Quoted 6 lines · Lars-Peter Clausen
Quoted 5 lines · Vinod Koul
Quoted 3 lines · Moritz Fischer
Request IRQ with
IRQF_SHAREDflag. This works since the interrupt handler already checks if there is an actual IRQ pending and returnsIRQ_NONEotherwise.Quoted 6 lines
Quoted 1 line
hmmm what are we trying to fix here? Is your device on a shared line or not?
IRQF_SHAREDdoes not mean that the IRQ is on a shared line. It means that the driver can handle it if the IRQ is on a shared line. Since the driver can handle it setting the flag is a good idea since this enables usecases where the line is shared.Quoted 5 lines
Yes that is correct indeed, but what is the motivation for the change.
If you never expect this to be in shared environment why to do this? Sorry but "it works" is not a good enough reason for this change, to enable usecases where the line is shared is a good reason :)
Remember, this is an FPGA soft core. I happen to have a design [1] where it is hooked up with multiple of them on one IRQ line, so to make this work, I need this change.
Quoted 6 lines
Quoted 3 lines
I think what Vinod is asking for is a change to the commit message saying that "this change enables the driver to be used with devices where the interrupt line is shared".
Correct, changelog need to reflect why a change was made, down the line people need to know the reasons, sometimes it might be even you..
Ok, communication is hard :) Will resubmit with fixed commit message,
Thanks for your feedback,
Moritz
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html