xen/kbdif: Add features to control keyboard and pointer
PATCH v2 1/1 xen/kbdif: Add features to control keyboard and pointer
From: Oleksandr Andrushchenko <[email protected]>
It is now not fully possible to control if and which virtual devices are created by the frontend, e.g. keyboard and pointer devices are always created and multi-touch device is created if the backend advertises multi-touch support. In some cases this behavior is not desirable and better control over the frontend's configuration is required.
Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-keyboard to 0 if no keyboard device needs to be created
- set feature-pointer to 0 if no pointer device needs to be created
Keep old behavior by default.
--- xen/include/public/io/kbdif.h | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)
xen/include/public/io/kbdif.h +18 -1
@@ -49,7 +49,22 @@* * Capable backend advertises supported features by publishing * corresponding entries in XenStore and puts 1 as the value of the entry. -* If a feature is not supported then 0 must be set or feature entry omitted. +* If not otherwise noted if a feature is not supported then 0 must be set +* or feature entry omitted. +* +* feature-keyboard +* Values: <uint> +* +* If no virtual keyboard device to be exposed by the frontend then +* this must be set to 0. If feature entry omitted or not set its +* value defaults to 1. +* +* feature-pointer +* Values: <uint> +* +* If no virtual pointer device to be exposed by the frontend then +* this must be set to 0. If feature entry omitted or not set its +* value defaults to 1. * * feature-abs-pointer * Values: <uint>
@@ -177,6 +192,8 @@#define XENKBD_DRIVER_NAME "vkbd" +#define XENKBD_FIELD_FEAT_KEYBOARD "feature-keyboard" +#define XENKBD_FIELD_FEAT_POINTER "feature-pointer"#define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer"#define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch"#define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer"
Signature · 7 lines
2.17.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 5 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
It is now not fully possible to control if and which virtual devices are created by the frontend, e.g. keyboard and pointer devices are always created and multi-touch device is created if the
s/is/are/
Quoted 1 line
backend advertises multi-touch support. In some cases this
Can you mention under which backend node those devices appear?
Quoted 8 lines
behavior is not desirable and better control over the frontend's configuration is required.
Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-keyboard to 0 if no keyboard device needs to be created
- set feature-pointer to 0 if no pointer device needs to be created
I am thinking that this should be just called 'feature-disable-keyboard' or such. And it being there in the first place would signify '1' by default?
Quoted 13 lines
Keep old behavior by default.
Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/kbdif.h | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)xen/include/public/io/kbdif.h +0
-0
xen/include/public/io/kbdif.h line 53
Quoted 6 lines
xen/include/public/io/kbdif.h +2
-1@@ -49,7 +49,22 @@* * Capable backend advertises supported features by publishing * corresponding entries in XenStore and puts 1 as the value of the entry. -* If a feature is not supported then 0 must be set or feature entry omitted. +* If not otherwise noted if a feature is not supported then 0 must be set +* or feature entry omitted.
Huh? I am not sure what you are saying there.
xen/include/public/io/kbdif.h line 60
Quoted 7 lines
xen/include/public/io/kbdif.h +7
-0+* +* feature-keyboard +* Values: <uint> +* +* If no virtual keyboard device to be exposed by the frontend then +* this must be set to 0. If feature entry omitted or not set its +* value defaults to 1.
Are you saying:
"If there is no need to expose a virtual keyboard device then this must be set to 0. By default it is 1 and it is assumed that any frontend that does not probe this flag will assume the value of 1. "?
xen/include/public/io/kbdif.h line 67
Quoted 7 lines
xen/include/public/io/kbdif.h +7
-0+* +* feature-pointer +* Values: <uint> +* +* If no virtual pointer device to be exposed by the frontend then +* this must be set to 0. If feature entry omitted or not set its +* value defaults to 1.
Ditto?
xen/include/public/io/kbdif.h line 196
Quoted 9 lines
xen/include/public/io/kbdif.h +2
-0* * feature-abs-pointer * Values: <uint> @@ -177,6 +192,8 @@#define XENKBD_DRIVER_NAME "vkbd" +#define XENKBD_FIELD_FEAT_KEYBOARD "feature-keyboard" +#define XENKBD_FIELD_FEAT_POINTER "feature-pointer"
How about just call it '
feature-disable-keyboard
feature-disable-keyboard
Quoted 6 lines
xen/include/public/io/kbdif.h +0
-0#define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer"#define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch"#define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer"Signature · 1 line
2.17.0
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 7 lines · Konrad Rzeszutek Wilk
Quoted 5 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
It is now not fully possible to control if and which virtual devices are created by the frontend, e.g. keyboard and pointer devices are always created and multi-touch device is created if the
s/is/are/
why? "and multi-touch *device is* created"
Quoted 2 lines
Quoted 1 line
backend advertises multi-touch support. In some cases this
Can you mention under which backend node those devices appear?
These are created under frontend nodes as these are to configure individual frontends
Quoted 8 lines
Quoted 6 lines
behavior is not desirable and better control over the frontend's configuration is required.
Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-keyboard to 0 if no keyboard device needs to be created
- set feature-pointer to 0 if no pointer device needs to be createdI am thinking that this should be just called 'feature-disable-keyboard' or such. And it being there in the first place would signify '1' by default?
I just tried to be aligned with multi-touch which is "feature-multi-touch". But if you are ok with "feature-disable-keyboard/pointer" then I can re-work it this way.
Quoted 26 lines
Quoted 12 lines
Keep old behavior by default.
Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/kbdif.h | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)xen/include/public/io/kbdif.h +0
-0xen/include/public/io/kbdif.h line 53
Quoted 6 lines
xen/include/public/io/kbdif.h +2
-1@@ -49,7 +49,22 @@* * Capable backend advertises supported features by publishing * corresponding entries in XenStore and puts 1 as the value of the entry. -* If a feature is not supported then 0 must be set or feature entry omitted. +* If not otherwise noted if a feature is not supported then 0 must be set +* or feature entry omitted. Huh? I am not sure what you are saying there.
xen/include/public/io/kbdif.h line 60
Quoted 7 lines
xen/include/public/io/kbdif.h +7
-0+* +* feature-keyboard +* Values: <uint> +* +* If no virtual keyboard device to be exposed by the frontend then +* this must be set to 0. If feature entry omitted or not set its +* value defaults to 1.
Quoted 4 lines
Are you saying:
"If there is no need to expose a virtual keyboard device then this must be set to 0. By default it is 1 and it is assumed that any frontend that does not probe this flag will assume the value of 1. "?
yeap ;)
Quoted 13 lines
xen/include/public/io/kbdif.h line 67
Quoted 7 lines
xen/include/public/io/kbdif.h +7
-0+* +* feature-pointer +* Values: <uint> +* +* If no virtual pointer device to be exposed by the frontend then +* this must be set to 0. If feature entry omitted or not set its +* value defaults to 1. Ditto?
Quoted 5 lines
xen/include/public/io/kbdif.h +0
-0* * feature-abs-pointer * Values: <uint> @@ -177,6 +192,8 @@
Quoted 8 lines
xen/include/public/io/kbdif.h line 196
Quoted 4 lines
xen/include/public/io/kbdif.h +2
-0#define XENKBD_DRIVER_NAME "vkbd" +#define XENKBD_FIELD_FEAT_KEYBOARD "feature-keyboard" +#define XENKBD_FIELD_FEAT_POINTER "feature-pointer"How about just call it '
feature-disable-keyboard
feature-disable-keyboard
See above, I'm fine with that. If we agree on "disable" semantics I will re-work the patch.
Quoted 6 lines
Quoted 6 lines
xen/include/public/io/kbdif.h +0
-0#define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer"#define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch"#define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer"Signature · 1 line
2.17.0
Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 20 lines · Oleksandr Andrushchenko
Quoted 7 lines · Konrad Rzeszutek Wilk
Quoted 5 lines · Oleksandr Andrushchenko
From: Oleksandr Andrushchenko <[email protected]>
It is now not fully possible to control if and which virtual devices are created by the frontend, e.g. keyboard and pointer devices are always created and multi-touch device is created if the
s/is/are/
why? "and multi-touch *device is* created"
Quoted 2 lines
Quoted 1 line
backend advertises multi-touch support. In some cases this
Can you mention under which backend node those devices appear?
These are created under frontend nodes as these are to configure individual frontends
Quoted 6 lines
Quoted 6 lines
behavior is not desirable and better control over the frontend's configuration is required.
Add new XenStore feature fields, so it is possible to individually control set of exposed virtual devices for each guest OS:
- set feature-keyboard to 0 if no keyboard device needs to be created
- set feature-pointer to 0 if no pointer device needs to be created
Quoted 6 lines
Quoted 2 lines
I am thinking that this should be just called 'feature-disable-keyboard' or such. And it being there in the first place would signify '1' by default?
I just tried to be aligned with multi-touch which is "feature-multi-touch". But if you are ok with "feature-disable-keyboard/pointer" then I can re-work it this way.
I think disable works nicer - that way you know for sure what the purpose is and there is no confusion about the other features.
And the absence of it by default implies you are OK having it be used.
Quoted 52 lines
Quoted 26 lines
Quoted 12 lines
Keep old behavior by default.
Signed-off-by Oleksandr Andrushchenko <[email protected]>--- xen/include/public/io/kbdif.h | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)xen/include/public/io/kbdif.h +0
-0xen/include/public/io/kbdif.h line 53
Quoted 6 lines
xen/include/public/io/kbdif.h +2
-1@@ -49,7 +49,22 @@* * Capable backend advertises supported features by publishing * corresponding entries in XenStore and puts 1 as the value of the entry. -* If a feature is not supported then 0 must be set or feature entry omitted. +* If not otherwise noted if a feature is not supported then 0 must be set +* or feature entry omitted. Huh? I am not sure what you are saying there.
xen/include/public/io/kbdif.h line 60
Quoted 7 lines
xen/include/public/io/kbdif.h +7
-0+* +* feature-keyboard +* Values: <uint> +* +* If no virtual keyboard device to be exposed by the frontend then +* this must be set to 0. If feature entry omitted or not set its +* value defaults to 1. Quoted 4 lines
Are you saying:
"If there is no need to expose a virtual keyboard device then this must be set to 0. By default it is 1 and it is assumed that any frontend that does not probe this flag will assume the value of 1. "?yeap ;)
Quoted 17 lines
xen/include/public/io/kbdif.h line 67
Quoted 7 lines
xen/include/public/io/kbdif.h +7
-0+* +* feature-pointer +* Values: <uint> +* +* If no virtual pointer device to be exposed by the frontend then +* this must be set to 0. If feature entry omitted or not set its +* value defaults to 1. Ditto?
xen/include/public/io/kbdif.h line 194
Quoted 7 lines
xen/include/public/io/kbdif.h +2
-0* * feature-abs-pointer * Values: <uint> @@ -177,6 +192,8 @@#define XENKBD_DRIVER_NAME "vkbd" +#define XENKBD_FIELD_FEAT_KEYBOARD "feature-keyboard" +#define XENKBD_FIELD_FEAT_POINTER "feature-pointer"How about just call it '
Quoted 2 lines
feature-disable-keyboard
feature-disable-keyboardSee above, I'm fine with that. If we agree on "disable" semantics I will re-work the patch.
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
xen/include/public/io/kbdif.h +0
-0#define XENKBD_FIELD_FEAT_ABS_POINTER "feature-abs-pointer"#define XENKBD_FIELD_FEAT_MTOUCH "feature-multi-touch"#define XENKBD_FIELD_REQ_ABS_POINTER "request-abs-pointer"Signature · 1 line
2.17.0Thank you,
Oleksandr
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel