soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
Subsystems (2)
PATCH 1/1 soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
Add a prompt to the "tristate" attribute in the Kconfig file in which QCOM_QMI_HELPERS is defined; I find it doesn't get selected without it.
--- drivers/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/qcom/Kconfig +1 -1
@@ -36,7 +36,7 @@ config QCOM_PM low power modes. config QCOM_QMI_HELPERS - tristate + tristate "Qualcomm QMI Helpers" depends on ARCH_QCOM && NET help Helper library for handling QMI encoded messages. QMI encoded
Signature · 1 line
2.14.1
Was there something wrong with this patch? I sent it a long time ago but it still applies cleanly. I can re-send if you like.
-Alex
Quoted 23 lines · Alex Elder
Add a prompt to the "tristate" attribute in the
Kconfigfile in whichQCOM_QMI_HELPERSis defined; I find it doesn't get selected without it.Signed-off-by Alex Elder <[email protected]>--- drivers/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/qcom/Kconfig +1
-1@@ -36,7 +36,7 @@ config QCOM_PM low power modes. config QCOM_QMI_HELPERS - tristate + tristate "Qualcomm QMI Helpers" depends on ARCH_QCOM && NET help Helper library for handling QMI encoded messages. QMI encoded
Quoted 2 lines · Alex Elder
Was there something wrong with this patch? I sent it a long time ago but it still applies cleanly. I can re-send if you like.
Hello Alex,
This patch does not apply on top of
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next
When you don't specify a string for a Kconfig, then you won't be able to select it via menuconfig, only through other Kconfigs, e.g.:
$ git grep QCOM_QMI_HELPERS drivers/remoteproc/Kconfig: select QCOM_QMI_HELPERS
What Kconfig is it that needs QCOM_QMI_HELPERS?
Why do you need to make is selectable via menuconfig?
Isn't it sufficient to add a "select QCOM_QMI_HELPERS" to that Kconfig?
Kind regards,
Niklas
Quoted 28 lines
-Alex
Quoted 23 lines · Alex Elder
Add a prompt to the "tristate" attribute in the
Kconfigfile in whichQCOM_QMI_HELPERSis defined; I find it doesn't get selected without it.Signed-off-by Alex Elder <[email protected]>--- drivers/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/qcom/Kconfig +1
-1@@ -36,7 +36,7 @@ config QCOM_PM low power modes. config QCOM_QMI_HELPERS - tristate + tristate "Qualcomm QMI Helpers" depends on ARCH_QCOM && NET help Helper library for handling QMI encoded messages. QMI encoded
Quoted 8 lines · Niklas Cassel
Quoted 2 lines · Alex Elder
Was there something wrong with this patch? I sent it a long time ago but it still applies cleanly. I can re-send if you like.
Hello Alex,
This patch does not apply on top of
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-next
Sorry, I sent this before I tracked down where Andy's for-next tree was. It applied OK to linus/master.
Quoted 6 lines
When you don't specify a string for a
Kconfig, then you won't be able to select it via menuconfig, only through other Kconfigs, e.g.:$ git grep QCOM_QMI_HELPERS drivers/remoteproc/Kconfig: select QCOM_QMI_HELPERSWhat
Kconfigis it that needsQCOM_QMI_HELPERS?
IPA, which is not yet merged.
The entry in "drivers/soc/qcom/Kconfig" for this option includes help text, so I presume it was an oversight not to include a string (prompt). It is the only non-trivial entry in that file that does not include one. Why should this entry not be listed in menus?
Quoted 2 lines
Why do you need to make is selectable via menuconfig?
Isn't it sufficient to add a "selectQCOM_QMI_HELPERS" to thatKconfig?
I have CONFIG_IPA dependent on CONFIG_QCOM_QMI_HELPERS. I could change that to select it instead but I still think this entry should be changed.
I'll mention that SLIM_QCOM_NGD_CTRL in drivers/slimbus/Kconfig also depends on--rather than selects--QCOM_QMI_HELPERS.
-Alex
Quoted 32 lines
Kind regards,
NiklasQuoted 28 lines
-Alex
Quoted 23 lines · Alex Elder
Add a prompt to the "tristate" attribute in the
Kconfigfile in whichQCOM_QMI_HELPERSis defined; I find it doesn't get selected without it.Signed-off-by Alex Elder <[email protected]>--- drivers/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/qcom/Kconfig +1
-1@@ -36,7 +36,7 @@ config QCOM_PM low power modes. config QCOM_QMI_HELPERS - tristate + tristate "Qualcomm QMI Helpers" depends on ARCH_QCOM && NET help Helper library for handling QMI encoded messages. QMI encoded
Quoted 20 lines · Alex Elder
Quoted 8 lines · Niklas Cassel
Quoted 2 lines · Alex Elder
Was there something wrong with this patch? I sent it a long time ago but it still applies cleanly. I can re-send if you like.
Hello Alex,
This patch does not apply on top of
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-nextSorry, I sent this before I tracked down where Andy's for-next tree was. It applied OK to linus/master.
Quoted 6 lines
When you don't specify a string for a
Kconfig, then you won't be able to select it via menuconfig, only through other Kconfigs, e.g.:$ git grep QCOM_QMI_HELPERS drivers/remoteproc/Kconfig: select QCOM_QMI_HELPERSWhat
Kconfigis it that needsQCOM_QMI_HELPERS?
Quoted 7 lines
IPA, which is not yet merged.
The entry in "
drivers/soc/qcom/Kconfig" for this option includes help text, so I presume it was an oversight not to include a string (prompt). It is the only non-trivial entry in that file that does not include one. Why should this entry not be listed in menus?
I see. Indeed it is a bit confusing that it has a help text.
Quoted 10 lines
Quoted 3 lines
Why do you need to make is selectable via menuconfig?
Isn't it sufficient to add a "selectQCOM_QMI_HELPERS" to thatKconfig?I have
CONFIG_IPAdependent onCONFIG_QCOM_QMI_HELPERS. I could change that to select it instead but I still think this entry should be changed.I'll mention that
SLIM_QCOM_NGD_CTRLindrivers/slimbus/Kconfigalso depends on--rather than selects--QCOM_QMI_HELPERS.
I would have expected SLIM_QCOM_NGD_CTRL to select rather than depend. But then it is also weird that QCOM_QMI_HELPERS has a help text.
I guess Bjorn should answer how this Kconfig was intended to be used, because right now it is kind of ambiguous.
Kind regards,
Niklas
Quoted 36 lines
-Alex
Quoted 32 lines
Kind regards,
NiklasQuoted 28 lines
-Alex
Quoted 23 lines · Alex Elder
Add a prompt to the "tristate" attribute in the
Kconfigfile in whichQCOM_QMI_HELPERSis defined; I find it doesn't get selected without it.Signed-off-by Alex Elder <[email protected]>--- drivers/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/qcom/Kconfig +1
-1@@ -36,7 +36,7 @@ config QCOM_PM low power modes. config QCOM_QMI_HELPERS - tristate + tristate "Qualcomm QMI Helpers" depends on ARCH_QCOM && NET help Helper library for handling QMI encoded messages. QMI encoded
Quoted 20 lines · Alex Elder
Quoted 8 lines · Niklas Cassel
Quoted 2 lines · Alex Elder
Was there something wrong with this patch? I sent it a long time ago but it still applies cleanly. I can re-send if you like.
Hello Alex,
This patch does not apply on top of
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=for-nextSorry, I sent this before I tracked down where Andy's for-next tree was. It applied OK to linus/master.
Quoted 6 lines
When you don't specify a string for a
Kconfig, then you won't be able to select it via menuconfig, only through other Kconfigs, e.g.:$ git grep QCOM_QMI_HELPERS drivers/remoteproc/Kconfig: select QCOM_QMI_HELPERSWhat
Kconfigis it that needsQCOM_QMI_HELPERS?
Quoted 9 lines
IPA, which is not yet merged.
The entry in "
drivers/soc/qcom/Kconfig" for this option includes help text, so I presume it was an oversight not to include a string (prompt). It is the only non-trivial entry in that file that does not include one. Why should this entry not be listed in menus?Quoted 1 line
Why do you need to make is selectable via menuconfig?
I made it this way because I don't see a reason for anyone to ever select this config option if there isn't a client available - and clients that "depends on" this simply forces the developer to find the QMI helpers in menuconfig and enable it manually.
Quoted 6 lines
Quoted 1 line
Isn't it sufficient to add a "select
QCOM_QMI_HELPERS" to thatKconfig?I have
CONFIG_IPAdependent onCONFIG_QCOM_QMI_HELPERS. I could change that to select it instead but I still think this entry should be changed.
Why do you say it needs to change? I tested this by just adding a "select QCOM_QMI_HELPERS" in my client drivers.
Quoted 3 lines
I'll mention that
SLIM_QCOM_NGD_CTRLindrivers/slimbus/Kconfigalso depends on--rather than selects--QCOM_QMI_HELPERS.
That's wrong.
Regards,
Bjorn
Quoted 35 lines
-Alex
Quoted 32 lines
Kind regards,
NiklasQuoted 28 lines
-Alex
Quoted 23 lines · Alex Elder
Add a prompt to the "tristate" attribute in the
Kconfigfile in whichQCOM_QMI_HELPERSis defined; I find it doesn't get selected without it.Signed-off-by Alex Elder <[email protected]>--- drivers/soc/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/qcom/Kconfig +1
-1@@ -36,7 +36,7 @@ config QCOM_PM low power modes. config QCOM_QMI_HELPERS - tristate + tristate "Qualcomm QMI Helpers" depends on ARCH_QCOM && NET help Helper library for handling QMI encoded messages. QMI encoded
Quoted 3 lines · Bjorn Andersson
Quoted 3 lines
I have
CONFIG_IPAdependent onCONFIG_QCOM_QMI_HELPERS. I could change that to select it instead but I still think this entry should be changed.
I was thinking one of two changes:
- Add the prompt string (which I suggested)
- Don't add the prompt, but remove the help and/or add a comment to indicate that the lack of prompt is intentional (because it really looked like an oversight to me)
I don't really care though; I'll change my code to select it rather than depend on it.
Quoted 7 lines
Why do you say it needs to change? I tested this by just adding a "select
QCOM_QMI_HELPERS" in my client drivers.Quoted 3 lines
I'll mention that
SLIM_QCOM_NGD_CTRLindrivers/slimbus/Kconfigalso depends on--rather than selects--QCOM_QMI_HELPERS.That's wrong.
Maybe someone else should fix this, but I can do it if you like (and if that's the case, say so).
-Alex