fix coverity bugs

Hi all.

Here are two bug fixes, thanks to Peter for reporting.

Both are introduced in 2.12.

Vladimir Sementsov-Ogievskiy (2):
nbd/client: fix nbd_negotiate_simple_meta_context migration/block-dirty-bitmap: fix memory leak in
dirty_bitmap_load_bits

 migration/block-dirty-bitmap.c | 1 +
 nbd/client.c                   | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

2.11.1

Initialize received variable. Otherwise, is is possible for server to answer without any contexts, but we will set context_id to something random (received_id is not initialized too) and return 1, which is wrong.

To solve it, just initialize received to false. Initialize received_id too, just to make all possible checkers happy.

But was introduced in 78a33ab58782efdb206de14 "nbd: BLOCK_STATUS for standard get_block_status function: client part" with the whole function.

---
 nbd/client.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

index b9e175d1c2..7f35b5c323 100644
@@ -613,8 +613,8 @@ static int nbd_negotiate_simple_meta_context(QIOChannel *ioc,
 {
     int ret;
     NBDOptionReply reply;
-    uint32_t received_id;
-    bool received;
+    uint32_t received_id = 0;
+    bool received = false;
     uint32_t export_len = strlen(export);
     uint32_t context_len = strlen(context);
     uint32_t data_len = sizeof(export_len) + export_len +

2.11.1

s/But/Bug/

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Release buf on error path too.

Bug was introduced in b35ebdf076d697bc "migration: add postcopy migration of dirty bitmaps" with the whole function.

---
 migration/block-dirty-bitmap.c | 1 +
 1 file changed, 1 insertion(+)

index dd04f102d8..8819aabe3a 100644
@@ -600,6 +600,7 @@ static int dirty_bitmap_load_bits(QEMUFile *f, DirtyBitmapLoadState *s)
         ret = qemu_get_buffer(f, buf, buf_size);
         if (ret != buf_size) {
             error_report("Failed to read bitmap bits");
+            g_free(buf);
             return -EIO;
         }
 

2.11.1

Adding both to my NBD queue

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org