ARM: Remove support for Exynos5440
Subsystems (21)
Krzysztof Kozlowski
maintainercover ARM: Remove support for Exynos5440
Hi,
Overview
========
Let's continue the removal of old platforms. We already get rid of Exynos4212. Now it's time for Exynos5440.
The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting server platforms but it did not make it to the market really. There are no development boards with it and probably there are no real products neither. The development for Exynos5440 ended in 2013 and since then the platform is in maintenance mode.
The only development happening around it is the PCIe driver for Exynos5433 (ARMv8). [1]
Removing Exynos5440, makes our life slightly easier:
1. Less maintenance,
2. Smaller code, less quirks,
3. No need to preserve (imaginary) backward-compatibility for Exynos PCIe driver (so it is easier to add support for Exynos5433).
Because of point (3) above - I left the PCIe and PCIe PHY drivers intact.
Dependencies
============
I think about starting with removal of DTS in some kernel release (patch 1/10). Then all drivers can be removed/updated - subsystem maintainers can pick their patches freely.
Finally, after getting rid of all Exynos5440 symbols, the last patch (10/10) will end in arm-soc tree.
Any comments?
Best regards,
Krzysztof
[1] https://www.mail-archive.com/linux-kernel at vger.kernel.org/msg1569919.html
Krzysztof Kozlowski (10):
ARM: dts: exynos: Remove Exynos5440
ata: ahci-platform: Remove support for Exynos5440
cpufreq: exynos: Remove support for Exynos5440
clk: samsung: Remove support for Exynos5440
i2c: s3c2410: Remove support for Exynos5440
thermal: samsung: Remove support for Exynos5440
pinctrl: samsung: Remove support for Exynos5440
spi: s3c64xx: samsung: Remove support for Exynos5440
usb: host: exynos: Remove support for Exynos5440
ARM: exynos: Remove support for Exynos5440
.../bindings/arm/samsung/samsung-boards.txt | 2 - .../devicetree/bindings/ata/ahci-platform.txt | 1 - .../devicetree/bindings/clock/exynos5440-clock.txt | 28 - .../bindings/cpufreq/cpufreq-exynos5440.txt | 28 - .../devicetree/bindings/i2c/i2c-s3c2410.txt | 4 +- .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- arch/arm/boot/dts/Makefile | 2 - arch/arm/boot/dts/exynos5440-sd5v1.dts | 42 - arch/arm/boot/dts/exynos5440-ssdk5440.dts | 81 -- arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi | 20 - arch/arm/boot/dts/exynos5440-trip-points.dtsi | 21 - arch/arm/boot/dts/exynos5440.dtsi | 355 ------- arch/arm/mach-exynos/Kconfig | 12 - arch/arm/mach-exynos/common.h | 8 - arch/arm/mach-exynos/exynos.c | 15 +- drivers/ata/ahci_platform.c | 1 - drivers/clk/samsung/Makefile | 1 - drivers/clk/samsung/clk-exynos5440.c | 167 ---- drivers/cpufreq/Kconfig.arm | 14 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/exynos5440-cpufreq.c | 452 --------- drivers/i2c/busses/i2c-s3c2410.c | 2 - drivers/pinctrl/samsung/Kconfig | 10 +- drivers/pinctrl/samsung/Makefile | 1 - drivers/pinctrl/samsung/pinctrl-exynos5440.c | 1005 -------------------- drivers/spi/spi-s3c64xx.c | 12 - drivers/thermal/samsung/exynos_tmu.c | 155 +-- drivers/thermal/samsung/exynos_tmu.h | 1 - drivers/usb/host/ehci-exynos.c | 7 - drivers/usb/host/ohci-exynos.c | 6 - include/dt-bindings/clock/exynos5440.h | 44 - 31 files changed, 9 insertions(+), 2503 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/exynos5440-clock.txt delete mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-exynos5440.txt delete mode 100644 arch/arm/boot/dts/exynos5440-sd5v1.dts delete mode 100644 arch/arm/boot/dts/exynos5440-ssdk5440.dts delete mode 100644 arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440-trip-points.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440.dtsi delete mode 100644 drivers/clk/samsung/clk-exynos5440.c delete mode 100644 drivers/cpufreq/exynos5440-cpufreq.c delete mode 100644 drivers/pinctrl/samsung/pinctrl-exynos5440.c delete mode 100644 include/dt-bindings/clock/exynos5440.h
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 1/10 ARM: dts: exynos: Remove Exynos5440
The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting server platforms but it did not make it to the market really. There are no development boards with it and probably there are no real products neither. The development for Exynos5440 ended in 2013 and since then the platform is in maintenance mode.
Remove all Device Tree sources for Exynos5440, as first step of removal of the platform to simplify the code and drivers.
--- .../bindings/arm/samsung/samsung-boards.txt | 2 - arch/arm/boot/dts/Makefile | 2 - arch/arm/boot/dts/exynos5440-sd5v1.dts | 42 --- arch/arm/boot/dts/exynos5440-ssdk5440.dts | 81 ----- arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi | 20 -- arch/arm/boot/dts/exynos5440-trip-points.dtsi | 21 -- arch/arm/boot/dts/exynos5440.dtsi | 355 --------------------- 7 files changed, 523 deletions(-) delete mode 100644 arch/arm/boot/dts/exynos5440-sd5v1.dts delete mode 100644 arch/arm/boot/dts/exynos5440-ssdk5440.dts delete mode 100644 arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440-trip-points.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440.dtsi
Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +0 -2
@@ -21,8 +21,6 @@ Required root node properties: - "samsung,smdk5420" - for Exynos5420-based Samsung SMDK5420 eval board. - "samsung,tm2" - for Exynos5433-based Samsung TM2 board. - "samsung,tm2e" - for Exynos5433-based Samsung TM2E board. - - "samsung,sd5v1" - for Exynos5440-based Samsung board. - - "samsung,ssdk5440" - for Exynos5440-based Samsung board. * Other companies Exynos SoC based * FriendlyARM
arch/arm/boot/dts/Makefile +0 -2
@@ -191,8 +191,6 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \ exynos5422-odroidxu3.dtb \ exynos5422-odroidxu3-lite.dtb \ exynos5422-odroidxu4.dtb \ - exynos5440-sd5v1.dtb \ - exynos5440-ssdk5440.dtb \ exynos5800-peach-pi.dtb dtb-$(CONFIG_ARCH_GEMINI) += \ gemini-dlink-dir-685.dtb \
arch/arm/boot/dts/exynos5440-sd5v1.dts deleted +0 -42
42 lines not on this page · raw message
arch/arm/boot/dts/exynos5440-ssdk5440.dts deleted +0 -81
81 lines not on this page · raw message
arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi deleted +0 -20
@@ -1,20 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Device tree sources for Exynos5440 TMU sensor configuration - * - * Copyright (c) 2014 Lukasz Majewski <[email protected]> - */ - -#include <dt-bindings/thermal/thermal_exynos.h> - -#thermal-sensor-cells = <0>; -samsung,tmu_gain = <5>; -samsung,tmu_reference_voltage = <16>; -samsung,tmu_noise_cancel_mode = <4>; -samsung,tmu_efuse_value = <0x5d2d>; -samsung,tmu_min_efuse_value = <16>; -samsung,tmu_max_efuse_value = <76>; -samsung,tmu_first_point_trim = <25>; -samsung,tmu_second_point_trim = <70>; -samsung,tmu_default_temp_offset = <25>; -samsung,tmu_cal_type = <TYPE_ONE_POINT_TRIMMING>;
arch/arm/boot/dts/exynos5440-trip-points.dtsi deleted +0 -21
@@ -1,21 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Device tree sources for default Exynos5440 thermal zone definition - * - * Copyright (c) 2014 Lukasz Majewski <[email protected]> - */ - -polling-delay-passive = <0>; -polling-delay = <0>; -trips { - cpu-alert-0 { - temperature = <100000>; /* millicelsius */ - hysteresis = <0>; /* millicelsius */ - type = "active"; - }; - cpu-crit-0 { - temperature = <105000>; /* millicelsius */ - hysteresis = <0>; /* millicelsius */ - type = "critical"; - }; -};
arch/arm/boot/dts/exynos5440.dtsi deleted +0 -355
355 lines not on this page · raw message
Signature · 1 line
2.14.1
Re: [RFC 01/10] ARM: dts: exynos: Remove Exynos5440
Hi Krzysztof,
Quoted 11 lines · Krzysztof Kozlowski
The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting server platforms but it did not make it to the market really. There are
no development boards with it and probably there are no real products neither. The development for Exynos5440 ended in 2013 and since then the platform is in maintenance mode.Remove all Device Tree sources for Exynos5440, as first step of removal of the platform to simplify the code and drivers.
Signed-off-by Krzysztof Kozlowski <[email protected]>
makes sense, please feel free to add:
Thanks,
Andi
Re: [RFC 01/10] ARM: dts: exynos: Remove Exynos5440
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting server platforms but it did not make it to the market really. There are no development boards with it and probably there are no real products neither. The development for Exynos5440 ended in 2013 and since then the platform is in maintenance mode.
Remove all Device Tree sources for Exynos5440, as first step of removal of the platform to simplify the code and drivers.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 14 lines
--- .../bindings/arm/samsung/samsung-boards.txt | 2 - arch/arm/boot/dts/Makefile | 2 - arch/arm/boot/dts/exynos5440-sd5v1.dts | 42 --- arch/arm/boot/dts/exynos5440-ssdk5440.dts | 81 ----- arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi | 20 -- arch/arm/boot/dts/exynos5440-trip-points.dtsi | 21 -- arch/arm/boot/dts/exynos5440.dtsi | 355 --------------------- 7 files changed, 523 deletions(-) delete mode 100644 arch/arm/boot/dts/exynos5440-sd5v1.dts delete mode 100644 arch/arm/boot/dts/exynos5440-ssdk5440.dts delete mode 100644 arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440-trip-points.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440.dtsi
Re: [RFC 01/10] ARM: dts: exynos: Remove Exynos5440
In reply to Krzysztof KozlowskiQuoted 10 lines · Krzysztof Kozlowski
The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting server platforms but it did not make it to the market really. There are no development boards with it and probably there are no real products neither. The development for Exynos5440 ended in 2013 and since then the platform is in maintenance mode.
Remove all Device Tree sources for Exynos5440, as first step of removal of the platform to simplify the code and drivers.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 15 lines
--- .../bindings/arm/samsung/samsung-boards.txt | 2 - arch/arm/boot/dts/Makefile | 2 - arch/arm/boot/dts/exynos5440-sd5v1.dts | 42 --- arch/arm/boot/dts/exynos5440-ssdk5440.dts | 81 ----- arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi | 20 -- arch/arm/boot/dts/exynos5440-trip-points.dtsi | 21 -- arch/arm/boot/dts/exynos5440.dtsi | 355 --------------------- 7 files changed, 523 deletions(-) delete mode 100644 arch/arm/boot/dts/exynos5440-sd5v1.dts delete mode 100644 arch/arm/boot/dts/exynos5440-ssdk5440.dts delete mode 100644 arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440-trip-points.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440.dtsi
Applied.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerRFC 1/10 ARM: dts: exynos: Remove Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting server platforms but it did not make it to the market really. There are no development boards with it and probably there are no real products neither. The development for Exynos5440 ended in 2013 and since then the platform is in maintenance mode.
Remove all Device Tree sources for Exynos5440, as first step of removal of the platform to simplify the code and drivers.
--- .../bindings/arm/samsung/samsung-boards.txt | 2 - arch/arm/boot/dts/Makefile | 2 - arch/arm/boot/dts/exynos5440-sd5v1.dts | 42 --- arch/arm/boot/dts/exynos5440-ssdk5440.dts | 81 ----- arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi | 20 -- arch/arm/boot/dts/exynos5440-trip-points.dtsi | 21 -- arch/arm/boot/dts/exynos5440.dtsi | 355 --------------------- 7 files changed, 523 deletions(-) delete mode 100644 arch/arm/boot/dts/exynos5440-sd5v1.dts delete mode 100644 arch/arm/boot/dts/exynos5440-ssdk5440.dts delete mode 100644 arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440-trip-points.dtsi delete mode 100644 arch/arm/boot/dts/exynos5440.dtsi
Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +0 -2
@@ -21,8 +21,6 @@ Required root node properties: - "samsung,smdk5420" - for Exynos5420-based Samsung SMDK5420 eval board. - "samsung,tm2" - for Exynos5433-based Samsung TM2 board. - "samsung,tm2e" - for Exynos5433-based Samsung TM2E board. - - "samsung,sd5v1" - for Exynos5440-based Samsung board. - - "samsung,ssdk5440" - for Exynos5440-based Samsung board. * Other companies Exynos SoC based * FriendlyARM
arch/arm/boot/dts/Makefile +0 -2
@@ -191,8 +191,6 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \ exynos5422-odroidxu3.dtb \ exynos5422-odroidxu3-lite.dtb \ exynos5422-odroidxu4.dtb \ - exynos5440-sd5v1.dtb \ - exynos5440-ssdk5440.dtb \ exynos5800-peach-pi.dtb dtb-$(CONFIG_ARCH_GEMINI) += \ gemini-dlink-dir-685.dtb \
arch/arm/boot/dts/exynos5440-sd5v1.dts deleted +0 -42
42 lines not on this page · raw message
arch/arm/boot/dts/exynos5440-ssdk5440.dts deleted +0 -81
81 lines not on this page · raw message
arch/arm/boot/dts/exynos5440-tmu-sensor-conf.dtsi deleted +0 -20
@@ -1,20 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Device tree sources for Exynos5440 TMU sensor configuration - * - * Copyright (c) 2014 Lukasz Majewski <[email protected]> - */ - -#include <dt-bindings/thermal/thermal_exynos.h> - -#thermal-sensor-cells = <0>; -samsung,tmu_gain = <5>; -samsung,tmu_reference_voltage = <16>; -samsung,tmu_noise_cancel_mode = <4>; -samsung,tmu_efuse_value = <0x5d2d>; -samsung,tmu_min_efuse_value = <16>; -samsung,tmu_max_efuse_value = <76>; -samsung,tmu_first_point_trim = <25>; -samsung,tmu_second_point_trim = <70>; -samsung,tmu_default_temp_offset = <25>; -samsung,tmu_cal_type = <TYPE_ONE_POINT_TRIMMING>;
arch/arm/boot/dts/exynos5440-trip-points.dtsi deleted +0 -21
@@ -1,21 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* - * Device tree sources for default Exynos5440 thermal zone definition - * - * Copyright (c) 2014 Lukasz Majewski <[email protected]> - */ - -polling-delay-passive = <0>; -polling-delay = <0>; -trips { - cpu-alert-0 { - temperature = <100000>; /* millicelsius */ - hysteresis = <0>; /* millicelsius */ - type = "active"; - }; - cpu-crit-0 { - temperature = <105000>; /* millicelsius */ - hysteresis = <0>; /* millicelsius */ - type = "critical"; - }; -};
arch/arm/boot/dts/exynos5440.dtsi deleted +0 -355
355 lines not on this page · raw message
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 2/10 ata: ahci-platform: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- Documentation/devicetree/bindings/ata/ahci-platform.txt | 1 - drivers/ata/ahci_platform.c | 1 - 2 files changed, 2 deletions(-)
Documentation/devicetree/bindings/ata/ahci-platform.txt +0 -1
@@ -17,7 +17,6 @@ Required properties: - "marvell,armada-380-ahci" - "marvell,armada-3700-ahci" - "snps,dwc-ahci" - - "snps,exynos5440-ahci" - "snps,spear-ahci" - "generic-ahci" - interrupts : <interrupt mapping for SATA IRQ>
drivers/ata/ahci_platform.c +0 -1
@@ -75,7 +75,6 @@ static const struct of_device_id ahci_of_match[] = { { .compatible = "generic-ahci", }, /* Keep the following compatibles for device tree compatibility */ { .compatible = "snps,spear-ahci", }, - { .compatible = "snps,exynos5440-ahci", }, { .compatible = "ibm,476gtr-ahci", }, { .compatible = "snps,dwc-ahci", }, { .compatible = "hisilicon,hisi-ahci", },
Signature · 1 line
2.14.1
Re: [RFC 02/10] ata: ahci-platform: Remove support for Exynos5440
Quoted 9 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- Documentation/devicetree/bindings/ata/ahci-platform.txt | 1 - drivers/ata/ahci_platform.c | 1 - 2 files changed, 2 deletions(-)
Krzysztof Kozlowski
maintainerRFC 2/10 ata: ahci-platform: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- Documentation/devicetree/bindings/ata/ahci-platform.txt | 1 - drivers/ata/ahci_platform.c | 1 - 2 files changed, 2 deletions(-)
Documentation/devicetree/bindings/ata/ahci-platform.txt +0 -1
@@ -17,7 +17,6 @@ Required properties: - "marvell,armada-380-ahci" - "marvell,armada-3700-ahci" - "snps,dwc-ahci" - - "snps,exynos5440-ahci" - "snps,spear-ahci" - "generic-ahci" - interrupts : <interrupt mapping for SATA IRQ>
drivers/ata/ahci_platform.c +0 -1
@@ -75,7 +75,6 @@ static const struct of_device_id ahci_of_match[] = { { .compatible = "generic-ahci", }, /* Keep the following compatibles for device tree compatibility */ { .compatible = "snps,spear-ahci", }, - { .compatible = "snps,exynos5440-ahci", }, { .compatible = "ibm,476gtr-ahci", }, { .compatible = "snps,dwc-ahci", }, { .compatible = "hisilicon,hisi-ahci", },
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 3/10 cpufreq: exynos: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- .../bindings/cpufreq/cpufreq-exynos5440.txt | 28 -- drivers/cpufreq/Kconfig.arm | 14 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/exynos5440-cpufreq.c | 452 --------------------- 4 files changed, 495 deletions(-) delete mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-exynos5440.txt delete mode 100644 drivers/cpufreq/exynos5440-cpufreq.c
Documentation/devicetree/bindings/cpufreq/cpufreq-exynos5440.txt deleted +0 -28
@@ -1,28 +0,0 @@ - -Exynos5440 cpufreq driver -------------------- - -Exynos5440 SoC cpufreq driver for CPU frequency scaling. - -Required properties: -- interrupts: Interrupt to know the completion of cpu frequency change. -- operating-points: Table of frequencies and voltage CPU could be transitioned into, - in the decreasing order. Frequency should be in KHz units and voltage - should be in microvolts. - -Optional properties: -- clock-latency: Clock monitor latency in microsecond. - -All the required listed above must be defined under node cpufreq. - -Example: --------- - cpufreq at 160000 { - compatible = "samsung,exynos5440-cpufreq"; - reg = <0x160000 0x1000>; - interrupts = <0 57 0>; - operating-points = < - 1000000 975000 - 800000 925000>; - clock-latency = <100000>; - };
drivers/cpufreq/Kconfig.arm +0 -14
@@ -81,20 +81,6 @@ config ARM_BRCMSTB_AVS_CPUFREQ_DEBUG If in doubt, say N. -config ARM_EXYNOS5440_CPUFREQ - tristate "SAMSUNG EXYNOS5440" - depends on SOC_EXYNOS5440 - depends on HAVE_CLK && OF - select PM_OPP - default y - help - This adds the CPUFreq driver for Samsung EXYNOS5440 - SoC. The nature of exynos5440 clock controller is - different than previous exynos controllers so not using - the common exynos framework. - - If in doubt, say N. - config ARM_HIGHBANK_CPUFREQ tristate "Calxeda Highbank-based" depends on ARCH_HIGHBANK && CPUFREQ_DT && REGULATOR
drivers/cpufreq/Makefile +0 -1
@@ -56,7 +56,6 @@ obj-$(CONFIG_ARM_ARMADA_37XX_CPUFREQ) += armada-37xx-cpufreq.o obj-$(CONFIG_ARM_BRCMSTB_AVS_CPUFREQ) += brcmstb-avs-cpufreq.o obj-$(CONFIG_ACPI_CPPC_CPUFREQ) += cppc_cpufreq.o obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o -obj-$(CONFIG_ARM_EXYNOS5440_CPUFREQ) += exynos5440-cpufreq.o obj-$(CONFIG_ARM_HIGHBANK_CPUFREQ) += highbank-cpufreq.o obj-$(CONFIG_ARM_IMX6Q_CPUFREQ) += imx6q-cpufreq.o obj-$(CONFIG_ARM_KIRKWOOD_CPUFREQ) += kirkwood-cpufreq.o
drivers/cpufreq/exynos5440-cpufreq.c deleted +0 -452
452 lines not on this page · raw message
Signature · 1 line
2.14.1
Re: [RFC 03/10] cpufreq: exynos: Remove support for Exynos5440
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 8 lines
--- .../bindings/cpufreq/cpufreq-exynos5440.txt | 28 -- drivers/cpufreq/Kconfig.arm | 14 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/exynos5440-cpufreq.c | 452 --------------------- 4 files changed, 495 deletions(-) delete mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-exynos5440.txt delete mode 100644 drivers/cpufreq/exynos5440-cpufreq.c
Signature · 1 line
viresh
Re: [RFC 03/10] cpufreq: exynos: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 9 lines
--- .../bindings/cpufreq/cpufreq-exynos5440.txt | 28 -- drivers/cpufreq/Kconfig.arm | 14 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/exynos5440-cpufreq.c | 452 --------------------- 4 files changed, 495 deletions(-) delete mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-exynos5440.txt delete mode 100644 drivers/cpufreq/exynos5440-cpufreq.c
[snip]
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Re: [RFC 03/10] cpufreq: exynos: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 9 lines
--- .../bindings/cpufreq/cpufreq-exynos5440.txt | 28 -- drivers/cpufreq/Kconfig.arm | 14 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/exynos5440-cpufreq.c | 452 --------------------- 4 files changed, 495 deletions(-) delete mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-exynos5440.txt delete mode 100644 drivers/cpufreq/exynos5440-cpufreq.c
[snip]
Signature · 8 lines
Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [RFC 03/10] cpufreq: exynos: Remove support for Exynos5440
In reply to Krzysztof KozlowskiQuoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 8 lines
--- .../bindings/cpufreq/cpufreq-exynos5440.txt | 28 -- drivers/cpufreq/Kconfig.arm | 14 - drivers/cpufreq/Makefile | 1 - drivers/cpufreq/exynos5440-cpufreq.c | 452 --------------------- 4 files changed, 495 deletions(-) delete mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-exynos5440.txt delete mode 100644 drivers/cpufreq/exynos5440-cpufreq.c
Krzysztof Kozlowski
maintainerRFC 4/10 clk: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- .../devicetree/bindings/clock/exynos5440-clock.txt | 28 ---- drivers/clk/samsung/Makefile | 1 - drivers/clk/samsung/clk-exynos5440.c | 167 --------------------- include/dt-bindings/clock/exynos5440.h | 44 ------ 4 files changed, 240 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/exynos5440-clock.txt delete mode 100644 drivers/clk/samsung/clk-exynos5440.c delete mode 100644 include/dt-bindings/clock/exynos5440.h
Documentation/devicetree/bindings/clock/exynos5440-clock.txt deleted +0 -28
@@ -1,28 +0,0 @@ -* Samsung Exynos5440 Clock Controller - -The Exynos5440 clock controller generates and supplies clock to various -controllers within the Exynos5440 SoC. - -Required Properties: - -- compatible: should be "samsung,exynos5440-clock". - -- reg: physical base address of the controller and length of memory mapped - region. - -- #clock-cells: should be 1. - -Each clock is assigned an identifier and client nodes can use this identifier -to specify the clock which they consume. - -All available clocks are defined as preprocessor macros in -dt-bindings/clock/exynos5440.h header and can be used in device -tree sources. - -Example: An example of a clock controller node is listed below. - - clock: clock-controller at 10010000 { - compatible = "samsung,exynos5440-clock"; - reg = <0x160000 0x10000>; - #clock-cells = <1>; - };
drivers/clk/samsung/Makefile +0 -1
@@ -14,7 +14,6 @@ obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5-subcmu.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o -obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o
drivers/clk/samsung/clk-exynos5440.c deleted +0 -167
167 lines not on this page · raw message
include/dt-bindings/clock/exynos5440.h deleted +0 -44
44 lines not on this page · raw message
Signature · 1 line
2.14.1
Sylwester Nawrocki
maintainerRe: [RFC 04/10] clk: samsung: Remove support for Exynos5440
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks Krzysztof, patch applied, assuming there is no issues with applying patches from this series individually through the subsystem trees.
Signature · 2 lines
Regards, Sylwester
Re: [RFC 04/10] clk: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 10 lines
--- .../devicetree/bindings/clock/exynos5440-clock.txt | 28 ---- drivers/clk/samsung/Makefile | 1 - drivers/clk/samsung/clk-exynos5440.c | 167 --------------------- include/dt-bindings/clock/exynos5440.h | 44 ------ 4 files changed, 240 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/exynos5440-clock.txt delete mode 100644 drivers/clk/samsung/clk-exynos5440.c delete mode 100644 include/dt-bindings/clock/exynos5440.h
Looks good to me. Thanks.
[snip]
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Re: [RFC 04/10] clk: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Quoted 10 lines
--- .../devicetree/bindings/clock/exynos5440-clock.txt | 28 ---- drivers/clk/samsung/Makefile | 1 - drivers/clk/samsung/clk-exynos5440.c | 167 --------------------- include/dt-bindings/clock/exynos5440.h | 44 ------ 4 files changed, 240 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/exynos5440-clock.txt delete mode 100644 drivers/clk/samsung/clk-exynos5440.c delete mode 100644 include/dt-bindings/clock/exynos5440.h
Looks good to me. Thanks.
[snip]
Signature · 8 lines
Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [RFC 04/10] clk: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiQuoting Krzysztof Kozlowski (2018-04-24 13:32:33)
Quoted 6 lines
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Re: [RFC 04/10] clk: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiQuoting Krzysztof Kozlowski (2018-04-24 13:32:33)
Quoted 6 lines
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>---
Krzysztof Kozlowski
maintainerRFC 4/10 clk: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- .../devicetree/bindings/clock/exynos5440-clock.txt | 28 ---- drivers/clk/samsung/Makefile | 1 - drivers/clk/samsung/clk-exynos5440.c | 167 --------------------- include/dt-bindings/clock/exynos5440.h | 44 ------ 4 files changed, 240 deletions(-) delete mode 100644 Documentation/devicetree/bindings/clock/exynos5440-clock.txt delete mode 100644 drivers/clk/samsung/clk-exynos5440.c delete mode 100644 include/dt-bindings/clock/exynos5440.h
Documentation/devicetree/bindings/clock/exynos5440-clock.txt deleted +0 -28
@@ -1,28 +0,0 @@ -* Samsung Exynos5440 Clock Controller - -The Exynos5440 clock controller generates and supplies clock to various -controllers within the Exynos5440 SoC. - -Required Properties: - -- compatible: should be "samsung,exynos5440-clock". - -- reg: physical base address of the controller and length of memory mapped - region. - -- #clock-cells: should be 1. - -Each clock is assigned an identifier and client nodes can use this identifier -to specify the clock which they consume. - -All available clocks are defined as preprocessor macros in -dt-bindings/clock/exynos5440.h header and can be used in device -tree sources. - -Example: An example of a clock controller node is listed below. - - clock: clock-controller@10010000 { - compatible = "samsung,exynos5440-clock"; - reg = <0x160000 0x10000>; - #clock-cells = <1>; - };
drivers/clk/samsung/Makefile +0 -1
@@ -14,7 +14,6 @@ obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5-subcmu.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos5433.o -obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o obj-$(CONFIG_EXYNOS_AUDSS_CLK_CON) += clk-exynos-audss.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK) += clk-exynos7.o
drivers/clk/samsung/clk-exynos5440.c deleted +0 -167
167 lines not on this page · raw message
include/dt-bindings/clock/exynos5440.h deleted +0 -44
44 lines not on this page · raw message
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 5/10 i2c: s3c2410: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt | 4 +--- drivers/i2c/busses/i2c-s3c2410.c | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt +1 -3
@@ -8,9 +8,7 @@ Required properties: (b) "samsung, s3c2440-i2c", for i2c compatible with s3c2440 i2c. (c) "samsung, s3c2440-hdmiphy-i2c", for s3c2440-like i2c used inside HDMIPHY block found on several samsung SoCs - (d) "samsung, exynos5440-i2c", for s3c2440-like i2c used - on EXYNOS5440 which does not need GPIO configuration. - (e) "samsung, exynos5-sata-phy-i2c", for s3c2440-like i2c used as + (d) "samsung, exynos5-sata-phy-i2c", for s3c2440-like i2c used as a host to SATA PHY controller on an internal bus. - reg: physical base address of the controller and length of memory mapped region.
drivers/i2c/busses/i2c-s3c2410.c +0 -2
@@ -154,8 +154,6 @@ static const struct of_device_id s3c24xx_i2c_match[] = { { .compatible = "samsung,s3c2440-i2c", .data = (void *)QUIRK_S3C2440 }, { .compatible = "samsung,s3c2440-hdmiphy-i2c", .data = (void *)(QUIRK_S3C2440 | QUIRK_HDMIPHY | QUIRK_NO_GPIO) }, - { .compatible = "samsung,exynos5440-i2c", - .data = (void *)(QUIRK_S3C2440 | QUIRK_NO_GPIO) }, { .compatible = "samsung,exynos5-sata-phy-i2c", .data = (void *)(QUIRK_S3C2440 | QUIRK_POLL | QUIRK_NO_GPIO) }, {},
Signature · 1 line
2.14.1
Re: [RFC 05/10] i2c: s3c2410: Remove support for Exynos5440
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Re: [RFC 05/10] i2c: s3c2410: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
looks good, Reviewed-by: Andi Shyti <[email protected]>
Thanks,
Andi
Wolfram Sang
AppliedRe: [RFC 05/10] i2c: s3c2410: Remove support for Exynos5440
In reply to Krzysztof KozlowskiQuoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Applied to for-next, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180428/957a4be4/attachment-0001.sig>
Krzysztof Kozlowski
maintainerRFC 5/10 i2c: s3c2410: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt | 4 +--- drivers/i2c/busses/i2c-s3c2410.c | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt +1 -3
@@ -8,9 +8,7 @@ Required properties: (b) "samsung, s3c2440-i2c", for i2c compatible with s3c2440 i2c. (c) "samsung, s3c2440-hdmiphy-i2c", for s3c2440-like i2c used inside HDMIPHY block found on several samsung SoCs - (d) "samsung, exynos5440-i2c", for s3c2440-like i2c used - on EXYNOS5440 which does not need GPIO configuration. - (e) "samsung, exynos5-sata-phy-i2c", for s3c2440-like i2c used as + (d) "samsung, exynos5-sata-phy-i2c", for s3c2440-like i2c used as a host to SATA PHY controller on an internal bus. - reg: physical base address of the controller and length of memory mapped region.
drivers/i2c/busses/i2c-s3c2410.c +0 -2
@@ -154,8 +154,6 @@ static const struct of_device_id s3c24xx_i2c_match[] = { { .compatible = "samsung,s3c2440-i2c", .data = (void *)QUIRK_S3C2440 }, { .compatible = "samsung,s3c2440-hdmiphy-i2c", .data = (void *)(QUIRK_S3C2440 | QUIRK_HDMIPHY | QUIRK_NO_GPIO) }, - { .compatible = "samsung,exynos5440-i2c", - .data = (void *)(QUIRK_S3C2440 | QUIRK_NO_GPIO) }, { .compatible = "samsung,exynos5-sata-phy-i2c", .data = (void *)(QUIRK_S3C2440 | QUIRK_POLL | QUIRK_NO_GPIO) }, {},
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 6/10 thermal: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- drivers/thermal/samsung/exynos_tmu.c | 155 +-------------------- drivers/thermal/samsung/exynos_tmu.h | 1 - 3 files changed, 4 insertions(+), 166 deletions(-)
Documentation/devicetree/bindings/thermal/exynos-thermal.txt +1 -13
@@ -12,7 +12,6 @@ "samsung,exynos5420-tmu-ext-triminfo" for TMU channels 2, 3 and 4 Exynos5420 (Must pass triminfo base and triminfo clock) "samsung,exynos5433-tmu" - "samsung,exynos5440-tmu" "samsung,exynos7-tmu" - interrupt-parent : The phandle for the interrupt controller - reg : Address range of the thermal registers. For soc's which has multiple
@@ -68,18 +67,7 @@ Example 1): #thermal-sensor-cells = <0>; }; -Example 2): - - tmuctrl_0: tmuctrl at 160118 { - compatible = "samsung,exynos5440-tmu"; - reg = <0x160118 0x230>, <0x160368 0x10>; - interrupts = <0 58 0>; - clocks = <&clock 21>; - clock-names = "tmu_apbif"; - #thermal-sensor-cells = <0>; - }; - -Example 3): (In case of Exynos5420 "with misplaced TRIMINFO register") +Example 2): (In case of Exynos5420 "with misplaced TRIMINFO register") tmu_cpu2: tmu at 10068000 { compatible = "samsung,exynos5420-tmu-ext-triminfo"; reg = <0x10068000 0x100>, <0x1006c000 0x4>;
drivers/thermal/samsung/exynos_tmu.c +3 -152
242 lines not on this page · raw message
drivers/thermal/samsung/exynos_tmu.h +0 -1
@@ -34,7 +34,6 @@ enum soc_type {SOC_ARCH_EXYNOS5420 ,SOC_ARCH_EXYNOS5420_TRIMINFO ,SOC_ARCH_EXYNOS5433 , -SOC_ARCH_EXYNOS5440 , SOC_ARCH_EXYNOS7, };
Signature · 1 line
2.14.1
Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
Quoted 3 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Thanks for doing this.
Quoted 1 line
Signed-off-by Krzysztof Kozlowski <[email protected]>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiQuoted 3 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Thanks for doing this.
Quoted 1 line
Signed-off-by Krzysztof Kozlowski <[email protected]>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
PATCH 1/1 thermal: samsung: Remove support for Exynos5440
From: Krzysztof Kozlowski <[email protected]>
Subject: [PATCH] thermal: samsung: Remove support for Exynos5440
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
---
Eduardo, here is a version which applies on top of pending Exynos thermal changes (https://lkml.org/lkml/2018/4/16/256).
Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 14 drivers/thermal/samsung/exynos_tmu.c | 161 ----------- 2 files changed, 4 insertions(+), 171 deletions(-)
Documentation/devicetree/bindings/thermal/exynos-thermal.txt +1 -13
@@ -12,7 +12,6 @@ "samsung,exynos5420-tmu-ext-triminfo" for TMU channels 2, 3 and 4 Exynos5420 (Must pass triminfo base and triminfo clock) "samsung,exynos5433-tmu" - "samsung,exynos5440-tmu" "samsung,exynos7-tmu" - interrupt-parent : The phandle for the interrupt controller - reg : Address range of the thermal registers. For soc's which has multiple
@@ -68,18 +67,7 @@ Example 1): #thermal-sensor-cells = <0>; }; -Example 2): - - tmuctrl_0: tmuctrl at 160118 { - compatible = "samsung,exynos5440-tmu"; - reg = <0x160118 0x230>, <0x160368 0x10>; - interrupts = <0 58 0>; - clocks = <&clock 21>; - clock-names = "tmu_apbif"; - #thermal-sensor-cells = <0>; - }; - -Example 3): (In case of Exynos5420 "with misplaced TRIMINFO register") +Example 2): (In case of Exynos5420 "with misplaced TRIMINFO register") tmu_cpu2: tmu at 10068000 { compatible = "samsung,exynos5420-tmu-ext-triminfo"; reg = <0x10068000 0x100>, <0x1006c000 0x4>;
drivers/thermal/samsung/exynos_tmu.c +3 -158
248 lines not on this page · raw message
Re: [PATCH] thermal: samsung: Remove support for Exynos5440
Quoted 10 lines · Bartlomiej Zolnierkiewicz
From: Krzysztof Kozlowski <[email protected]>
Subject: [PATCH] thermal: samsung: Remove support for Exynos5440The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>[b.zolnierkie: ported over driver changes]Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Quoted 7 lines
---
Eduardo, here is a version which applies on top of pending Exynos thermal changes (https://lkml.org/lkml/2018/4/16/256).Documentation/devicetree/bindings/thermal/exynos-thermal.txt | 14 drivers/thermal/samsung/exynos_tmu.c | 161 ----------- 2 files changed, 4 insertions(+), 171 deletions(-)
Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 10 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- drivers/thermal/samsung/exynos_tmu.c | 155 +-------------------- drivers/thermal/samsung/exynos_tmu.h | 1 - 3 files changed, 4 insertions(+), 166 deletions(-)
After applied this patch, I tested the build and found out 'exynos5440' keyword. There is one comment including 'exynos5440' as following:
drivers/thermal/samsung/exynos_tmu.c +1 -1
@@ -943,7 +943,7 @@ static void exynos4210_tmu_clear_irqs(struct exynos_tmu_data *data)* Exynos3250, Exynos4412, Exynos5250 and Exynos5260 incorrectly * states that INTCLEAR register has a different placing of bits * responsible for FALL IRQs than INTSTAT register. Exynos5420 -* and Exynos5440 documentation is correct (Exynos4210 doesn't +* documentation is correct (Exynos4210 doesn't * support FALL IRQs at all). */ writel (val_irq, data->base + tmu_intclear);
After removing it, looks good to me.
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Krzysztof Kozlowski
maintainerRe: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
Quoted 32 lines · Chanwoo Choi
Hi Krzysztof,
Quoted 10 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- drivers/thermal/samsung/exynos_tmu.c | 155 +-------------------- drivers/thermal/samsung/exynos_tmu.h | 1 - 3 files changed, 4 insertions(+), 166 deletions(-)After applied this patch, I tested the build and found out 'exynos5440' keyword. There is one comment including 'exynos5440' as following:
drivers/thermal/samsung/exynos_tmu.c +1
-1@@ -943,7 +943,7 @@ static void exynos4210_tmu_clear_irqs(struct exynos_tmu_data *data)* Exynos3250, Exynos4412, Exynos5250 and Exynos5260 incorrectly * states that INTCLEAR register has a different placing of bits * responsible for FALL IRQs than INTSTAT register. Exynos5420 -* and Exynos5440 documentation is correct (Exynos4210 doesn't +* documentation is correct (Exynos4210 doesn't * support FALL IRQs at all). */ writel (val_irq, data->base + tmu_intclear);
Quoted 2 lines
After removing it, looks good to me.
Reviewed-by Chanwoo Choi <[email protected]>
Thanks, I left this comment intentionally as it has some meaning even when Exynos5440 is not supported.
Best regards,
Krzysztof
Re: [RFC 06/10] thermal: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 10 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- drivers/thermal/samsung/exynos_tmu.c | 155 +-------------------- drivers/thermal/samsung/exynos_tmu.h | 1 - 3 files changed, 4 insertions(+), 166 deletions(-)
After applied this patch, I tested the build and found out 'exynos5440' keyword. There is one comment including 'exynos5440' as following:
drivers/thermal/samsung/exynos_tmu.c +1 -1
@@ -943,7 +943,7 @@ static void exynos4210_tmu_clear_irqs(struct exynos_tmu_data *data)* Exynos3250, Exynos4412, Exynos5250 and Exynos5260 incorrectly * states that INTCLEAR register has a different placing of bits * responsible for FALL IRQs than INTSTAT register. Exynos5420 -* and Exynos5440 documentation is correct (Exynos4210 doesn't +* documentation is correct (Exynos4210 doesn't * support FALL IRQs at all). */ writel (val_irq, data->base + tmu_intclear);
After removing it, looks good to me.
Signature · 8 lines
Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Krzysztof Kozlowski
maintainerRFC 6/10 thermal: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- .../devicetree/bindings/thermal/exynos-thermal.txt | 14 +- drivers/thermal/samsung/exynos_tmu.c | 155 +-------------------- drivers/thermal/samsung/exynos_tmu.h | 1 - 3 files changed, 4 insertions(+), 166 deletions(-)
Documentation/devicetree/bindings/thermal/exynos-thermal.txt +1 -13
@@ -12,7 +12,6 @@ "samsung,exynos5420-tmu-ext-triminfo" for TMU channels 2, 3 and 4 Exynos5420 (Must pass triminfo base and triminfo clock) "samsung,exynos5433-tmu" - "samsung,exynos5440-tmu" "samsung,exynos7-tmu" - interrupt-parent : The phandle for the interrupt controller - reg : Address range of the thermal registers. For soc's which has multiple
@@ -68,18 +67,7 @@ Example 1): #thermal-sensor-cells = <0>; }; -Example 2): - - tmuctrl_0: tmuctrl@160118 { - compatible = "samsung,exynos5440-tmu"; - reg = <0x160118 0x230>, <0x160368 0x10>; - interrupts = <0 58 0>; - clocks = <&clock 21>; - clock-names = "tmu_apbif"; - #thermal-sensor-cells = <0>; - }; - -Example 3): (In case of Exynos5420 "with misplaced TRIMINFO register") +Example 2): (In case of Exynos5420 "with misplaced TRIMINFO register") tmu_cpu2: tmu@10068000 { compatible = "samsung,exynos5420-tmu-ext-triminfo"; reg = <0x10068000 0x100>, <0x1006c000 0x4>;
drivers/thermal/samsung/exynos_tmu.c +3 -152
242 lines not on this page · raw message
drivers/thermal/samsung/exynos_tmu.h +0 -1
@@ -34,7 +34,6 @@ enum soc_type {SOC_ARCH_EXYNOS5420 ,SOC_ARCH_EXYNOS5420_TRIMINFO ,SOC_ARCH_EXYNOS5433 , -SOC_ARCH_EXYNOS5440 , SOC_ARCH_EXYNOS7, };
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 7/10 pinctrl: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- drivers/pinctrl/samsung/Kconfig | 10 +- drivers/pinctrl/samsung/Makefile | 1 - drivers/pinctrl/samsung/pinctrl-exynos5440.c | 1005 -------------------------- 3 files changed, 2 insertions(+), 1014 deletions(-) delete mode 100644 drivers/pinctrl/samsung/pinctrl-exynos5440.c
drivers/pinctrl/samsung/Kconfig +2 -8
@@ -8,26 +8,20 @@ config PINCTRL_SAMSUNG select PINCONF config PINCTRL_EXYNOS - bool "Pinctrl driver data for Samsung EXYNOS SoCs other than 5440" + bool "Pinctrl driver data for Samsung EXYNOS SoCs" depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210) select PINCTRL_SAMSUNG select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS config PINCTRL_EXYNOS_ARM - bool "ARMv7-specific pinctrl driver data for Exynos (except Exynos5440)" if COMPILE_TEST + bool "ARMv7-specific pinctrl driver data for Exynos" if COMPILE_TEST depends on PINCTRL_EXYNOS config PINCTRL_EXYNOS_ARM64 bool "ARMv8-specific pinctrl driver data for Exynos" if COMPILE_TEST depends on PINCTRL_EXYNOS -config PINCTRL_EXYNOS5440 - bool "Samsung EXYNOS5440 SoC pinctrl driver" - depends on SOC_EXYNOS5440 - select PINMUX - select PINCONF - config PINCTRL_S3C24XX bool "Samsung S3C24XX SoC pinctrl driver" depends on ARCH_S3C24XX && OF
drivers/pinctrl/samsung/Makefile +0 -1
@@ -5,6 +5,5 @@ obj-$(CONFIG_PINCTRL_SAMSUNG) += pinctrl-samsung.o obj-$(CONFIG_PINCTRL_EXYNOS) += pinctrl-exynos.o obj-$(CONFIG_PINCTRL_EXYNOS_ARM) += pinctrl-exynos-arm.o obj-$(CONFIG_PINCTRL_EXYNOS_ARM64) += pinctrl-exynos-arm64.o -obj-$(CONFIG_PINCTRL_EXYNOS5440) += pinctrl-exynos5440.o obj-$(CONFIG_PINCTRL_S3C24XX) += pinctrl-s3c24xx.o obj-$(CONFIG_PINCTRL_S3C64XX) += pinctrl-s3c64xx.o
drivers/pinctrl/samsung/pinctrl-exynos5440.c deleted +0 -1005
1,005 lines not on this page · raw message
Signature · 1 line
2.14.1
Re: [RFC 07/10] pinctrl: samsung: Remove support for Exynos5440
Hi,
Quoted 11 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/pinctrl/samsung/Kconfig | 10 +- drivers/pinctrl/samsung/Makefile | 1 - drivers/pinctrl/samsung/pinctrl-exynos5440.c | 1005 -------------------------- 3 files changed, 2 insertions(+), 1014 deletions(-) delete mode 100644 drivers/pinctrl/samsung/pinctrl-exynos5440.c
Looks good to me.
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics
Re: [RFC 07/10] pinctrl: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi,
Quoted 11 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/pinctrl/samsung/Kconfig | 10 +- drivers/pinctrl/samsung/Makefile | 1 - drivers/pinctrl/samsung/pinctrl-exynos5440.c | 1005 -------------------------- 3 files changed, 2 insertions(+), 1014 deletions(-) delete mode 100644 drivers/pinctrl/samsung/pinctrl-exynos5440.c
Looks good to me.
Signature · 8 lines
Best Regards, Chanwoo Choi Samsung Electronics _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [RFC 07/10] pinctrl: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiQuoted 4 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Quoted 8 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/pinctrl/samsung/Kconfig | 10 +- drivers/pinctrl/samsung/Makefile | 1 - drivers/pinctrl/samsung/pinctrl-exynos5440.c | 1005 -------------------------- 3 files changed, 2 insertions(+), 1014 deletions(-) delete mode 100644 drivers/pinctrl/samsung/pinctrl-exynos5440.c
Applied.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerRFC 7/10 pinctrl: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- drivers/pinctrl/samsung/Kconfig | 10 +- drivers/pinctrl/samsung/Makefile | 1 - drivers/pinctrl/samsung/pinctrl-exynos5440.c | 1005 -------------------------- 3 files changed, 2 insertions(+), 1014 deletions(-) delete mode 100644 drivers/pinctrl/samsung/pinctrl-exynos5440.c
drivers/pinctrl/samsung/Kconfig +2 -8
@@ -8,26 +8,20 @@ config PINCTRL_SAMSUNG select PINCONF config PINCTRL_EXYNOS - bool "Pinctrl driver data for Samsung EXYNOS SoCs other than 5440" + bool "Pinctrl driver data for Samsung EXYNOS SoCs" depends on OF && GPIOLIB && (ARCH_EXYNOS || ARCH_S5PV210) select PINCTRL_SAMSUNG select PINCTRL_EXYNOS_ARM if ARM && (ARCH_EXYNOS || ARCH_S5PV210) select PINCTRL_EXYNOS_ARM64 if ARM64 && ARCH_EXYNOS config PINCTRL_EXYNOS_ARM - bool "ARMv7-specific pinctrl driver data for Exynos (except Exynos5440)" if COMPILE_TEST + bool "ARMv7-specific pinctrl driver data for Exynos" if COMPILE_TEST depends on PINCTRL_EXYNOS config PINCTRL_EXYNOS_ARM64 bool "ARMv8-specific pinctrl driver data for Exynos" if COMPILE_TEST depends on PINCTRL_EXYNOS -config PINCTRL_EXYNOS5440 - bool "Samsung EXYNOS5440 SoC pinctrl driver" - depends on SOC_EXYNOS5440 - select PINMUX - select PINCONF - config PINCTRL_S3C24XX bool "Samsung S3C24XX SoC pinctrl driver" depends on ARCH_S3C24XX && OF
drivers/pinctrl/samsung/Makefile +0 -1
@@ -5,6 +5,5 @@ obj-$(CONFIG_PINCTRL_SAMSUNG) += pinctrl-samsung.o obj-$(CONFIG_PINCTRL_EXYNOS) += pinctrl-exynos.o obj-$(CONFIG_PINCTRL_EXYNOS_ARM) += pinctrl-exynos-arm.o obj-$(CONFIG_PINCTRL_EXYNOS_ARM64) += pinctrl-exynos-arm64.o -obj-$(CONFIG_PINCTRL_EXYNOS5440) += pinctrl-exynos5440.o obj-$(CONFIG_PINCTRL_S3C24XX) += pinctrl-s3c24xx.o obj-$(CONFIG_PINCTRL_S3C64XX) += pinctrl-s3c64xx.o
drivers/pinctrl/samsung/pinctrl-exynos5440.c deleted +0 -1005
1,005 lines not on this page · raw message
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 8/10 spi: s3c64xx: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- drivers/spi/spi-s3c64xx.c | 12 ------------ 1 file changed, 12 deletions(-)
drivers/spi/spi-s3c64xx.c +0 -12
@@ -1376,15 +1376,6 @@ static struct s3c64xx_spi_port_config exynos4_spi_port_config = { .clk_from_cmu = true, }; -static struct s3c64xx_spi_port_config exynos5440_spi_port_config = { - .fifo_lvl_mask = {0x1ff }, - .rx_lvl_offset =15 , - .tx_st_done =25 , - .high_speed = true, - .clk_from_cmu = true, - .quirks =S3C64XX_SPI_QUIRK_POLL , -}; -static struct s3c64xx_spi_port_config exynos7_spi_port_config = { .fifo_lvl_mask = {0x1ff ,0x7F ,0x7F ,0x7F ,0x7F ,0x1ff }, .rx_lvl_offset =15 ,
@@ -1428,9 +1419,6 @@ static const struct of_device_id s3c64xx_spi_dt_match[] = { { .compatible = "samsung,exynos4210-spi", .data = (void *)&exynos4_spi_port_config, }, - { .compatible = "samsung,exynos5440-spi", - .data = (void *)&exynos5440_spi_port_config, - }, { .compatible = "samsung,exynos7-spi", .data = (void *)&exynos7_spi_port_config, },
Signature · 1 line
2.14.1
Re: [RFC 08/10] spi: s3c64xx: samsung: Remove support for Exynos5440
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
It's good you didn't remove S3C64XX_SPI_QUIRK_POLL entirely as it will be needed for Exynos5433 ISP SPI controllers.
Krzysztof Kozlowski
maintainerRe: [RFC 08/10] spi: s3c64xx: samsung: Remove support for Exynos5440
Quoted 9 lines · Sylwester Nawrocki
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>It's good you didn't remove
S3C64XX_SPI_QUIRK_POLLentirely as it will be needed for Exynos5433 ISP SPI controllers.
Ah, actually I did not plan to skip it... I just missed it :). I should check affected drivers if this removal left any unused symbols (except the one mentioned).
Thanks for hint!
Krzysztof
Re: [RFC 08/10] spi: s3c64xx: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiHi Krzysztof,
Quoted 5 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>
Thanks,
Andi
Krzysztof Kozlowski
maintainerRFC 8/10 spi: s3c64xx: samsung: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- drivers/spi/spi-s3c64xx.c | 12 ------------ 1 file changed, 12 deletions(-)
drivers/spi/spi-s3c64xx.c +0 -12
@@ -1376,15 +1376,6 @@ static struct s3c64xx_spi_port_config exynos4_spi_port_config = { .clk_from_cmu = true, }; -static struct s3c64xx_spi_port_config exynos5440_spi_port_config = { - .fifo_lvl_mask = {0x1ff }, - .rx_lvl_offset =15 , - .tx_st_done =25 , - .high_speed = true, - .clk_from_cmu = true, - .quirks =S3C64XX_SPI_QUIRK_POLL , -}; -static struct s3c64xx_spi_port_config exynos7_spi_port_config = { .fifo_lvl_mask = {0x1ff ,0x7F ,0x7F ,0x7F ,0x7F ,0x1ff }, .rx_lvl_offset =15 ,
@@ -1428,9 +1419,6 @@ static const struct of_device_id s3c64xx_spi_dt_match[] = { { .compatible = "samsung,exynos4210-spi", .data = (void *)&exynos4_spi_port_config, }, - { .compatible = "samsung,exynos5440-spi", - .data = (void *)&exynos5440_spi_port_config, - }, { .compatible = "samsung,exynos7-spi", .data = (void *)&exynos7_spi_port_config, },
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 9/10 usb: host: exynos: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- drivers/usb/host/ehci-exynos.c | 7 ------- drivers/usb/host/ohci-exynos.c | 6 ------ 2 files changed, 13 deletions(-)
drivers/usb/host/ehci-exynos.c +0 -7
@@ -161,16 +161,10 @@ static int exynos_ehci_probe(struct platform_device *pdev) } exynos_ehci =to_exynos_ehci (hcd); -if (of_device_is_compatible (pdev->dev.of_node, -"samsung,exynos5440-ehci" )) - goto skip_phy; - err =exynos_ehci_get_phy (&pdev->dev, exynos_ehci);if (err) goto fail_clk; -skip_phy: - exynos_ehci->clk =devm_clk_get (&pdev->dev,"usbhost" );if (IS_ERR (exynos_ehci->clk)) {
@@ -304,7 +298,6 @@ static const struct dev_pm_ops exynos_ehci_pm_ops = {#ifdef CONFIG_OF static const struct of_device_id exynos_ehci_match[] = { { .compatible ="samsung,exynos4210-ehci" }, - { .compatible ="samsung,exynos5440-ehci" }, {}, };MODULE_DEVICE_TABLE (of, exynos_ehci_match);
drivers/usb/host/ohci-exynos.c +0 -6
@@ -130,15 +130,10 @@ static int exynos_ohci_probe(struct platform_device *pdev) exynos_ohci =to_exynos_ohci (hcd); -if (of_device_is_compatible (pdev->dev.of_node, -"samsung,exynos5440-ohci" )) - goto skip_phy; - err =exynos_ohci_get_phy (&pdev->dev, exynos_ohci);if (err) goto fail_clk; -skip_phy: exynos_ohci->clk =devm_clk_get (&pdev->dev,"usbhost" );if (IS_ERR (exynos_ohci->clk)) {
@@ -270,7 +265,6 @@ static const struct dev_pm_ops exynos_ohci_pm_ops = {#ifdef CONFIG_OF static const struct of_device_id exynos_ohci_match[] = { { .compatible ="samsung,exynos4210-ohci" }, - { .compatible ="samsung,exynos5440-ohci" }, {}, };MODULE_DEVICE_TABLE (of, exynos_ohci_match);
Signature · 1 line
2.14.1
Re: [RFC 09/10] usb: host: exynos: Remove support for Exynos5440
Quoted 9 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- drivers/usb/host/ehci-exynos.c | 7 ------- drivers/usb/host/ohci-exynos.c | 6 ------ 2 files changed, 13 deletions(-)
Krzysztof Kozlowski
maintainerRFC 9/10 usb: host: exynos: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- drivers/usb/host/ehci-exynos.c | 7 ------- drivers/usb/host/ohci-exynos.c | 6 ------ 2 files changed, 13 deletions(-)
drivers/usb/host/ehci-exynos.c +0 -7
@@ -161,16 +161,10 @@ static int exynos_ehci_probe(struct platform_device *pdev) } exynos_ehci =to_exynos_ehci (hcd); -if (of_device_is_compatible (pdev->dev.of_node, -"samsung,exynos5440-ehci" )) - goto skip_phy; - err =exynos_ehci_get_phy (&pdev->dev, exynos_ehci);if (err) goto fail_clk; -skip_phy: - exynos_ehci->clk =devm_clk_get (&pdev->dev,"usbhost" );if (IS_ERR (exynos_ehci->clk)) {
@@ -304,7 +298,6 @@ static const struct dev_pm_ops exynos_ehci_pm_ops = {#ifdef CONFIG_OF static const struct of_device_id exynos_ehci_match[] = { { .compatible ="samsung,exynos4210-ehci" }, - { .compatible ="samsung,exynos5440-ehci" }, {}, };MODULE_DEVICE_TABLE (of, exynos_ehci_match);
drivers/usb/host/ohci-exynos.c +0 -6
@@ -130,15 +130,10 @@ static int exynos_ohci_probe(struct platform_device *pdev) exynos_ohci =to_exynos_ohci (hcd); -if (of_device_is_compatible (pdev->dev.of_node, -"samsung,exynos5440-ohci" )) - goto skip_phy; - err =exynos_ohci_get_phy (&pdev->dev, exynos_ohci);if (err) goto fail_clk; -skip_phy: exynos_ohci->clk =devm_clk_get (&pdev->dev,"usbhost" );if (IS_ERR (exynos_ohci->clk)) {
@@ -270,7 +265,6 @@ static const struct dev_pm_ops exynos_ohci_pm_ops = {#ifdef CONFIG_OF static const struct of_device_id exynos_ohci_match[] = { { .compatible ="samsung,exynos4210-ohci" }, - { .compatible ="samsung,exynos5440-ohci" }, {}, };MODULE_DEVICE_TABLE (of, exynos_ohci_match);
Signature · 1 line
2.14.1
Krzysztof Kozlowski
maintainerRFC 10/10 ARM: exynos: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- arch/arm/mach-exynos/Kconfig | 12 ------------ arch/arm/mach-exynos/common.h | 8 -------- arch/arm/mach-exynos/exynos.c | 15 ++------------- 3 files changed, 2 insertions(+), 33 deletions(-)
arch/arm/mach-exynos/Kconfig +0 -12
@@ -108,18 +108,6 @@ config SOC_EXYNOS5420 default y depends on ARCH_EXYNOS5 -config SOC_EXYNOS5440 - bool "SAMSUNG EXYNOS5440" - default y - depends on ARCH_EXYNOS5 - select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE - select HAVE_ARM_ARCH_TIMER - select AUTO_ZRELADDR - select PINCTRL_EXYNOS5440 - select PM_OPP - help - Enable EXYNOS5440 SoC support - config SOC_EXYNOS5800 bool "SAMSUNG EXYNOS5800" default y
arch/arm/mach-exynos/common.h +0 -8
@@ -21,7 +21,6 @@#define EXYNOS5250_SOC_ID 0x43520000#define EXYNOS5410_SOC_ID 0xE5410000#define EXYNOS5420_SOC_ID 0xE5420000 -#define EXYNOS5440_SOC_ID 0xE5440000#define EXYNOS5800_SOC_ID 0xE5422000#define EXYNOS5_SOC_MASK 0xFFFFF000
@@ -39,7 +38,6 @@ IS_SAMSUNG_CPU(exynos4412, EXYNOS4412_CPU_ID, EXYNOS4_CPU_MASK) IS_SAMSUNG_CPU(exynos5250, EXYNOS5250_SOC_ID, EXYNOS5_SOC_MASK) IS_SAMSUNG_CPU(exynos5410, EXYNOS5410_SOC_ID, EXYNOS5_SOC_MASK) IS_SAMSUNG_CPU(exynos5420, EXYNOS5420_SOC_ID, EXYNOS5_SOC_MASK) -IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK) IS_SAMSUNG_CPU(exynos5800, EXYNOS5800_SOC_ID, EXYNOS5_SOC_MASK)#if defined(CONFIG_SOC_EXYNOS3250 )
@@ -82,12 +80,6 @@ IS_SAMSUNG_CPU(exynos5800, EXYNOS5800_SOC_ID, EXYNOS5_SOC_MASK)# define soc_is_exynos5420 () 0#endif -#if defined(CONFIG_SOC_EXYNOS5440 ) -# define soc_is_exynos5440 () is_samsung_exynos5440() -#else -# define soc_is_exynos5440 () 0 -#endif -#if defined(CONFIG_SOC_EXYNOS5800 )# define soc_is_exynos5800 () is_samsung_exynos5800()#else
arch/arm/mach-exynos/exynos.c +2 -13
@@ -63,15 +63,6 @@ void __init exynos_sysram_init(void) } } -static void __init exynos_init_late (void ) -{ -if (of_machine_is_compatible ("samsung,exynos5440" )) -/* to be supported later */ -return ; - -exynos_pm_init (); -} -static int __init exynos_fdt_map_chipid (unsigned long node,const char *uname,int depth,void *data) {
@@ -79,8 +70,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,const __be32 *reg;int len; -if (!of_flat_dt_is_compatible (node,"samsung,exynos4210-chipid" ) && - !of_flat_dt_is_compatible (node,"samsung,exynos5440-clock" )) +if (!of_flat_dt_is_compatible (node,"samsung,exynos4210-chipid" ))return 0 ; reg =of_get_flat_dt_prop (node,"reg" , &len);
@@ -209,7 +199,6 @@ static char const *const exynos_dt_compat[] __initconst = {"samsung,exynos5250" ,"samsung,exynos5260" ,"samsung,exynos5420" , -"samsung,exynos5440" , NULL };
@@ -232,7 +221,7 @@ DT_MACHINE_START(EXYNOS_DT, "SAMSUNG EXYNOS (Flattened Device Tree)") .init_early = exynos_firmware_init, .init_irq = exynos_init_irq, .init_machine = exynos_dt_machine_init, - .init_late = exynos_init_late, + .init_late = exynos_pm_init, .dt_compat = exynos_dt_compat, .dt_fixup = exynos_dt_fixup,MACHINE_END
Signature · 1 line
2.14.1
Re: [RFC 10/10] ARM: exynos: Remove support for Exynos5440
Quoted 11 lines · Krzysztof Kozlowski
The Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
Signed-off-by Krzysztof Kozlowski <[email protected]>--- arch/arm/mach-exynos/Kconfig | 12 ------------ arch/arm/mach-exynos/common.h | 8 -------- arch/arm/mach-exynos/exynos.c | 15 ++------------- 3 files changed, 2 insertions(+), 33 deletions(-)
Applied.
Best regards,
Krzysztof
Krzysztof Kozlowski
maintainerRFC 10/10 ARM: exynos: Remove support for Exynos5440
In reply to Krzysztof KozlowskiThe Exynos5440 is not actively developed, there are no development boards available and probably there are no real products with it. Remove wide-tree support for Exynos5440.
--- arch/arm/mach-exynos/Kconfig | 12 ------------ arch/arm/mach-exynos/common.h | 8 -------- arch/arm/mach-exynos/exynos.c | 15 ++------------- 3 files changed, 2 insertions(+), 33 deletions(-)
arch/arm/mach-exynos/Kconfig +0 -12
@@ -108,18 +108,6 @@ config SOC_EXYNOS5420 default y depends on ARCH_EXYNOS5 -config SOC_EXYNOS5440 - bool "SAMSUNG EXYNOS5440" - default y - depends on ARCH_EXYNOS5 - select ARCH_DMA_ADDR_T_64BIT if ARM_LPAE - select HAVE_ARM_ARCH_TIMER - select AUTO_ZRELADDR - select PINCTRL_EXYNOS5440 - select PM_OPP - help - Enable EXYNOS5440 SoC support - config SOC_EXYNOS5800 bool "SAMSUNG EXYNOS5800" default y
arch/arm/mach-exynos/common.h +0 -8
@@ -21,7 +21,6 @@#define EXYNOS5250_SOC_ID 0x43520000#define EXYNOS5410_SOC_ID 0xE5410000#define EXYNOS5420_SOC_ID 0xE5420000 -#define EXYNOS5440_SOC_ID 0xE5440000#define EXYNOS5800_SOC_ID 0xE5422000#define EXYNOS5_SOC_MASK 0xFFFFF000
@@ -39,7 +38,6 @@ IS_SAMSUNG_CPU(exynos4412, EXYNOS4412_CPU_ID, EXYNOS4_CPU_MASK) IS_SAMSUNG_CPU(exynos5250, EXYNOS5250_SOC_ID, EXYNOS5_SOC_MASK) IS_SAMSUNG_CPU(exynos5410, EXYNOS5410_SOC_ID, EXYNOS5_SOC_MASK) IS_SAMSUNG_CPU(exynos5420, EXYNOS5420_SOC_ID, EXYNOS5_SOC_MASK) -IS_SAMSUNG_CPU(exynos5440, EXYNOS5440_SOC_ID, EXYNOS5_SOC_MASK) IS_SAMSUNG_CPU(exynos5800, EXYNOS5800_SOC_ID, EXYNOS5_SOC_MASK)#if defined(CONFIG_SOC_EXYNOS3250 )
@@ -82,12 +80,6 @@ IS_SAMSUNG_CPU(exynos5800, EXYNOS5800_SOC_ID, EXYNOS5_SOC_MASK)# define soc_is_exynos5420 () 0#endif -#if defined(CONFIG_SOC_EXYNOS5440 ) -# define soc_is_exynos5440 () is_samsung_exynos5440() -#else -# define soc_is_exynos5440 () 0 -#endif -#if defined(CONFIG_SOC_EXYNOS5800 )# define soc_is_exynos5800 () is_samsung_exynos5800()#else
arch/arm/mach-exynos/exynos.c +2 -13
@@ -63,15 +63,6 @@ void __init exynos_sysram_init(void) } } -static void __init exynos_init_late (void ) -{ -if (of_machine_is_compatible ("samsung,exynos5440" )) -/* to be supported later */ -return ; - -exynos_pm_init (); -} -static int __init exynos_fdt_map_chipid (unsigned long node,const char *uname,int depth,void *data) {
@@ -79,8 +70,7 @@ static int __init exynos_fdt_map_chipid(unsigned long node, const char *uname,const __be32 *reg;int len; -if (!of_flat_dt_is_compatible (node,"samsung,exynos4210-chipid" ) && - !of_flat_dt_is_compatible (node,"samsung,exynos5440-clock" )) +if (!of_flat_dt_is_compatible (node,"samsung,exynos4210-chipid" ))return 0 ; reg =of_get_flat_dt_prop (node,"reg" , &len);
@@ -209,7 +199,6 @@ static char const *const exynos_dt_compat[] __initconst = {"samsung,exynos5250" ,"samsung,exynos5260" ,"samsung,exynos5420" , -"samsung,exynos5440" , NULL };
@@ -232,7 +221,7 @@ DT_MACHINE_START(EXYNOS_DT, "SAMSUNG EXYNOS (Flattened Device Tree)") .init_early = exynos_firmware_init, .init_irq = exynos_init_irq, .init_machine = exynos_dt_machine_init, - .init_late = exynos_init_late, + .init_late = exynos_pm_init, .dt_compat = exynos_dt_compat, .dt_fixup = exynos_dt_fixup,MACHINE_END
Signature · 1 line
2.14.1
Arnd Bergmann
maintainerQuoted 33 lines · Krzysztof Kozlowski
Hi,
Overview
========
Let's continue the removal of old platforms. We already get rid of Exynos4212. Now it's time for Exynos5440.The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting server platforms but it did not make it to the market really. There are no development boards with it and probably there are no real products neither. The development for Exynos5440 ended in 2013 and since then the platform is in maintenance mode.
The only development happening around it is the PCIe driver for Exynos5433 (ARMv8). [1]
Removing Exynos5440, makes our life slightly easier:
1. Less maintenance,
2. Smaller code, less quirks,
3. No need to preserve (imaginary) backward-compatibility for Exynos PCIe driver (so it is easier to add support for Exynos5433).Because of point (3) above - I left the PCIe and PCIe PHY drivers intact.
Dependencies
============
I think about starting with removal of DTS in some kernel release (patch 1/10). Then all drivers can be removed/updated - subsystem maintainers can pick their patches freely.
Quoted 5 lines
Finally, after getting rid of all Exynos5440 symbols, the last patch (10/10) will end in arm-soc tree.
Any comments?
I don't see any hard dependency here, if this is all unused, I think we can apply both patches 1 and 10 into arm-soc at the same time as merging the other patches through the respective subsystem trees.
Arnd
Krzysztof Kozlowski
maintainerQuoted 38 lines · Arnd Bergmann
Quoted 37 lines · Krzysztof Kozlowski
Hi,
Overview
========
Let's continue the removal of old platforms. We already get rid of Exynos4212. Now it's time for Exynos5440.The Exynos5440 (quad-core A15 with GMAC, PCIe, SATA) was targeting server platforms but it did not make it to the market really. There are no development boards with it and probably there are no real products neither. The development for Exynos5440 ended in 2013 and since then the platform is in maintenance mode.
The only development happening around it is the PCIe driver for Exynos5433 (ARMv8). [1]
Removing Exynos5440, makes our life slightly easier:
1. Less maintenance,
2. Smaller code, less quirks,
3. No need to preserve (imaginary) backward-compatibility for Exynos PCIe driver (so it is easier to add support for Exynos5433).Because of point (3) above - I left the PCIe and PCIe PHY drivers intact.
Dependencies
============
I think about starting with removal of DTS in some kernel release (patch 1/10). Then all drivers can be removed/updated - subsystem maintainers can pick their patches freely.Finally, after getting rid of all Exynos5440 symbols, the last patch (10/10) will end in arm-soc tree.
Quoted 5 lines
Quoted 1 line
Any comments?
I don't see any hard dependency here, if this is all unused, I think we can apply both patches 1 and 10 into arm-soc at the same time as merging the other patches through the respective subsystem trees.
The only dependency is through Kconfig symbol (SOC_EXYNOS5440). After applying 10/10, which removes SOC_EXYNOS5440, some automatic code testers can complain about non-existing Kconfig option. That's not big issue because all this will go away so indeed we could take everything in one release.
Best regards,
rzysztof
Arnd Bergmann
maintainerQuoted 7 lines · Krzysztof Kozlowski
Quoted 1 line · Arnd Bergmann
On Tue, Apr 24, 2018 at 10:32 PM, Krzysztof Kozlowski <[email protected]> wrote:
The only dependency is through
Kconfigsymbol (SOC_EXYNOS5440). After applying 10/10, which removesSOC_EXYNOS5440, some automatic code testers can complain about non-existingKconfigoption. That's not big issue because all this will go away so indeed we could take everything in one release.
Right, I wouldn't worry about that. Kbuild itself doesn't warn about missing symbols, so this is only for helpful automated checks that tell us that there is still some pending work.
Arnd