Skip to contentSkip to conversation

package/mesa3d: add Radeon SI support

PATCH New Michał Kalbarczyk 3 participants 5 messages Apr 27, 2018 – Apr 28, 2018

lore
Share & tools
lore
Applied
#1 lore raw

PATCH 1/1 package/mesa3d: add Radeon SI support

Hello,

Quoted 8 lines · Micha? Kalbarczyk

From adff41d0ec39d5e89ce713c88edb0ee6468c7236 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kalbarczyk?= <[email protected]>
Date: Fri, 27 Apr 2018 15:49:15 +0200
Subject: [PATCH 1/1] package/mesa3d: add Radeon SI support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Quoted 5 lines
Signed-off-by Micha? Kalbarczyk <[email protected]>
---
 package/mesa3d/Config.in | 20 ++++++++++++++++++++
 package/mesa3d/mesa3d.mk |  1 +
 2 files changed, 21 insertions(+)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/mesa3d: add Radeon SI support

In reply to Michał Kalbarczyk

Hi Michal,

Le 27/04/2018 ? 16:07, Micha? Kalbarczyk a ?crit?:

Quoted 7 lines

From adff41d0ec39d5e89ce713c88edb0ee6468c7236 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kalbarczyk?= <[email protected]>
Date: Fri, 27 Apr 2018 15:49:15 +0200
Subject: [PATCH 1/1] package/mesa3d: add Radeon SI support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Thanks for this contribution!
I know it's too late since the patch is already applied but here is my review.

Quoted 11 lines
Signed-off-by Micha? Kalbarczyk <[email protected]>
---
 package/mesa3d/Config.in | 20 ++++++++++++++++++++
 package/mesa3d/mesa3d.mk |  1 +
 2 files changed, 21 insertions(+)
package/mesa3d/Config.in +0 -0
index bd3d050e29..cbaa20370f 100644

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 · line 114

Quoted 7 lines
package/mesa3d/Config.in +4 -0
@@ -108,6 +108,26 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
 	help
 	  Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs.
 
+config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI
+	bool "Gallium Radeon SI driver"
+	depends on BR2_i386 || BR2_x86_64
+	depends on !BR2_PACKAGE_MESA3D_LLVM || \

The RadeonSI support require LLVM.

checking for AMDGPU... yes
configure: error: --enable-llvm is required when building radeonsi

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 · line 118

Quoted 4 lines
package/mesa3d/Config.in +4 -0
+		(BR2_PACKAGE_MESA3D_LLVM && (BR2_TOOLCHAIN_USES_UCLIBC || \
+			BR2_TOOLCHAIN_USES_GLIBC)) # elfutils
+	select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
+	select BR2_PACKAGE_LIBDRM_AMDGPU

In my previous review, mesa is checking for libdrm-amdgpu and libdrm-radeon [1]

checking for EXPAT... yes
checking for RADEON... no
configure: error: Package requirements (libdrm >= 2.4.71 libdrm_radeon >= 2.4.71)

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 · line 129

Quoted 11 lines
package/mesa3d/Config.in +11 -0
+	select BR2_PACKAGE_LLVM_AMDGPU if BR2_PACKAGE_MESA3D_LLVM
+	select BR2_PACKAGE_ELFUTILS if BR2_PACKAGE_MESA3D_LLVM
+	select BR2_PACKAGE_MESA3D_NEEDS_XA
+	help
+	  Driver for ATI/AMD Radeon HD7000/HD8000/Rx200 GPUs.
+
+# Radeon SI needs libelf when Mesa3D is built with LLVM support
+# musl is not currently compatible with elfutils
+comment "Radeon SI driver needs a uClibc or glibc toolchain when llvm is enabled"
+	depends on BR2_PACKAGE_MESA3D_LLVM
+	depends on !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)

The comment should be updated accordingly since llvm is mandatory.

Best regards,
Romain

[1] http://lists.busybox.net/pipermail/buildroot/2018-April/219308.html

Quoted 19 lines
package/mesa3d/Config.in +1 -0
+
 # R600 needs libelf when Mesa3D is built with LLVM support
 # musl is not currently compatible with elfutils
 comment "R600 driver needs a uClibc or glibc toolchain when llvm is enabled"
package/mesa3d/mesa3d.mk +1 -1
index e93490c042..9857b597cf 100644
@@ -80,6 +80,7 @@ endif
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV)  += etnaviv imx
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU)  += nouveau
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600)     += r600
+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI) += radeonsi
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA)     += svga
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST)   += swrast
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4)      += vc4
--

2.17.0

author
#3 lore raw

PATCH 1/1 package/mesa3d: add Radeon SI support

I get it now. It works for me because I have selected LIB_RADEON and MESA3D_LLVM in my defconfig. I?ll create another patch. Should i post it in this thread or create another one?

Quoted 88 lines · Romain Naour

Hi Michal,

Le 27/04/2018 ? 16:07, Micha? Kalbarczyk a ?crit :

Quoted 7 lines

From adff41d0ec39d5e89ce713c88edb0ee6468c7236 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Kalbarczyk?= <[email protected]>
Date: Fri, 27 Apr 2018 15:49:15 +0200
Subject: [PATCH 1/1] package/mesa3d: add Radeon SI support
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Thanks for this contribution!
I know it's too late since the patch is already applied but here is my review.

Quoted 11 lines
Signed-off-by Micha? Kalbarczyk <[email protected]>
---
 package/mesa3d/Config.in | 20 ++++++++++++++++++++
 package/mesa3d/mesa3d.mk |  1 +
 2 files changed, 21 insertions(+)
package/mesa3d/Config.in +0 -0
index bd3d050e29..cbaa20370f 100644

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 · line 114

Quoted 7 lines
package/mesa3d/Config.in +4 -0
@@ -108,6 +108,26 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
      help
        Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs.
 
+config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI
+     bool "Gallium Radeon SI driver"
+     depends on BR2_i386 || BR2_x86_64
+     depends on !BR2_PACKAGE_MESA3D_LLVM || \

The RadeonSI support require LLVM.

checking for AMDGPU... yes
configure: error: --enable-llvm is required when building radeonsi

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 · line 118

Quoted 4 lines
package/mesa3d/Config.in +4 -0
+             (BR2_PACKAGE_MESA3D_LLVM && (BR2_TOOLCHAIN_USES_UCLIBC || \
+                     BR2_TOOLCHAIN_USES_GLIBC)) # elfutils
+     select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
+     select BR2_PACKAGE_LIBDRM_AMDGPU

In my previous review, mesa is checking for libdrm-amdgpu and libdrm-radeon [1]

checking for EXPAT... yes
checking for RADEON... no
configure: error: Package requirements (libdrm >= 2.4.71 libdrm_radeon >= 2.4.71)

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 · line 127

Quoted 9 lines
package/mesa3d/Config.in +9 -0
+     select BR2_PACKAGE_LLVM_AMDGPU if BR2_PACKAGE_MESA3D_LLVM
+     select BR2_PACKAGE_ELFUTILS if BR2_PACKAGE_MESA3D_LLVM
+     select BR2_PACKAGE_MESA3D_NEEDS_XA
+     help
+       Driver for ATI/AMD Radeon HD7000/HD8000/Rx200 GPUs.
+
+# Radeon SI needs libelf when Mesa3D is built with LLVM support
+# musl is not currently compatible with elfutils
+comment "Radeon SI driver needs a uClibc or glibc toolchain when llvm

is enabled"

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 · line 129

Quoted 2 lines
package/mesa3d/Config.in +2 -0
+     depends on BR2_PACKAGE_MESA3D_LLVM
+     depends on !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)

The comment should be updated accordingly since llvm is mandatory.

Best regards,
Romain

[1] http://lists.busybox.net/pipermail/buildroot/2018-April/219308.html

package/mesa3d/Config.in config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600 · line 133

Quoted 4 lines
package/mesa3d/Config.in +1 -0
+
 # R600 needs libelf when Mesa3D is built with LLVM support
 # musl is not currently compatible with elfutils
 comment "R600 driver needs a uClibc or glibc toolchain when llvm is

enabled"

package/mesa3d/mesa3d.mk endif · line 80

Quoted 6 lines
package/mesa3d/mesa3d.mk +0 -0
index e93490c042..9857b597cf 100644
@@ -80,6 +80,7 @@ endif
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV)  +=

etnaviv imx

package/mesa3d/mesa3d.mk endif · line 81

Quoted 1 line
package/mesa3d/mesa3d.mk +0 -0
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU)  +=

nouveau

package/mesa3d/mesa3d.mk endif · line 82

Quoted 1 line
package/mesa3d/mesa3d.mk +0 -0
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600)     +=

r600

Quoted 13 lines

package/mesa3d/mesa3d.mk endif · line 83

Quoted 1 line
package/mesa3d/mesa3d.mk +1 -0
+MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI) +=

radeonsi

package/mesa3d/mesa3d.mk endif · line 84

Quoted 1 line
package/mesa3d/mesa3d.mk +0 -0
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA)     +=

svga

package/mesa3d/mesa3d.mk endif · line 85

Quoted 1 line
package/mesa3d/mesa3d.mk +0 -0
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST)   +=

swrast

package/mesa3d/mesa3d.mk endif · line 86

Quoted 1 line
package/mesa3d/mesa3d.mk +0 -0
 MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4)      +=

vc4

Quoted 3 lines

--
2.17.0

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180428/f93d07fb/attachment.html>

#4 lore raw

PATCH 1/1 package/mesa3d: add Radeon SI support

Hi Michal,

Le 28/04/2018 ? 16:59, Micha? Kalbarczyk a ?crit?:

Quoted 3 lines

I get it now. It works for me because I have selected LIB_RADEON and MESA3D_LLVM in my defconfig. I?ll create another patch. Should i post it in this thread or create another one?

Simply post a new patch on the ml using git send-email command.

Best regards,
Romain

Quoted 101 lines

On Sat, 28 Apr 2018 at 15:55, Romain Naour <[email protected] <mailto:[email protected]>> wrote:

    Hi Michal,

    Le 27/04/2018 ? 16:07, Micha? Kalbarczyk a ?crit?:
    > From adff41d0ec39d5e89ce713c88edb0ee6468c7236 Mon Sep 17 00:00:00 2001
    > From: =?UTF-8?q?Micha=C5=82=20Kalbarczyk?= <[email protected]
    <mailto:[email protected]>>
    > Date: Fri, 27 Apr 2018 15:49:15 +0200
    > Subject: [PATCH 1/1] package/mesa3d: add Radeon SI support
    > MIME-Version: 1.0
    > Content-Type: text/plain; charset=UTF-8
    > Content-Transfer-Encoding: 8bit

    Thanks for this contribution!
    I know it's too late since the patch is already applied but here is my review.

    > Signed-off-by: Micha? Kalbarczyk <[email protected]
    <mailto:[email protected]>>
    > ---
    >? package/mesa3d/Config.in | 20 ++++++++++++++++++++
    >? package/mesa3d/mesa3d.mk <http://mesa3d.mk> |? 1 +
    >? 2 files changed, 21 insertions(+)
    >
    > diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
    > index bd3d050e29..cbaa20370f 100644
    > --- a/package/mesa3d/Config.in
    > +++ b/package/mesa3d/Config.in
    > @@ -108,6 +108,26 @@ config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600
    >? ? ? ?help
    >? ? ? ? ?Driver for ATI/AMD Radeon R600/R700/HD5000/HD6000 GPUs.
    >
    > +config BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI
    > +? ? ?bool "Gallium Radeon SI driver"
    > +? ? ?depends on BR2_i386 || BR2_x86_64
    > +? ? ?depends on !BR2_PACKAGE_MESA3D_LLVM || \

    The RadeonSI support require LLVM.

    checking for AMDGPU... yes
    configure: error: --enable-llvm is required when building radeonsi

    > +? ? ? ? ? ? ?(BR2_PACKAGE_MESA3D_LLVM && (BR2_TOOLCHAIN_USES_UCLIBC || \
    > +? ? ? ? ? ? ? ? ? ? ?BR2_TOOLCHAIN_USES_GLIBC)) # elfutils
    > +? ? ?select BR2_PACKAGE_MESA3D_GALLIUM_DRIVER
    > +? ? ?select BR2_PACKAGE_LIBDRM_AMDGPU

    In my previous review, mesa is checking for libdrm-amdgpu and libdrm-radeon [1]

    checking for EXPAT... yes
    checking for RADEON... no
    configure: error: Package requirements (libdrm >= 2.4.71 libdrm_radeon >=
    2.4.71)

    > +? ? ?select BR2_PACKAGE_LLVM_AMDGPU if BR2_PACKAGE_MESA3D_LLVM
    > +? ? ?select BR2_PACKAGE_ELFUTILS if BR2_PACKAGE_MESA3D_LLVM
    > +? ? ?select BR2_PACKAGE_MESA3D_NEEDS_XA
    > +? ? ?help
    > +? ? ? ?Driver for ATI/AMD Radeon HD7000/HD8000/Rx200 GPUs.
    > +
    > +# Radeon SI needs libelf when Mesa3D is built with LLVM support
    > +# musl is not currently compatible with elfutils
    > +comment "Radeon SI driver needs a uClibc or glibc toolchain when llvm is
    enabled"
    > +? ? ?depends on BR2_PACKAGE_MESA3D_LLVM
    > +? ? ?depends on !(BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_GLIBC)

    The comment should be updated accordingly since llvm is mandatory.

    Best regards,
    Romain

    [1] http://lists.busybox.net/pipermail/buildroot/2018-April/219308.html

    > +
    >? # R600 needs libelf when Mesa3D is built with LLVM support
    >? # musl is not currently compatible with elfutils
    >? comment "R600 driver needs a uClibc or glibc toolchain when llvm is enabled"
    > diff --git a/package/mesa3d/mesa3d.mk <http://mesa3d.mk>
    b/package/mesa3d/mesa3d.mk <http://mesa3d.mk>
    > index e93490c042..9857b597cf 100644
    > --- a/package/mesa3d/mesa3d.mk <http://mesa3d.mk>
    > +++ b/package/mesa3d/mesa3d.mk <http://mesa3d.mk>
    > @@ -80,6 +80,7 @@ endif
    >? MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV)? +=
    etnaviv imx
    >? MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_NOUVEAU)? +=
    nouveau
    >? MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600)? ? ?+= r600
    > +MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI) +=
    radeonsi
    >? MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SVGA)? ? ?+= svga
    >? MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST)? ?+=
    swrast
    >? MESA3D_GALLIUM_DRIVERS-$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_VC4)? ? ? += vc4
    > --
    > 2.17.0
    >