Skip to contentSkip to conversation

package/mesa3d: add missing elfutils dependency with R600 driver

PATCH New Romain Naour 2 participants 3 messages Apr 28, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/mesa3d: add missing elfutils dependency with R600 driver

Commit "add dependency on elfutils for R600 with LLVM" [1] select elfutils package at Kconfig level without adding it the make dependency.

Enabling r600 support lead to a build issue when building from scratch with "make mesa3d":
checking for RADEON... yes
configure: error: r600 requires libelf when using llvm

elfutils dependency is needed by r600 with llvm support and radeonSI.

[1] 92fda8761aa8024be53a8edb8c102d1ba6401bce

Cc Valentin Korenblit <[email protected]>
---
 package/mesa3d/mesa3d.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/mesa3d/mesa3d.mk +4 -0
index 9857b597cf..2529c7d8e6 100644
@@ -38,6 +38,10 @@ MESA3D_CONF_OPTS += \
 	--with-llvm-prefix=$(STAGING_DIR)/usr \
 	--enable-llvm-shared-libs \
 	--enable-llvm
+# R600 needs libelf when Mesa3D is built with LLVM support
+ifneq ($(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600),)
+MESA3D_DEPENDENCIES += elfutils
+endif
 else
 # Avoid automatic search of llvm-config
 MESA3D_CONF_OPTS += --disable-llvm
Signature · 1 line
2.14.3
#1 lore raw

PATCH 2/2 package/mesa3d: add missing elfutils dependency with RadeonSI driver

RadeonSI needs LLVM support which require elfutils dependency.

Fixes:
checking for RADEON... yes
checking for AMDGPU... yes
configure: error: radeonsi requires libelf when using llvm

Cc Valentin Korenblit <[email protected]>
Cc Micha? Kalbarczyk <[email protected]>
---
 package/mesa3d/mesa3d.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/mesa3d/mesa3d.mk +2 -1
index 2529c7d8e6..3aac0c19b8 100644
@@ -39,7 +39,8 @@ MESA3D_CONF_OPTS += \
 	--enable-llvm-shared-libs \
 	--enable-llvm
 # R600 needs libelf when Mesa3D is built with LLVM support
-ifneq ($(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600),)
+# RadeonSI needs libelf
+ifneq ($(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_R600)$(BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_RADEONSI),)
 MESA3D_DEPENDENCIES += elfutils
 endif
 else
Signature · 1 line
2.14.3
#2 lore raw

PATCH 1/2 package/mesa3d: add missing elfutils dependency with R600 driver

In reply to Romain Naour

Hello,

Quoted 8 lines · Romain Naour

Commit "add dependency on elfutils for R600 with LLVM" [1] select elfutils package at Kconfig level without adding it the make dependency.

Enabling r600 support lead to a build issue when building from scratch with "make mesa3d":
checking for RADEON... yes
configure: error: r600 requires libelf when using llvm

Quoted 6 lines

elfutils dependency is needed by r600 with llvm support and radeonSI.

[1] 92fda8761aa8024be53a8edb8c102d1ba6401bce

Cc Valentin Korenblit <[email protected]>

Perhaps introduce a BR2_PACKAGE_MESA3D_NEEDS_ELFUTILS hidden Config.in boolean, select it from the right drivers, and use that in the .mk file ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com