Skip to contentSkip to conversation

MAINTAINERS: add myself as maintainer of AFFS

PATCH In review David Sterba 3 participants 3 messages Apr 28, 2018

lore
Share & tools
lore

David Sterba

author
#0 lore raw

PATCH 1/1 MAINTAINERS: add myself as maintainer of AFFS

The AFFS filesystem is still in use by m68k community (Link #2), but as there was no code activity and no maintainer, the filesystem appeared on the list of candidates for staging/removal (Link #1).

I volunteer to act as a maintainer of AFFS to collect any fixes that might show up and to guard fs/affs/ against another spring cleaning.

Link https://lkml.kernel.org/r/[email protected] open here
Link https://lkml.kernel.org/r/1613268.lKBQxPXt8J@merkaba open here
CC Martin Steigerwald <[email protected]>
CC John Paul Adrian Glaubitz <[email protected]>
Signed-off-by David Sterba <[email protected]>
---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
MAINTAINERS +2 -1
index dd66ae9a847e..9d268895bd56 100644
@@ -564,8 +564,10 @@ S:	Maintained
 F:	drivers/media/dvb-frontends/af9033*
 
 AFFS FILE SYSTEM
+M:	David Sterba <[email protected]>
 L:	[email protected]
-S:	Orphan
+S:	Odd Fixes
 F:	Documentation/filesystems/affs.txt
 F:	fs/affs/
Signature · 1 line
2.16.2
#1 lore raw
Quoted 2 lines · David Sterba

I volunteer to act as a maintainer of AFFS to collect any fixes that might show up and to guard fs/affs/ against another spring cleaning.

Hmm. Please be more careful.

Review S: Maintained

Quoted 1 line
(quoted diff) +0 -0
@@ -564,8 +564,10 @@ S: Maintained

The above says it adds two lines (8 -> 10), but the actual patch itself only adds one, and modifies another:

MAINTAINERS S: Maintained · line 569

Quoted 3 lines
MAINTAINERS +2 -1
+M:     David Sterba <[email protected]>
-S:     Orphan
+S:     Odd Fixes

I'm used to editing patches for things like this, because I have years and years of just hand-editing patches I didn't like for some reason, but it looks like you tried to edit a patch without knowing all the rules for how unified patches work.

So please don't edit patches by hand. It's a skill nobody should have.

Anyway, I fixed the patch and applied it, but let's not make a habit of it.

Linus

#2 lore raw
Quoted 21 lines · Linus Torvalds
Quoted 2 lines · David Sterba

I volunteer to act as a maintainer of AFFS to collect any fixes that might show up and to guard fs/affs/ against another spring cleaning.

Hmm. Please be more careful.

Review S: Maintained

Quoted 1 line
(quoted diff) +0 -0
@@ -564,8 +564,10 @@ S: Maintained

The above says it adds two lines (8 -> 10), but the actual patch itself only adds one, and modifies another:

MAINTAINERS S: Maintained · line 569

Quoted 3 lines
MAINTAINERS +2 -1
+M:     David Sterba <[email protected]>
-S:     Orphan
+S:     Odd Fixes

I'm used to editing patches for things like this, because I have years and years of just hand-editing patches I didn't like for some reason, but it looks like you tried to edit a patch without knowing all the rules for how unified patches work.

Quoted 3 lines

So please don't edit patches by hand. It's a skill nobody should have.

Anyway, I fixed the patch and applied it, but let's not make a habit of it.

Sorry, it was a last minute change. There was a T: line with a git tree reference, but this looked odd and I deleted it, but did not realize the patch would not apply. Too excited to send it.