Skip to contentSkip to conversation

libcrossguid: bump to version 0.2.2

PATCH New Fabrice Fontaine 3 participants 3 messages Apr 28, 2018 – Apr 29, 2018

lore
Share & tools
lore

Fabrice Fontaine

author
#0 lore raw

PATCH 1/1 libcrossguid: bump to version 0.2.2

- Add hash for license file
- guid.cpp and guid.h have been renamed Guid.cpp and Guid.hpp (they
will be renamed back to guid.cpp and guid.hpp in next release)
- Continue to use package-generic infrastructure as cmake doesn't work
properly with this version. Commit such as https://github.com/graeme-hill/crossguid/commit/974def4e0ad62b8fea17d6dee7c4f9b0d65eaa2c is needed. Migration on cmake should be done in next package release.

Signed-off-by Fabrice Fontaine <[email protected]>
---
 package/libcrossguid/libcrossguid.hash | 3 ++-
 package/libcrossguid/libcrossguid.mk   | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)
package/libcrossguid/libcrossguid.hash +2 -1
index a991da56a0..08791947ce 100644
@@ -1,2 +1,3 @@
 # Locally calculated
-sha256 022c9f02cc36e865cd8fd0111a597ff2bd91988deeb348dbe2aba64aed1abd99  libcrossguid-8f399e8bd4252be9952f3dfa8199924cc8487ca4.tar.gz
+sha256 48321928473c682b0cdc7e17bbd3390f79f4b98ab22fef3b81a852dda81fd195  libcrossguid-v0.2.2.tar.gz
+sha256 779e58787f966a1552f68d5ec041513cef68785dae4a519dbda7bc0b86eda20e  LICENSE
package/libcrossguid/libcrossguid.mk +3 -3
index 46d9a9dcc6..46daaec206 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBCROSSGUID_VERSION = 8f399e8bd4252be9952f3dfa8199924cc8487ca4
+LIBCROSSGUID_VERSION = v0.2.2
 LIBCROSSGUID_SITE = $(call github,graeme-hill,crossguid,$(LIBCROSSGUID_VERSION))
 LIBCROSSGUID_LICENSE = MIT
 LIBCROSSGUID_LICENSE_FILES = LICENSE

@@ -15,14 +15,14 @@ LIBCROSSGUID_DEPENDENCIES = util-linux
 
 define LIBCROSSGUID_BUILD_CMDS
 	(cd $(@D); $(TARGET_CXX) $(TARGET_CXXFLAGS) -std=c++11 -DGUID_LIBUUID \
-		-c guid.cpp -o guid.o)
+		-c Guid.cpp -o guid.o)
 	(cd $(@D); $(TARGET_AR) rvs libcrossguid.a guid.o)
 endef
 
 define LIBCROSSGUID_INSTALL_STAGING_CMDS
 	$(INSTALL) -D -m 644 $(@D)/libcrossguid.a \
 		$(STAGING_DIR)/usr/lib/libcrossguid.a
-	$(INSTALL) -D -m 644 $(@D)/guid.h $(STAGING_DIR)/usr/include/guid.h
+	$(INSTALL) -D -m 644 $(@D)/Guid.hpp $(STAGING_DIR)/usr/include/guid.h
 endef
 
 $(eval $(generic-package))
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 libcrossguid: bump to version 0.2.2

Hello,

Quoted 5 lines · Fabrice Fontaine

- Add hash for license file
- guid.cpp and guid.h have been renamed Guid.cpp and Guid.hpp (they
will be renamed back to guid.cpp and guid.hpp in next release)
- Continue to use package-generic infrastructure as cmake doesn't work
properly with this version. Commit such as https://github.com/graeme-hill/crossguid/commit/974def4e0ad62b8fea17d6dee7c4f9b0d65eaa2c is needed. Migration on cmake should be done in next package release.

The formatting of the commit log is not really great. Bullets in the list are not aligned, and it's not wrapped to 72 characters. I've fixed that and applied. Thanks!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 libcrossguid: bump to version 0.2.2

In reply to Fabrice Fontaine

Am Sat, 28 Apr 2018 22:00:43 +0200 schrieb Fabrice Fontaine:

package/libcrossguid/libcrossguid.mk line 7

Quoted 2 lines
package/libcrossguid/libcrossguid.mk +1 -1
-LIBCROSSGUID_VERSION = 8f399e8bd4252be9952f3dfa8199924cc8487ca4
+LIBCROSSGUID_VERSION = v0.2.2

Hi,

building the only package depending on libcrossguid, Kodi, breaks due to this bump:

/home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/utils/ StringUtils.cpp: In static member function ?static std::__cxx11::string StringUtils::CreateUUID()?:
/home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/utils/ StringUtils.cpp:1194:10: error: ?GuidGenerator? does not name a type

   static GuidGenerator guidGenerator;
          ^~~~~~~~~~~~~
/home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/utils/
StringUtils.cpp:1195:15: error: ?guidGenerator? was not declared in this 
scope
   auto guid = guidGenerator.newGuid();
               ^~~~~~~~~~~~~

This happens due to changes in libcrossguid:
https://github.com/graeme-hill/crossguid/blob/master/README.md

"This is version 0.2 of CrossGuid. If you all already using CrossGuid and your code uses GuidGenerator then you are using version 0.1."

Even Kodi master branch has no support for libcrossguid-0.2.x yet so I vote for reverting this bump.

Regards, bernd