Skip to contentSkip to conversation

usb: musb: host: fix potential NULL pointer dereference

PATCH New Greg Kroah-Hartman 1 participant 1 message Apr 30, 2018

Subsystems (2)
Stable branch USB
lore
Share & tools
lore

Greg Kroah-Hartman

author maintainer
#0 lore raw

PATCH 1/2 usb: musb: host: fix potential NULL pointer dereference

Quoted 8 lines · Bin Liu

musb_start_urb() doesn't check the pass-in parameter if it is NULL. But in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is returned from first_qh(), which could be NULL.

So wrap the musb_start_urb() call here with a if condition check to avoid the potential NULL pointer dereference.

Fixes f283862f3b5cb("usb: musb: NAK timeout scheme on bulk TX endpoint")

Nit, you forgot a ' ', this should be:
f283862f3b5c ("usb: musb: NAK timeout scheme on bulk TX endpoint")

You also had one extra id value in there, odd. I'll edit this by hand...

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html