net: core: Inline netdev_features_size_check()
Subsystems (2)
PATCH 1/1 net: core: Inline netdev_features_size_check()
We do not require this inline function to be used in multiple different locations, just inline it where it gets used in register_netdevice().
Suggested-by David Miller <[email protected]>
Suggested-by Stephen Hemminger <[email protected]>
Signed-off-by Florian Fainelli <[email protected]>
--- include/linux/netdevice.h | 6 ------ net/core/dev.c | 3 ++- 2 files changed, 2 insertions(+), 7 deletions(-)
include/linux/netdevice.h +0 -6
@@ -4108,12 +4108,6 @@ const char *netdev_drivername(const struct net_device *dev);void linkwatch_run_queue (void ); -static inline void netdev_features_size_check (void ) -{ -BUILD_BUG_ON (sizeof (netdev_features_t) *BITS_PER_BYTE < -NETDEV_FEATURE_COUNT ); -} -static inline netdev_features_t netdev_intersect_features (netdev_features_t f1,netdev_features_t f2) {
net/core/dev.c +2 -1
@@ -7879,7 +7879,8 @@ int register_netdevice(struct net_device *dev)int ret;struct net *net =dev_net (dev); -netdev_features_size_check (); +BUILD_BUG_ON (sizeof (netdev_features_t) *BITS_PER_BYTE < +NETDEV_FEATURE_COUNT );BUG_ON (dev_boot_phase);ASSERT_RTNL ();
Signature · 1 line
2.14.1
David Miller
maintainerFrom: Florian Fainelli <[email protected]>
Date: Mon, 30 Apr 2018 14:20:05 -0700
Quoted 6 lines
We do not require this inline function to be used in multiple different locations, just inline it where it gets used in
register_netdevice().Suggested-by David Miller <[email protected]>Suggested-by Stephen Hemminger <[email protected]>Signed-off-by Florian Fainelli <[email protected]>
Yeah that looks a lot better, applied, thanks Florian.