gstreamer1: bump to 1.14.0

PATCH New Adam Duskett 2 participants 13 messages May 1, 2018 – May 3, 2018 Arm i.MX and Layerscape

lore

Share & tools

lore

Adam Duskett

author

2018-05-01 13:46 UTC #0 lore raw

PATCH v5 1/9 gstreamer1: bump to 1.14.0

Also add hash for license file.

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v5:
- none

 package/gstreamer1/gstreamer1/gstreamer1.hash | 5 +++--
 package/gstreamer1/gstreamer1/gstreamer1.mk   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

package/gstreamer1/gstreamer1/gstreamer1.hash +3 -2

index f8af907562..05b1d9d26c 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.12.4.tar.xz.sha256sum
-sha256 5a8704aa4c2eeb04da192c4a9942f94f860ac1a585de90d9f914bac26a970674 gstreamer-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-1.14.0.tar.xz.sha256sum
+sha256 fc361367f0d4b780a868a8833f9f30b9c9f4ac9faea4e6b251db8b4b0398466e gstreamer-1.14.0.tar.xz
+sha256 f445dc78b88496f7e20c7a2a461b95baba5865c8919b8289ac24ac0a80c6ce7a COPYING

package/gstreamer1/gstreamer1/gstreamer1.mk +1 -1

index ea9f29a4f3..d30f28594b 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GSTREAMER1_VERSION = 1.12.4
+GSTREAMER1_VERSION = 1.14.0
 GSTREAMER1_SOURCE = gstreamer-$(GSTREAMER1_VERSION).tar.xz
 GSTREAMER1_SITE = https://gstreamer.freedesktop.org/src/gstreamer
 GSTREAMER1_INSTALL_STAGING = YES

Signature · 1 line

2.14.3

Adam Duskett

author

2018-05-01 13:46 UTC #1 lore raw

PATCH v5 2/9 gst1-plugins-${base, good, bad, ugly}: bump to 1.14.0

These are grouped together because several plugins have been re-arranged and there is no way to individually update each plugin package.

Changes:

Add the following to gst1-plugins-base and remove them from plugins-bad:
- opengl
- gles2
- glx
- egl
- x11
- dispmanx
- audiomixer

Add the following to plugins-good and remove them from plugins-ugly:
- lame
- mpg123

moved --disable-qt from plugins-bad to plugins-good

Also add hashes for the license files.

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v2:
- moved --disable-qt from plugins-bad to plugins-good (martin)

Changes v2 -> v3:
- Removed wayland references from plugins-bad (Peter)
- Added missing BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOMIXER to plugins-base (Peter)
- Updated commit message with --disable-qt explination (Martin)

Changes v3 -> v4:
- Readded missing --disable-qt option to gst1-plugins-good (Martin)

Changes v4 -> v5:
- changed patch series name to gst1-plugins- (Thomas)
- Squashed https://patchwork.ozlabs.org/patch/897797/ into the series.

    (Peter)
  - Squashed https://patchwork.ozlabs.org/patch/897796/ into the series.
    (Peter)

- Re-added wayland option to gst1-plugins-bad (Peter)

 package/gstreamer1/gst1-plugins-bad/Config.in      | 139 +--------------------
 .../gst1-plugins-bad/gst1-plugins-bad.hash         |   5 +-
 .../gst1-plugins-bad/gst1-plugins-bad.mk           |  52 +-------
 package/gstreamer1/gst1-plugins-base/Config.in     | 130 +++++++++++++++++++
 .../gst1-plugins-base/gst1-plugins-base.hash       |   5 +-
 .../gst1-plugins-base/gst1-plugins-base.mk         |  63 +++++++++-
 package/gstreamer1/gst1-plugins-good/Config.in     |  12 ++
 .../gst1-plugins-good/gst1-plugins-good.hash       |   5 +-
 .../gst1-plugins-good/gst1-plugins-good.mk         |  20 ++-
 .../gst1-plugins-ugly/gst1-plugins-ugly.hash       |   5 +-
 .../gst1-plugins-ugly/gst1-plugins-ugly.mk         |  16 +--
 11 files changed, 239 insertions(+), 213 deletions(-)

package/gstreamer1/gst1-plugins-bad/Config.in +3 ~~-136~~

index 7e166e43a1..a2ceeb9035 100644
@@ -9,134 +9,6 @@ menuconfig BR2_PACKAGE_GST1_PLUGINS_BAD
 
 if BR2_PACKAGE_GST1_PLUGINS_BAD
 
-comment "libraries with external dependencies"
-
-menuconfig BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL
-	bool "opengl"
-	depends on BR2_PACKAGE_HAS_LIBGL || BR2_PACKAGE_HAS_LIBGLES
-
-if BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_HAS_LIB_OPENGL
-	def_bool BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_WINDOW
-
-comment "The opengl library needs an API, a platform and a window system"
-	depends on !BR2_PACKAGE_GST1_PLUGINS_BAD_HAS_LIB_OPENGL
-
-comment "APIs"
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_API
-	bool
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_OPENGL
-	bool "opengl"
-	default y
-	depends on BR2_PACKAGE_HAS_LIBGL
-	select BR2_PACKAGE_LIBGLU
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_API
-
-comment "opengl needs an OpenGL backend"
-	depends on !BR2_PACKAGE_HAS_LIBGL
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_GLES2
-	bool "gles2"
-	default y
-	depends on BR2_PACKAGE_HAS_LIBGLES
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_API
-
-comment "gles2 needs an OpenGL ES backend"
-	depends on !BR2_PACKAGE_HAS_LIBGLES
-
-comment "Platforms"
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_PLATFORM
-	bool
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_GLX
-	bool "glx"
-	default y
-	depends on BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_OPENGL
-	depends on BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR # mesa needs big X
-	depends on !BR2_PACKAGE_RPI_USERLAND # x11
-	select BR2_PACKAGE_XLIB_LIBXRENDER
-	select BR2_PACKAGE_XPROTO_GLPROTO
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_X11
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_PLATFORM
-	help
-	  OpenGL Extension to the X Window System
-
-comment "glx not supported with rpi-userland"
-	depends on BR2_PACKAGE_RPI_USERLAND
-
-comment "glx needs the opengl API and modular X.org"
-	depends on !BR2_PACKAGE_RPI_USERLAND && \
-		(!BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_OPENGL || \
-		!BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR)
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_EGL
-	bool "egl"
-	default y
-	depends on BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_API
-	depends on BR2_PACKAGE_HAS_LIBEGL
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_PLATFORM
-
-comment "egl needs an API and an EGL backend"
-	depends on !BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_API || \
-		!BR2_PACKAGE_HAS_LIBEGL
-
-comment "Window systems"
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_WINDOW
-	bool
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_X11
-	bool "x11"
-	default y
-	depends on BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_PLATFORM
-	depends on !BR2_PACKAGE_RPI_USERLAND
-	depends on BR2_PACKAGE_XORG7
-	select BR2_PACKAGE_XLIB_LIBX11
-	select BR2_PACKAGE_XLIB_LIBXEXT
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_WINDOW
-
-comment "x11 not supported with rpi-userland"
-	depends on BR2_PACKAGE_RPI_USERLAND
-
-comment "x11 needs a platform and X.org"
-	depends on !BR2_PACKAGE_RPI_USERLAND && \
-		(!BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_PLATFORM || \
-		!BR2_PACKAGE_XORG7)
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_WAYLAND
-	bool "wayland"
-	default y
-	depends on BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_EGL
-	depends on BR2_PACKAGE_WAYLAND
-	select BR2_PACKAGE_WAYLAND_PROTOCOLS
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_WINDOW
-
-comment "wayland needs the egl platform and the wayland package"
-	depends on !BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_EGL || \
-		!BR2_PACKAGE_WAYLAND
-
-config BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_DISPMANX
-	bool "dispmanx"
-	default y
-	depends on BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_EGL
-	depends on BR2_PACKAGE_RPI_USERLAND
-	select BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_HAS_WINDOW
-	help
-	  Raspberry Pi's Dispmanx windowing system
-
-comment "dispmanx needs the egl platform and rpi-userland"
-	depends on !BR2_PACKAGE_GST1_PLUGINS_BAD_LIB_OPENGL_EGL || \
-		!BR2_PACKAGE_RPI_USERLAND
-
-endif
-
-comment "opengl needs an OpenGL or OpenGL ES backend"
-	depends on !BR2_PACKAGE_HAS_LIBGL && !BR2_PACKAGE_HAS_LIBGLES
-
 comment "dependency-less plugins"
 
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_ACCURIP

@@ -174,11 +46,6 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_AUDIOFXBAD
 	help
 	  Audio filters plugin
 
-config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_AUDIOMIXER
-	bool "audiomixer"
-	help
-	  Audio mixer plugin
-
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_AUDIOMIXMATRIX
 	bool "audiomixmatrix"
 	help

@@ -513,10 +380,10 @@ comment "fdk-aac needs a toolchain w/ C++"
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
 	bool "gl"
 	default y
-	depends on BR2_PACKAGE_GST1_PLUGINS_BAD_HAS_LIB_OPENGL
+	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
 
-comment "gl needs the gst1-plugins-bad opengl library"
-	depends on !BR2_PACKAGE_GST1_PLUGINS_BAD_HAS_LIB_OPENGL
+comment "gl needs the gst1-plugins-base opengl library"
+	depends on !BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
 
 config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_HLS
 	bool "hls"

package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.hash +3 -2

index 752d50a56d..420b780903 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gst-plugins-bad/gst-plugins-bad-1.12.4.tar.xz.sha256sum
-sha256 0c7857be16686d5c1ba6e34bd338664d3d4599d32714a8eca5c8a41a101e2d08 gst-plugins-bad-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gst-plugins-bad/gst-plugins-bad-1.14.0.tar.xz.sha256sum
+sha256 ed5e2badb6f2858f60017b93334d91fe58a0e3f85ed2f37f2e931416fafb4f9f gst-plugins-bad-1.14.0.tar.xz
+sha256 0b12e4d1cd5db5f8a0c04fc98a1d8c3acc533097b6198d6644420da78d460223 COPYING

package/gstreamer1/gst1-plugins-bad/gst1-plugins-bad.mk +3 ~~-49~~

76 lines not on this page · raw message

package/gstreamer1/gst1-plugins-base/Config.in +130 -0

142 lines not on this page · raw message

package/gstreamer1/gst1-plugins-base/gst1-plugins-base.hash +3 -2

index b935f2f6dc..bfa61780fb 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-1.12.4.tar.xz.sha256sum
-sha256 4c306b03df0212f1b8903784e29bb3493319ba19ebebf13b0c56a17870292282 gst-plugins-base-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-1.14.0.tar.xz.sha256sum
+sha256 7e904660ff56e02b036cf7fdfb77a50a540828ca9d2614d69ba931772e5b6940 gst-plugins-base-1.14.0.tar.xz
+sha256 78fb5977f177ab71cba77a4a127d29b93cb1ca5c25962204b31f183a20cf5c7a COPYING

package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk +60 -3

86 lines not on this page · raw message

package/gstreamer1/gst1-plugins-good/Config.in +12 -0

index eea3a3eda8..3bb98a4308 100644
@@ -261,6 +261,18 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_Y4M
 
 comment "plugins with external dependencies"
 
+config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_LAME
+	bool "lame (*.mp3 audio encoder)"
+	select BR2_PACKAGE_LAME
+	help
+	  Encode MP3s with LAME
+
+config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MPG123
+	bool "mpg123 (*.mp3 audio)"
+	select BR2_PACKAGE_MPG123
+	help
+	  mp3 decoding based on the mpg123 library
+
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_OSS
 	bool "ossaudio (OSS audio)"
 	help

package/gstreamer1/gst1-plugins-good/gst1-plugins-good.hash +3 -2

index c6f6138154..999e2883cd 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-1.12.4.tar.xz.sha256sum
-sha256 649f49bec60892d47ee6731b92266974c723554da1c6649f21296097715eb957 gst-plugins-good-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-1.14.0.tar.xz.sha256sum
+sha256 6afa35747d528d3ab4ed8f5eac13f7235d7d28100d6a24dd78f81ec7c0d04688 gst-plugins-good-1.14.0.tar.xz
+sha256 6095e9ffa777dd22839f7801aa845b31c9ed07f3d6bf8a26dc5d2dec8ccc0ef3 COPYING

package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk +18 -2

index 53e2341586..3a1c08e5c1 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_PLUGINS_GOOD_VERSION = 1.12.4
+GST1_PLUGINS_GOOD_VERSION = 1.14.0
 GST1_PLUGINS_GOOD_SOURCE = gst-plugins-good-$(GST1_PLUGINS_GOOD_VERSION).tar.xz
 GST1_PLUGINS_GOOD_SITE = https://gstreamer.freedesktop.org/src/gst-plugins-good
 GST1_PLUGINS_GOOD_LICENSE_FILES = COPYING

@@ -20,7 +20,8 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \
 	--disable-osx_video \
 	--disable-aalib \
 	--disable-aalibtest \
-	--disable-libcaca
+	--disable-libcaca \
+	--disable-qt
 
 # Options which require currently unpackaged libraries
 GST1_PLUGINS_GOOD_CONF_OPTS += \

@@ -175,6 +176,21 @@ else
 GST1_PLUGINS_GOOD_CONF_OPTS += --disable-isomp4
 endif
 
+ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_LAME),y)
+GST1_PLUGINS_GOOD_CONF_OPTS += --enable-lame
+GST1_PLUGINS_GOOD_DEPENDENCIES += lame
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += --disable-lame
+endif
+
+ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MPG123),y)
+GST1_PLUGINS_GOOD_CONF_OPTS += --enable-mpg123
+GST1_PLUGINS_GOOD_DEPENDENCIES += mpg123
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += --disable-mpg123
+endif
+
+
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_LAW),y)
 GST1_PLUGINS_GOOD_CONF_OPTS += --enable-law
 else

package/gstreamer1/gst1-plugins-ugly/gst1-plugins-ugly.hash +3 -2

index d0581531d4..f942653af1 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-1.12.4.tar.xz.sha256sum
-sha256 1c165b8d888ed350acd8e6ac9f6fe06508e6fcc0a3afc6ccc9fbeb30df9be522 gst-plugins-ugly-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-1.14.0.tar.xz.sha256sum
+sha256 3fb9ea5fc8a2de4b3eaec4128d71c6a2d81dd19befe1cd87cb833b98bcb542d1 gst-plugins-ugly-1.14.0.tar.xz
+sha256 6095e9ffa777dd22839f7801aa845b31c9ed07f3d6bf8a26dc5d2dec8ccc0ef3 COPYING

package/gstreamer1/gst1-plugins-ugly/gst1-plugins-ugly.mk +1 ~~-15~~

index af02a560a8..ca50a790a6 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_PLUGINS_UGLY_VERSION = 1.12.4
+GST1_PLUGINS_UGLY_VERSION = 1.14.0
 GST1_PLUGINS_UGLY_SOURCE = gst-plugins-ugly-$(GST1_PLUGINS_UGLY_VERSION).tar.xz
 GST1_PLUGINS_UGLY_SITE = https://gstreamer.freedesktop.org/src/gst-plugins-ugly
 GST1_PLUGINS_UGLY_LICENSE_FILES = COPYING

@@ -70,20 +70,6 @@ else
 GST1_PLUGINS_UGLY_CONF_OPTS += --disable-dvdread
 endif
 
-ifeq ($(BR2_PACKAGE_GST1_PLUGINS_UGLY_PLUGIN_LAME),y)
-GST1_PLUGINS_UGLY_CONF_OPTS += --enable-lame
-GST1_PLUGINS_UGLY_DEPENDENCIES += lame
-else
-GST1_PLUGINS_UGLY_CONF_OPTS += --disable-lame
-endif
-
-ifeq ($(BR2_PACKAGE_GST1_PLUGINS_UGLY_PLUGIN_MPG123),y)
-GST1_PLUGINS_UGLY_CONF_OPTS += --enable-mpg123
-GST1_PLUGINS_UGLY_DEPENDENCIES += mpg123
-else
-GST1_PLUGINS_UGLY_CONF_OPTS += --disable-mpg123
-endif
-
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_UGLY_PLUGIN_MPEG2DEC),y)
 GST1_PLUGINS_UGLY_CONF_OPTS += --enable-mpeg2dec
 GST1_PLUGINS_UGLY_DEPENDENCIES += libmpeg2

Signature · 1 line

2.14.3

Thomas Petazzoni

2018-05-01 20:49 UTC #2 lore raw

PATCH v5 2/9 gst1-plugins-${base, good, bad, ugly}: bump to 1.14.0

Hello Adam,

Quoted 18 lines · Adam Duskett

These are grouped together because several plugins have been re-arranged and there is no way to individually update each plugin package.
Changes:
Add the following to gst1-plugins-base and remove them from plugins-bad:
- opengl
- gles2
- glx
- egl
- x11
- dispmanx
- audiomixer
Add the following to plugins-good and remove them from plugins-ugly:
- lame
- mpg123

Quoted 5 lines

moved --disable-qt from plugins-bad to plugins-good
Also add hashes for the license files.
Signed-off-by Adam Duskett <[email protected]>

There are two issues with this patch:

- You remove/rename a lot of options, but there is no Config.in.legacy handling for the options being removed/renamed.

- The lame and mpg123 support is moved from plugins-ugly to plugins-good, but the corresponding options are not removed from plugins-ugly/Config.in.

Could you fix those issues, re-adjust the authorship for PATCH 8/9 (you can do that with git commit --amend --author="..."), and send an updated version of this patch series ?

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Adam Duskett

author

2018-05-02 21:12 UTC #3 lore raw

PATCH v5 2/9 gst1-plugins-${base, good, bad, ugly}: bump to 1.14.0

Thomas; all

Quoted 4 lines · Thomas Petazzoni

Hello Adam,
Quoted 1 line · Adam Duskett
These are grouped together because several plugins have been

re-arranged and

Quoted 36 lines

Quoted 17 lines
there is no way to individually update each plugin package.
Changes:
Add the following to gst1-plugins-base and remove them from plugins-bad:
- opengl
- gles2
- glx
- egl
- x11
- dispmanx
- audiomixer
Add the following to plugins-good and remove them from plugins-ugly:
- lame
- mpg123
Quoted 5 lines
moved --disable-qt from plugins-bad to plugins-good
Also add hashes for the license files.
Signed-off-by Adam Duskett <[email protected]>
There are two issues with this patch:
- You remove/rename a lot of options, but there is no Config.in.legacy handling for the options being removed/renamed.
- The lame and mpg123 support is moved from plugins-ugly to plugins-good, but the corresponding options are not removed from plugins-ugly/Config.in.
Could you fix those issues, re-adjust the authorship for PATCH 8/9 (you can do that with git commit --amend --author="..."), and send an updated version of this patch series ?

Quoted 7 lines

Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

I am going to have to decline. I really don't want to sit here through possibly several more revisions of the patch series.
I have marked the series as rejected and anybody else is free to resubmit if they want.

Thanks

Adam

Thomas Petazzoni

2018-05-03 12:13 UTC #4 lore raw

PATCH v5 2/9 gst1-plugins-${base, good, bad, ugly}: bump to 1.14.0

Hello,

Quoted 9 lines · Adam Duskett

Quoted 8 lines
There are two issues with this patch:
- You remove/rename a lot of options, but there is no Config.in.legacy handling for the options being removed/renamed.
- The lame and mpg123 support is moved from plugins-ugly to plugins-good, but the corresponding options are not removed from plugins-ugly/Config.in.

Quoted 8 lines

Quoted 3 lines
Could you fix those issues, re-adjust the authorship for PATCH 8/9 (you can do that with git commit --amend --author="..."), and send an updated version of this patch series ?
I am going to have to decline. I really don't want to sit here through possibly several more revisions of the patch series.
I have marked the series as rejected and anybody else is free to resubmit if they want.

I'm not sure I understand your decision here. There are a few things that are obviously wrong in this v5 (lack of Config.in.legacy handling), which are trivial to fix, and just for that reason, you give up on the series ?

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Adam Duskett

author

2018-05-01 13:46 UTC #5 lore raw

PATCH v5 3/9 gst-omx: bump to 1.14.0

In reply to Adam Duskett

Also add hash for license file.

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v5:
- none

 package/gstreamer1/gst-omx/gst-omx.hash | 5 +++--
 package/gstreamer1/gst-omx/gst-omx.mk   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

package/gstreamer1/gst-omx/gst-omx.hash +3 -2

index c4f8b10bce..4df0583b44 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gst-omx/gst-omx-1.12.4.tar.xz.sha256sum
-sha256 a025fa24242ec868fe0ff1e66d806a1070bcbc7c14a987a89cdc3395d0d56d5f gst-omx-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gst-omx/gst-omx-1.14.0.tar.xz.sha256sum
+sha256 4d43c354087cb77924982943e34e0d47294b5570304db11fd8b268b53bcff693 gst-omx-1.14.0.tar.xz
+sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 COPYING

package/gstreamer1/gst-omx/gst-omx.mk +1 -1

index 68cb7f6696..81192eeca6 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST_OMX_VERSION = 1.12.4
+GST_OMX_VERSION = 1.14.0
 GST_OMX_SOURCE = gst-omx-$(GST_OMX_VERSION).tar.xz
 GST_OMX_SITE = https://gstreamer.freedesktop.org/src/gst-omx

Signature · 1 line

2.14.3

Adam Duskett

author

2018-05-01 13:46 UTC #6 lore raw

PATCH v5 4/9 gst1-rtsp-server: bump to 1.14.0

In reply to Adam Duskett

Also add hash for license file.

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v5:
- none

 package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.hash | 5 +++--
 package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.hash +3 -2

index 95c8eef832..239e44ccd3 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gst-rtsp-server/gst-rtsp-server-1.12.4.tar.xz.sha256sum
-sha256 7660112ebd59838f1054796b38109dcbe32f0a040e3a252a68a81055aeaa56a9 gst-rtsp-server-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gst-rtsp-server/gst-rtsp-server-1.14.0.tar.xz.sha256sum
+sha256 6b65a077bed815f6d3157ebea503cc9f3c32d289af2756b7ff7e3958744d9756 gst-rtsp-server-1.14.0.tar.xz
+sha256 f445dc78b88496f7e20c7a2a461b95baba5865c8919b8289ac24ac0a80c6ce7a COPYING

package/gstreamer1/gst1-rtsp-server/gst1-rtsp-server.mk +1 -1

index d6a82ee654..5edd8737c1 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_RTSP_SERVER_VERSION = 1.12.4
+GST1_RTSP_SERVER_VERSION = 1.14.0
 GST1_RTSP_SERVER_SOURCE = gst-rtsp-server-$(GST1_RTSP_SERVER_VERSION).tar.xz
 GST1_RTSP_SERVER_SITE = http://gstreamer.freedesktop.org/src/gst-rtsp-server
 GST1_RTSP_SERVER_LICENSE = LGPL-2.0+

Signature · 1 line

2.14.3

Adam Duskett

author

2018-05-01 13:46 UTC #7 lore raw

PATCH v5 5/9 gst1-vaapi: bump to 1.14.0

In reply to Adam Duskett

Also add hash for license file.

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v5:
- none

 package/gstreamer1/gst1-vaapi/gst1-vaapi.hash | 5 +++--
 package/gstreamer1/gst1-vaapi/gst1-vaapi.mk   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

package/gstreamer1/gst1-vaapi/gst1-vaapi.hash +3 -2

index 3eebc0afe7..0891ea9a18 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gstreamer-vaapi/gstreamer-vaapi-1.12.4.tar.xz.sha256sum
-sha256 1c2d77242e1f30c4d1394636cae9f6877228a017960fca96881e0080d8b6e9c9 gstreamer-vaapi-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gstreamer-vaapi/gstreamer-vaapi-1.14.0.tar.xz.sha256sum
+sha256 e4e31f085ef289bf1049398f641345979d20a1b11a80285744bba98504991df2 gstreamer-vaapi-1.14.0.tar.xz
+sha256 dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551 COPYING.LIB

package/gstreamer1/gst1-vaapi/gst1-vaapi.mk +1 -1

index 6b637416f5..1ee060a578 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_VAAPI_VERSION = 1.12.4
+GST1_VAAPI_VERSION = 1.14.0
 GST1_VAAPI_SITE = https://gstreamer.freedesktop.org/src/gstreamer-vaapi
 GST1_VAAPI_SOURCE = gstreamer-vaapi-$(GST1_VAAPI_VERSION).tar.xz
 GST1_VAAPI_LICENSE = LGPL-2.1+

Signature · 1 line

2.14.3

Adam Duskett

author

2018-05-01 13:46 UTC #8 lore raw

PATCH v5 6/9 gst1-libav: bump to 1.14.0

In reply to Adam Duskett

Also add hash for license file.

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v5:
- none

 package/gstreamer1/gst1-libav/gst1-libav.hash | 5 +++--
 package/gstreamer1/gst1-libav/gst1-libav.mk   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

package/gstreamer1/gst1-libav/gst1-libav.hash +3 -2

index f9a287c590..5889386bec 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gst-libav/gst-libav-1.12.4.tar.xz.sha256sum
-sha256 2a56aa5d2d8cd912f2bce17f174713d2c417ca298f1f9c28ee66d4aa1e1d9e62 gst-libav-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gst-libav/gst-libav-1.14.0.tar.xz.sha256sum
+sha256 fb134b4d3e054746ef8b922ff157b0c7903d1fdd910708a45add66954da7ef89 gst-libav-1.14.0.tar.xz
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 COPYING

package/gstreamer1/gst1-libav/gst1-libav.mk +1 -1

index 7450b759f1..91782eaa9a 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_LIBAV_VERSION = 1.12.4
+GST1_LIBAV_VERSION = 1.14.0
 GST1_LIBAV_SOURCE = gst-libav-$(GST1_LIBAV_VERSION).tar.xz
 GST1_LIBAV_SITE = https://gstreamer.freedesktop.org/src/gst-libav
 GST1_LIBAV_CONF_OPTS = --with-system-libav

Signature · 1 line

2.14.3

Adam Duskett

author

2018-05-01 13:46 UTC #9 lore raw

PATCH v5 7/9 gst1-validate: bump to 1.14.0

In reply to Adam Duskett

Also add hash for license file.

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v5:
- none

 package/gstreamer1/gst1-validate/gst1-validate.hash | 5 +++--
 package/gstreamer1/gst1-validate/gst1-validate.mk   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

package/gstreamer1/gst1-validate/gst1-validate.hash +3 -2

index 50bddd0a9f..370809730a 100644
@@ -1,2 +1,3 @@
-# From https://gstreamer.freedesktop.org/src/gst-validate/gst-validate-1.12.4.tar.xz.sha256sum
-sha256 f9da9dfe6e5d6f5ba3b38c5752b42d3f927715904942b405c2924d3cb77afba1 gst-validate-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gst-validate/gst-validate-1.14.0.tar.xz.sha256sum
+sha256 33df08bf77f2895d64b7e8a957de3b930b4da0a8edabfbefcff2eab027eeffdf gst-validate-1.14.0.tar.xz
+sha256 6095e9ffa777dd22839f7801aa845b31c9ed07f3d6bf8a26dc5d2dec8ccc0ef3 COPYING

package/gstreamer1/gst1-validate/gst1-validate.mk +1 -1

index d276490160..e1bd8839ee 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST1_VALIDATE_VERSION = 1.12.4
+GST1_VALIDATE_VERSION = 1.14.0
 GST1_VALIDATE_SOURCE = gst-validate-$(GST1_VALIDATE_VERSION).tar.xz
 GST1_VALIDATE_SITE = https://gstreamer.freedesktop.org/src/gst-validate
 GST1_VALIDATE_LICENSE = LGPL-2.1+

Signature · 1 line

2.14.3

Adam Duskett

author

2018-05-01 13:46 UTC #10 lore raw

PATCH v5 8/9 gstreamer1-editing-services: bump to 1.14.0

In reply to Adam Duskett

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v5:
- Added patch to series (Peter)

 .../gstreamer1-editing-services/gstreamer1-editing-services.hash      | 4 ++--
 .../gstreamer1-editing-services/gstreamer1-editing-services.mk        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

package/gstreamer1/gstreamer1-editing-services/gstreamer1-editing-services.hash +2 -2

index ddf9cecaed..78d1eea6c6 100644
@@ -1,5 +1,5 @@
-# From https://gstreamer.freedesktop.org/src/gstreamer-editing-services/gstreamer-editing-services-1.12.4.tar.xz.sha256sum
-sha256 bd7eaa2c9572db9e7e535064024b6f69250de864fe8a5d5be86fa8c7edacca0c  gstreamer-editing-services-1.12.4.tar.xz
+# From https://gstreamer.freedesktop.org/src/gstreamer-editing-services/gstreamer-editing-services-1.14.0.tar.xz.sha256sum
+sha256 8d5f90eb532f4cf4aa1466807ef92b05bd1705970d7aabe10066929bbc698d91 gstreamer-editing-services-1.14.0.tar.xz
 
 # Hashes for license files:
 sha256 f445dc78b88496f7e20c7a2a461b95baba5865c8919b8289ac24ac0a80c6ce7a COPYING

package/gstreamer1/gstreamer1-editing-services/gstreamer1-editing-services.mk +1 -1

index 9b5a93eb75..f5930d989e 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GSTREAMER1_EDITING_SERVICES_VERSION = 1.12.4
+GSTREAMER1_EDITING_SERVICES_VERSION = 1.14.0
 GSTREAMER1_EDITING_SERVICES_SOURCE = gstreamer-editing-services-$(GSTREAMER1_EDITING_SERVICES_VERSION).tar.xz
 GSTREAMER1_EDITING_SERVICES_SITE = http://gstreamer.freedesktop.org/src/gstreamer-editing-services
 GSTREAMER1_EDITING_SERVICES_LICENSE = LGPL-2.0+

Signature · 1 line

2.14.3

Adam Duskett

author

2018-05-01 14:02 UTC #11 lore raw

PATCH v5 8/9 gstreamer1-editing-services: bump to 1.14.0

All;

I sincerly appologize;
This is Peters patch merged into my series.
I am not trying to take credit for it, and it should have Peters name on it.

If you wish for me to re-submit the patch series let me know. If it can be modified before a merge, that would also work.

Thanks to Yann for the heads up on git-am! I will use that in the future.

Adam

Quoted 6 lines · Adam Duskett

Signed-off-by Adam Duskett <[email protected]>
---
Changes v1 -> v5:
- Added patch to series (Peter)
.../gstreamer1-editing-services/gstreamer1-editing-services.hash |

4 ++--

Quoted 1 line

.../gstreamer1-editing-services/gstreamer1-editing-services.mk |

2 +-

Quoted 3 lines

  2 files changed, 3 insertions(+), 3 deletions(-)

diff --git

a/package/gstreamer1/gstreamer1-editing-services/gstreamer1-editing-services.hash b/package/gstreamer1/gstreamer1-editing-services/gstreamer1-editing-services.hash

Quoted 2 lines

index ddf9cecaed..78d1eea6c6 100644
---

a/package/gstreamer1/gstreamer1-editing-services/gstreamer1-editing-services.hash

Quoted 1 line

+++

b/package/gstreamer1/gstreamer1-editing-services/gstreamer1-editing-services.hash

Review line 1

Quoted 2 lines

(quoted diff) +0 -1
@@ -1,5 +1,5 @@
-# From

https://gstreamer.freedesktop.org/src/gstreamer-editing-services/gstreamer-editing-services-1.12.4.tar.xz.sha256sum

Review line 2

Quoted 1 line

(quoted diff) +0 -1

-sha256 bd7eaa2c9572db9e7e535064024b6f69250de864fe8a5d5be86fa8c7edacca0c

gstreamer-editing-services-1.12.4.tar.xz

Review line 1

Quoted 1 line

(quoted diff) +1 -0
+# From

https://gstreamer.freedesktop.org/src/gstreamer-editing-services/gstreamer-editing-services-1.14.0.tar.xz.sha256sum

Review line 2

Quoted 1 line

(quoted diff) +1 -0

+sha256 8d5f90eb532f4cf4aa1466807ef92b05bd1705970d7aabe10066929bbc698d91

gstreamer-editing-services-1.14.0.tar.xz

Review line 4

Quoted 2 lines

(quoted diff) +0 -0

  # Hashes for license files:
  sha256 f445dc78b88496f7e20c7a2a461b95baba5865c8919b8289ac24ac0a80c6ce7a

COPYING

Review

Quoted 1 line

(quoted diff) +0 -0

gstreamer1-editing-services.mk
b/package/gstreamer1/gstreamer1-editing-services/
gstreamer1-editing-services.mk

Quoted 2 lines

index 9b5a93eb75..f5930d989e 100644
--- a/package/gstreamer1/gstreamer1-editing-services/

gstreamer1-editing-services.mk

Quoted 1 line

+++ b/package/gstreamer1/gstreamer1-editing-services/

gstreamer1-editing-services.mk

Review line 4

Quoted 2 lines

(quoted diff) +0 -0
@@ -4,7 +4,7 @@
  #

################################################################################

package/gstreamer1/gstreamer1-editing-services/gstreamer1-editing-services.mk

Quoted 3 lines

package/gstreamer1/gstreamer1-editing-services/gstreamer1-editing-services.mk +1 -1
-GSTREAMER1_EDITING_SERVICES_VERSION = 1.12.4
+GSTREAMER1_EDITING_SERVICES_VERSION = 1.14.0
  GSTREAMER1_EDITING_SERVICES_SOURCE =

gstreamer-editing-services-$(GSTREAMER1_EDITING_SERVICES_VERSION).tar.xz

Review line 7

Quoted 1 line

(quoted diff) +0 -0

  GSTREAMER1_EDITING_SERVICES_SITE =

http://gstreamer.freedesktop.org/src/gstreamer-editing-services

Quoted 3 lines

(quoted diff) +0 -1

  GSTREAMER1_EDITING_SERVICES_LICENSE = LGPL-2.0+
--

2.14.3

Adam Duskett

author

2018-05-01 13:46 UTC #12 lore raw

PATCH v5 9/9 gst1-imx: add hash for license file

In reply to Adam Duskett

Signed-off-by Adam Duskett <[email protected]>

---
Changes v1 -> v5:
- none

 package/gstreamer1/gst1-imx/gst1-imx.hash | 1 +
 1 file changed, 1 insertion(+)

package/gstreamer1/gst1-imx/gst1-imx.hash +1 -0

index 58ff4be225..0ef01d71e9 100644
@@ -1,2 +1,3 @@
 # locally computed hash
 sha256 3fcf1046ab8c6c7cd94218f4d2bc31ad7b5efa8a6b8f9fd5d93dc182f98ce026  gst1-imx-0.13.0.tar.gz
+sha256 94b03f1a60a7fd5007149530626a895a6ef5a8b9342abfd56860c5f3956f5d23  LICENSE

Signature · 1 line

2.14.3