Skip to contentSkip to conversation

target/arm: Correct MPUIR PL setting in register_cp_regs_for_features()

PATCH In review Mathew Maidment 2 participants 3 messages May 1, 2018 – May 3, 2018

lore
Share & tools
lore
#0 lore raw

cover target/arm: Correct MPUIR PL setting in register_cp_regs_for_features()

Hey there! This is my first time sending a patch via a mailing list so hopefully I didn't bungle this up *too* badly.

Mat

Mathew Maidment (1):
target/arm: Correct MPUIR privilege level in
register_cp_regs_for_features()

 target/arm/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.15.1
#1 lore raw

PATCH 1/1 target/arm: Correct MPUIR privilege level in register_cp_regs_for_features() conditional case

The duplication of id_tlbtr_reginfo was unintentionally added within 3281af8114c6b8ead02f08b58e3c36895c1ea047 which should have been id_mpuir_reginfo.

---
 target/arm/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
target/arm/helper.c +1 -1
index 52a88e0297..0fef5d4d06 100644
@@ -5347,7 +5347,7 @@ void register_cp_regs_for_features(ARMCPU *cpu)
             for (r = id_cp_reginfo; r->type != ARM_CP_SENTINEL; r++) {
                 r->access = PL1_RW;
             }
-            id_tlbtr_reginfo.access = PL1_RW;
+            id_mpuir_reginfo.access = PL1_RW;
             id_tlbtr_reginfo.access = PL1_RW;
         }
         if (arm_feature(env, ARM_FEATURE_V8)) {
Signature · 1 line
2.15.1 (Apple Git-101)
#2 lore raw
In reply to Mathew Maidment
Quoted 11 lines · Mathew Maidment

Hey there! This is my first time sending a patch via a mailing list so hopefully I didn't bungle this up *too* badly.

Mat

Mathew Maidment (1):
target/arm: Correct MPUIR privilege level in
register_cp_regs_for_features()

 target/arm/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi -- thanks for this patch! It all looks good and I have added it to my target-arm.next queue. (I made a minor edit to the commit message to note that this bug only affected OMAP and StrongARM cores.)

-- PMM