Skip to contentSkip to conversation

1wire: family module autoload fails because of upper/lower case mismatch.

PATCH In review Ingo Flaschberger 3 participants 3 messages May 1, 2018 W1 dallas's 1-wire bus

lore
Share & tools
lore

Ingo Flaschberger

author
#0 lore raw

PATCH 1/1 1wire: family module autoload fails because of upper/lower case mismatch.

1wire family module autoload fails because of upper/lower case mismatch.

Signed-off-by Ingo Flaschberger <[email protected]>
Acked-by Evgeniy Polyakov <[email protected]>
Cc stable <[email protected]>

---
 drivers/w1/w1.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/w1/w1.c +0 -0
index ab0931e..aa458f2 100644
@@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev, struct w1_reg_num *rn)
 

	/* slave modules need to be loaded in a context with unlocked mutex */
	mutex_unlock(&dev->mutex);
-	request_module("w1-family-0x%02x", rn->family);
+	request_module("w1-family-0x%02X", rn->family);
	mutex_lock(&dev->mutex);

	spin_lock(&w1_flock);
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw

Hi Ingo

Sorry for late reply and because of forcing you to resend the patch, your changes are correct

01.05.2018, 17:10, "Ingo Flaschberger" <[email protected]>:

Quoted 4 lines

1wire family module autoload fails because of upper/lower case mismatch.

Signed-off-by Ingo Flaschberger <[email protected]>

Greg, please pull this patch into your tree.
Should it be stable material?

Acked-by Evgeniy Polyakov <[email protected]>
Quoted 21 lines

---
  drivers/w1/w1.c | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/w1/w1.c +0 -0
index ab0931e..aa458f2 100644
@@ -741,7 +741,7 @@ int w1_attach_slave_device(struct w1_master *dev,
 struct w1_reg_num *rn)
 
          /* slave modules need to be loaded in a context with unlocked

mutex */
         mutex_unlock(&dev->mutex);
-       request_module("w1-family-0x%02x", rn->family); +       request_module("w1-family-0x%02X", rn->family); mutex_lock(&dev->mutex);

         spin_lock(&w1_flock);
--
2.7.4

#2 lore raw
Quoted 4 lines · Evgeniy Polyakov

Hi Ingo

Sorry for late reply and because of forcing you to resend the patch, your changes are correct

Quoted 8 lines

01.05.2018, 17:10, "Ingo Flaschberger" <[email protected]>:

Quoted 4 lines

1wire family module autoload fails because of upper/lower case mismatch.

Signed-off-by Ingo Flaschberger <[email protected]>

Greg, please pull this patch into your tree.
Should it be stable material?

Looks like it, I'll queue it up to the proper place, thanks!

greg k-h