Skip to contentSkip to conversation

debugfs: Re-use kstrtobool_from_user()

PATCH New Andy Shevchenko 1 participant 1 message May 3, 2018 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 debugfs: Re-use kstrtobool_from_user()

Re-use kstrtobool_from_user() instead of open coded variant.

---
 fs/debugfs/file.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
fs/debugfs/file.c +2 -8
index 1f99678ff5d3..4fce1da7db23 100644
@@ -796,19 +796,13 @@ EXPORT_SYMBOL_GPL(debugfs_read_file_bool);
 ssize_t debugfs_write_file_bool(struct file *file, const char __user *user_buf,
 				size_t count, loff_t *ppos)
 {
-	char buf[32];
-	size_t buf_size;
 	bool bv;
 	int r;
 	bool *val = file->private_data;
 	struct dentry *dentry = F_DENTRY(file);
 
-	buf_size = min(count, (sizeof(buf)-1));
-	if (copy_from_user(buf, user_buf, buf_size))
-		return -EFAULT;
-
-	buf[buf_size] = '\0';
-	if (strtobool(buf, &bv) == 0) {
+	r = kstrtobool_from_user(user_buf, count, &bv);
+	if (!r) {
 		r = debugfs_file_get(dentry);
 		if (unlikely(r))
 			return r;
Signature · 1 line
2.17.0