drm: panel-orientation-quirks: Convert to use match_string() helper
Subsystems (2)
PATCH 1/1 drm: panel-orientation-quirks: Convert to use match_string() helper
The new helper returns index of the matching string in an array. We are going to use it here.
--- drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_panel_orientation_quirks.c +3 -4
@@ -172,10 +172,9 @@ int drm_get_panel_orientation_quirk(int width, int height)if (!bios_date)continue ; -for (i =0 ; data->bios_dates[i]; i++) { -if (!strcmp (data->bios_dates[i], bios_date)) -return data->orientation; - } + i =match_string (data->bios_dates,-1 , bios_date); +if (i >=0 ) +return data->orientation; }return DRM_MODE_PANEL_ORIENTATION_UNKNOWN ;
Signature · 6 lines
2.17.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines · Andy Shevchenko
The new helper returns index of the matching string in an array. We are going to use it here.
Signed-off-by Andy Shevchenko <[email protected]>
Quoted 25 lines
--- drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_panel_orientation_quirks.c +3
-4@@ -172,10 +172,9 @@ int drm_get_panel_orientation_quirk(int width, int height)if (!bios_date)continue ; -for (i =0 ; data->bios_dates[i]; i++) { -if (!strcmp (data->bios_dates[i], bios_date)) -return data->orientation; - } + i =match_string (data->bios_dates,-1 , bios_date); +if (i >=0 ) +return data->orientation; }return DRM_MODE_PANEL_ORIENTATION_UNKNOWN ;Signature · 1 line
2.17.0
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi,
Quoted 4 lines · Andy Shevchenko
The new helper returns index of the matching string in an array. We are going to use it here.
Signed-off-by Andy Shevchenko <[email protected]>
Thanks, LGTM:
Regards,
Hans
Quoted 13 lines
--- drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_panel_orientation_quirks.c +0
-0@@ -172,10 +172,9 @@ int drm_get_panel_orientation_quirk(int width, int height)if (!bios_date)continue ;
drivers/gpu/drm/drm_panel_orientation_quirks.c int drm_get_panel_orientation_quirk(int width, int height) · line 180
Quoted 10 lines
drivers/gpu/drm/drm_panel_orientation_quirks.c +3
-4-for (i =0 ; data->bios_dates[i]; i++) { -if (!strcmp (data->bios_dates[i], bios_date)) -return data->orientation; - } + i =match_string (data->bios_dates,-1 , bios_date); +if (i >=0 ) +return data->orientation; }return DRM_MODE_PANEL_ORIENTATION_UNKNOWN ;
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Sean Paul
AppliedQuoted 11 lines · Hans de Goede
Hi,
Quoted 4 lines · Andy Shevchenko
The new helper returns index of the matching string in an array. We are going to use it here.
Signed-off-by Andy Shevchenko <[email protected]>Thanks, LGTM:
Acked-by Hans de Goede <[email protected]>
Applied to drm-misc-next with Hans' Ack.
Thanks for the patch!
Sean
Quoted 28 lines
Regards,
Hans
Quoted 21 lines
--- drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_panel_orientation_quirks.c +3
-4@@ -172,10 +172,9 @@ int drm_get_panel_orientation_quirk(int width, int height)if (!bios_date)continue ; -for (i =0 ; data->bios_dates[i]; i++) { -if (!strcmp (data->bios_dates[i], bios_date)) -return data->orientation; - } + i =match_string (data->bios_dates,-1 , bios_date); +if (i >=0 ) +return data->orientation; }return DRM_MODE_PANEL_ORIENTATION_UNKNOWN ;
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel