Skip to contentSkip to conversation

ltp-testsuite: add --with-open-posix-testsuite

PATCH New Ciro Santilli 4 participants 5 messages May 3, 2018 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ltp-testsuite: add --with-open-posix-testsuite

The issues mentioned on the removed comments were resolved, tested in QEMU x86_64 and aarch64.

---
This patch supposes that the removed comments imply that a default --with-open-posix-testsuite
is desirable (and I confirm that it does not take unreasoble build time or disk space),
and that there is no generic way to add autotools configs to packages:
https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package

 package/ltp-testsuite/ltp-testsuite.mk | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
(quoted diff) +0 -0

b/package/ltp-testsuite/ltp-testsuite.mk
index c47f587836..4584ca45da 100644

package/ltp-testsuite/ltp-testsuite.mk +0 -0
@@ -9,17 +9,8 @@ LTP_TESTSUITE_SOURCE = ltp-full-$(LTP_TESTSUITE_VERSION).tar.xz
 LTP_TESTSUITE_SITE =

https://github.com/linux-test-project/ltp/releases/download/$(LTP_TESTSUITE_VERSION)
LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+ LTP_TESTSUITE_LICENSE_FILES = COPYING
-
-# Do not enable Open POSIX testsuite as it doesn't cross-compile -# properly: t0 program is built for the host machine. Notice that due -# to a bug, --without-open-posix-testsuite actually enables the test -# suite.
-# See https://github.com/linux-test-project/ltp/issues/143 (invalid -# autoconf test) and
-# https://github.com/linux-test-project/ltp/issues/144 (Open POSIX -# testsuite not cross-compiling).
LTP_TESTSUITE_CONF_OPTS += \
- --with-realtime-testsuite
+ --with-realtime-testsuite --with-open-posix-testsuite

ifeq ($(BR2_LINUX_KERNEL),y)
LTP_TESTSUITE_DEPENDENCIES += linux

Signature · 1 line
2.17.0

A message that is not in the archive (sent off-list or not yet received): CAFXrp_fe0s-a8F4Zh5h2gP5_krm_6vdqbd1E0MKL-3q8ENfJ6A@mail.gmail.com

#2 lore raw

PATCH 1/1 ltp-testsuite: add --with-open-posix-testsuite

Hi Ciro,

Quoted 1 line

Ah, learned about get-developers now :-)

Thanks for tip :)

Quoted 9 lines

---------- Forwarded message ----------
From: Ciro Santilli <[email protected]>
Date: Thu, May 3, 2018 at 5:03 PM
Subject: [PATCH] ltp-testsuite: add --with-open-posix-testsuite
To: buildroot at busybox.net

The issues mentioned on the removed comments were resolved, tested in QEMU x86_64 and aarch64.

Yes, I've been thinking about reenabling it again last week for the same reason :-). Thank you for your patch.

Quoted 36 lines

---
This patch supposes that the removed comments imply that a default --with-open-posix-testsuite
is desirable (and I confirm that it does not take unreasoble build time or disk space),
and that there is no generic way to add autotools configs to packages:
https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package

 package/ltp-testsuite/ltp-testsuite.mk | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
package/ltp-testsuite/ltp-testsuite.mk +1 -10
index c47f587836..4584ca45da 100644
@@ -9,17 +9,8 @@ LTP_TESTSUITE_SOURCE = ltp-full-$(LTP_TESTSUITE_VERSION).tar.xz
 LTP_TESTSUITE_SITE =
 https://github.com/linux-test-project/ltp/releases/download/$(LTP_TESTSUITE_VERSION)
 LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+
 LTP_TESTSUITE_LICENSE_FILES = COPYING
-
-# Do not enable Open POSIX testsuite as it doesn't cross-compile
-# properly: t0 program is built for the host machine. Notice that due
-# to a bug, --without-open-posix-testsuite actually enables the test
-# suite.
-# See https://github.com/linux-test-project/ltp/issues/143 (invalid
-# autoconf test) and
-# https://github.com/linux-test-project/ltp/issues/144 (Open POSIX
-# testsuite not cross-compiling).
 LTP_TESTSUITE_CONF_OPTS += \
- --with-realtime-testsuite
+ --with-realtime-testsuite --with-open-posix-testsuite
 
 ifeq ($(BR2_LINUX_KERNEL),y)
Quoted 1 line

LTP_TESTSUITE_DEPENDENCIES += linux

Kind regards,
Petr

#3 lore raw

PATCH 1/1 ltp-testsuite: add --with-open-posix-testsuite

In reply to Ciro Santilli

Hello Ciro,

Quoted 11 lines · Ciro Santilli

The issues mentioned on the removed comments were resolved, tested in QEMU x86_64 and aarch64.

---
This patch supposes that the removed comments imply that a default --with-open-posix-testsuite
is desirable (and I confirm that it does not take unreasoble build time or disk space),
and that there is no generic way to add autotools configs to packages:
https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package

Thanks for this contribution. However, your patch was corrupted, so it would be nice to use "git send-email" next time to submit a patch.

However, since the patch was simple, I fixed it up, and applied. Thanks again!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 ltp-testsuite: add --with-open-posix-testsuite

Quoted 15 lines · Thomas Petazzoni

Hello Ciro,

Quoted 11 lines · Ciro Santilli

The issues mentioned on the removed comments were resolved, tested in QEMU x86_64 and aarch64.

---
This patch supposes that the removed comments imply that a default --with-open-posix-testsuite
is desirable (and I confirm that it does not take unreasoble build time or disk space),
and that there is no generic way to add autotools configs to packages:
https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package

Quoted 3 lines

Thanks for this contribution. However, your patch was corrupted, so it would be nice to use "git send-email" next time to submit a patch.

Ah, sorry about that.

git send-email didn't work on the network I was on, but it works on my home network with the exact same git configs.

The problem is described at:
https://stackoverflow.com/questions/28038662/unable-to-initialize-smtp-properly-using-git
but none of the answers helped :-(

I wonder if anyone has ever solved it.

Quoted 8 lines

However, since the patch was simple, I fixed it up, and applied. Thanks again!

Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com

#5 lore raw

PATCH 1/1 ltp-testsuite: add --with-open-posix-testsuite

In reply to Ciro Santilli
Quoted 2 lines · Ciro Santilli

The issues mentioned on the removed comments were resolved, tested in QEMU x86_64 and aarch64.

Would be good to refer to the upstream commit that fixes it:
ca9561c124408ed0f5ed92c9ac7e092de05b5aed.

Quoted 6 lines

---
This patch supposes that the removed comments imply that a default --with-open-posix-testsuite
is desirable (and I confirm that it does not take unreasoble build time or disk space),

Indeed, no reason not to enable it.

Regards,
Arnout

Quoted 32 lines

and that there is no generic way to add autotools configs to packages:
https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package

 package/ltp-testsuite/ltp-testsuite.mk | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
package/ltp-testsuite/ltp-testsuite.mk +1 -10
index c47f587836..4584ca45da 100644
@@ -9,17 +9,8 @@ LTP_TESTSUITE_SOURCE = ltp-full-$(LTP_TESTSUITE_VERSION).tar.xz
 LTP_TESTSUITE_SITE =
 https://github.com/linux-test-project/ltp/releases/download/$(LTP_TESTSUITE_VERSION)
 LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+
 LTP_TESTSUITE_LICENSE_FILES = COPYING
-
-# Do not enable Open POSIX testsuite as it doesn't cross-compile
-# properly: t0 program is built for the host machine. Notice that due
-# to a bug, --without-open-posix-testsuite actually enables the test
-# suite.
-# See https://github.com/linux-test-project/ltp/issues/143 (invalid
-# autoconf test) and
-# https://github.com/linux-test-project/ltp/issues/144 (Open POSIX
-# testsuite not cross-compiling).
 LTP_TESTSUITE_CONF_OPTS += \
- --with-realtime-testsuite
+ --with-realtime-testsuite --with-open-posix-testsuite
 
 ifeq ($(BR2_LINUX_KERNEL),y)

LTP_TESTSUITE_DEPENDENCIES += linux

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF