Skip to contentSkip to conversation

swiotlb: Silent unwanted warning "buffer is full"

PATCH In review Jean Delvare 2 participants 3 messages May 3, 2018 – May 13, 2018 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 swiotlb: Silent unwanted warning "buffer is full"

If DMA_ATTR_NO_WARN is passed to swiotlb_alloc_buffer(), it should be passed further down to swiotlb_tbl_map_single(). Otherwise we escape half of the warnings but still log the other half.

This is one of the multiple causes of spurious warnings reported at:
https://bugs.freedesktop.org/show_bug.cgi?id=104082

Fixes 0176adb00406 ("swiotlb: refactor coherent buffer allocation")
Cc Christoph Hellwig <[email protected]>
Cc Christian König <[email protected]>
Cc Michel Dänzer <[email protected]>
Cc Takashi Iwai <[email protected]>
---
 lib/swiotlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/swiotlb.c +1 -1
@@ -727,7 +727,7 @@ swiotlb_alloc_buffer(struct device *dev,
 
 	phys_addr = swiotlb_tbl_map_single(dev,
 			swiotlb_phys_to_dma(dev, io_tlb_start),
-			0, size, DMA_FROM_DEVICE, 0);
+			0, size, DMA_FROM_DEVICE, attrs);
 	if (phys_addr == SWIOTLB_MAP_ERROR)
 		goto out_warn;
 
Signature · 6 lines
Jean Delvare
SUSE L3 Support
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
#1 lore raw

Thanks.

I manually applied this for 4.17-rc, as the mail unfortunately was garbled.

#2 lore raw
Quoted 4 lines · Christoph Hellwig

Thanks.

I manually applied this for 4.17-rc, as the mail unfortunately was garbled.

Sorry about that. Because of the umlauts in the Cc list, the mail was encoded as quoted-printable instead of 7bit. I guess this is what caused the problem on your end.

You would think our tools are able to deal with accentuated characters properly in 2018 but apparently not :-(

Signature · 2 lines
Jean Delvare
SUSE L3 Support