Skip to contentSkip to conversation

drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log

PATCH New Florent Flament 4 participants 7 messages Nov 20, 2017 – May 4, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log

Fix [drm:intel_enable_lvds] *ERROR* timed out waiting for panel to power on in kernel log at boot time.

This patch relates to the following bugs:
* https://bugs.freedesktop.org/show_bug.cgi?id=103414
* https://bugzilla.kernel.org/show_bug.cgi?id=57591

Toshiba Satellite Z930 laptops needs between 1 and 2 seconds to power on its screen during Intel i915 DRM initialization. This currently results in a [drm:intel_enable_lvds] *ERROR* timed out waiting for panel to power on message appearing in the kernel log during boot time and when stopping the machine.

This change increases the timeout of the intel_enable_lvds function from 1 to 2 seconds, letting enough time for the Satellite 930 LCD screen to power on, and suppressing the error message from the kernel log.

This patch has been successfully tested on Linux 4.14 running on a Toshiba Satellite Z930.

---
 drivers/gpu/drm/i915/intel_lvds.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lvds.c +4 -1
index 38572d65e46e..d41bbc9ff8c9 100644
@@ -317,7 +317,10 @@ static void intel_enable_lvds(struct intel_encoder *encoder,
 
 	I915_WRITE(PP_CONTROL(0), I915_READ(PP_CONTROL(0)) | PANEL_POWER_ON);
 	POSTING_READ(lvds_encoder->reg);
-	if (intel_wait_for_register(dev_priv, PP_STATUS(0), PP_ON, PP_ON, 1000))
+
+	/* Toshiba Satellite Z930 laptops LCD screens need more than 1
+	 * second to power on. */
+	if (intel_wait_for_register(dev_priv, PP_STATUS(0), PP_ON, PP_ON, 2000))
 		DRM_ERROR("timed out waiting for panel to power on\n");
 
 	intel_panel_enable_backlight(pipe_config, conn_state);
Signature · 6 lines
2.14.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: warning for drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log

== Series Details ==

== Series Details ==

Series: drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log
URL : https://patchwork.freedesktop.org/series/34125/
State : warning

== Summary ==

Series 34125v1 drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log
https://patchwork.freedesktop.org/api/1.0/series/34125/revisions/1/mbox/

Test chamelium:

        Subgroup dp-crc-fast:
                pass       -> FAIL       (fi-kbl-7500u) fdo#103163
Test kms_busy:
        Subgroup basic-flip-b:
                pass       -> FAIL       (fi-gdg-551) fdo#102654
Test kms_force_connector_basic:
        Subgroup force-connector-state:
                pass       -> SKIP       (fi-ivb-3520m)
        Subgroup force-edid:
                pass       -> SKIP       (fi-ivb-3520m)
        Subgroup force-load-detect:
                pass       -> SKIP       (fi-ivb-3520m)
        Subgroup prune-stale-modes:
                pass       -> SKIP       (fi-ivb-3520m)

fdo#103163 https://bugs.freedesktop.org/show_bug.cgi?id=103163
fdo#102654 https://bugs.freedesktop.org/show_bug.cgi?id=102654

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:453s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:382s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:535s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:278s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:507s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:506s
fi-byt-j1900     total:289  pass:254  dwarn:0   dfail:0   fail:0   skip:35  time:494s
fi-cfl-s2        total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:608s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:431s
fi-gdg-551       total:289  pass:177  dwarn:1   dfail:0   fail:2   skip:109 time:266s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:544s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:428s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:438s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:424s
fi-ivb-3520m     total:289  pass:256  dwarn:0   dfail:0   fail:0   skip:33  time:480s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:462s
fi-kbl-7500u     total:289  pass:263  dwarn:1   dfail:0   fail:1   skip:24  time:473s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:530s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:471s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:537s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:577s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:460s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:544s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:563s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:522s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:498s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:461s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:557s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:424s

Blacklisted hosts:
fi-glk-dsi total:81 pass:57 dwarn:0 dfail:1 fail:0 skip:22
fi-byt-n2820 failed to collect. IGT log at Patchwork_7210/fi-byt-n2820/igt.log

be7d29cbd72709db294f291080aef51028f0fb5a drm-tip: 2017y-11m-20d-22h-33m-05s UTC integration manifest 1b78aee49c34 drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7210/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

PATCH v2 1/1 drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log

In reply to Florent Flament

From: Florent Flament <[email protected]>

Fix [drm:intel_enable_lvds] *ERROR* timed out waiting for panel to power on in kernel log at boot time.

Toshiba Satellite Z930 laptops needs between 1 and 2 seconds to power on its screen during Intel i915 DRM initialization. This currently results in a [drm:intel_enable_lvds] *ERROR* timed out waiting for panel to power on message appearing in the kernel log during boot time and when stopping the machine.

This change increases the timeout of the intel_enable_lvds function from 1 to 2 seconds, letting enough time for the Satellite 930 LCD screen to power on, and suppressing the error message from the kernel log.

This patch has been successfully tested on Linux 4.14 running on a Toshiba Satellite Z930.

[vsyrjala: bump the timeout from 2 to 5 seconds to match the DP
code and properly cover the max hw timeout of ~4 seconds, and drop the comment about the specific machine since this is not a particulary surprising issue, nor specific to that one machine]
Cc: Pavel Petrovic <[email protected]>
Cc: Sérgio M. Basto <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103414
References: https://bugzilla.kernel.org/show_bug.cgi?id=57591

---
 drivers/gpu/drm/i915/intel_lvds.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lvds.c +2 -1
index d35d2d50f595..8691c86f579c 100644
@@ -326,7 +326,8 @@ static void intel_enable_lvds(struct intel_encoder *encoder,
 
 	I915_WRITE(PP_CONTROL(0), I915_READ(PP_CONTROL(0)) | PANEL_POWER_ON);
 	POSTING_READ(lvds_encoder->reg);
-	if (intel_wait_for_register(dev_priv, PP_STATUS(0), PP_ON, PP_ON, 1000))
+
+	if (intel_wait_for_register(dev_priv, PP_STATUS(0), PP_ON, PP_ON, 5000))
 		DRM_ERROR("timed out waiting for panel to power on\n");
 
 	intel_panel_enable_backlight(pipe_config, conn_state);
Signature · 6 lines
2.16.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer Reviewed-by on v2 1/1
#3 lore raw
Quoted 11 lines · Ville Syrjala

From: Florent Flament <[email protected]>

Fix [drm:intel_enable_lvds] *ERROR* timed out waiting for panel to power on in kernel log at boot time.

Toshiba Satellite Z930 laptops needs between 1 and 2 seconds to power on its screen during Intel i915 DRM initialization. This currently results in a [drm:intel_enable_lvds] *ERROR* timed out waiting for panel to power on message appearing in the kernel log during boot time and when stopping the machine.

Quoted 4 lines

This change increases the timeout of the intel_enable_lvds function from 1 to 2 seconds, letting enough time for the Satellite 930 LCD screen to power on, and suppressing the error message from the kernel log.

Please update the commit message to match what the patch actually does now, instead of hiding it in braces below. With that (and can be done while pushing),

Quoted 32 lines

This patch has been successfully tested on Linux 4.14 running on a Toshiba Satellite Z930.

[vsyrjala: bump the timeout from 2 to 5 seconds to match the DP
code and properly cover the max hw timeout of ~4 seconds, and drop the comment about the specific machine since this is not a particulary surprising issue, nor specific to that one machine]
Cc: Pavel Petrovic <[email protected]>
Cc: Sérgio M. Basto <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103414
References: https://bugzilla.kernel.org/show_bug.cgi?id=57591

---
 drivers/gpu/drm/i915/intel_lvds.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lvds.c +2 -1
index d35d2d50f595..8691c86f579c 100644
@@ -326,7 +326,8 @@ static void intel_enable_lvds(struct intel_encoder *encoder,
 
 	I915_WRITE(PP_CONTROL(0), I915_READ(PP_CONTROL(0)) | PANEL_POWER_ON);
 	POSTING_READ(lvds_encoder->reg);
-	if (intel_wait_for_register(dev_priv, PP_STATUS(0), PP_ON, PP_ON, 1000))
+
+	if (intel_wait_for_register(dev_priv, PP_STATUS(0), PP_ON, PP_ON, 5000))
 		DRM_ERROR("timed out waiting for panel to power on\n");
 
 	intel_panel_enable_backlight(pipe_config, conn_state);
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 17 lines · Jani Nikula
Quoted 11 lines · Ville Syrjala

From: Florent Flament <[email protected]>

Fix [drm:intel_enable_lvds] *ERROR* timed out waiting for panel to power on in kernel log at boot time.

Toshiba Satellite Z930 laptops needs between 1 and 2 seconds to power on its screen during Intel i915 DRM initialization. This currently results in a [drm:intel_enable_lvds] *ERROR* timed out waiting for panel to power on message appearing in the kernel log during boot time and when stopping the machine.

Quoted 4 lines

This change increases the timeout of the intel_enable_lvds function from 1 to 2 seconds, letting enough time for the Satellite 930 LCD screen to power on, and suppressing the error message from the kernel log.

Quoted 5 lines

Please update the commit message to match what the patch actually does now, instead of hiding it in braces below. With that (and can be done while pushing),

Pushed to dinq with a slightly amended commit message. Also added cc:stable.

Thanks for the original patch, and review.

Quoted 37 lines
Quoted 34 lines

This patch has been successfully tested on Linux 4.14 running on a Toshiba Satellite Z930.

[vsyrjala: bump the timeout from 2 to 5 seconds to match the DP
code and properly cover the max hw timeout of ~4 seconds, and drop the comment about the specific machine since this is not a particulary surprising issue, nor specific to that one machine]
Cc: Pavel Petrovic <[email protected]>
Cc: Sérgio M. Basto <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103414
References: https://bugzilla.kernel.org/show_bug.cgi?id=57591

---
 drivers/gpu/drm/i915/intel_lvds.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lvds.c +2 -1
index d35d2d50f595..8691c86f579c 100644
@@ -326,7 +326,8 @@ static void intel_enable_lvds(struct intel_encoder *encoder,
 
 	I915_WRITE(PP_CONTROL(0), I915_READ(PP_CONTROL(0)) | PANEL_POWER_ON);
 	POSTING_READ(lvds_encoder->reg);
-	if (intel_wait_for_register(dev_priv, PP_STATUS(0), PP_ON, PP_ON, 1000))
+
+	if (intel_wait_for_register(dev_priv, PP_STATUS(0), PP_ON, PP_ON, 5000))
 		DRM_ERROR("timed out waiting for panel to power on\n");
 
 	intel_panel_enable_backlight(pipe_config, conn_state);
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

✓ Fi.CI.BAT: success for drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log (rev2)

In reply to Florent Flament
== Series Details ==

== Series Details ==

Series: drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log (rev2)
URL : https://patchwork.freedesktop.org/series/34125/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4070 -> Patchwork_8757 =

== Summary - SUCCESS ==

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/34125/revisions/2/mbox/

== Known issues ==

Here are the changes found in Patchwork_8757 that come from known issues:

=== IGT changes ===

    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#105128) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-ivb-3520m:       DMESG-WARN (fdo#106084) -> PASS

fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084

== Participating hosts (35 -> 32) ==

Missing (3): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq

== Build changes ==

* Linux: CI_DRM_4070 -> Patchwork_8757

CI_DRM_4070: 47f407780a2b330f097892203401986838eb9795 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8757: a10cd605896d1202fb6fae524200e2fd8b4e9bef @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit

== Linux commits ==

a10cd605896d drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8757/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

✓ Fi.CI.IGT: success for drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log (rev2)

In reply to Florent Flament
== Series Details ==

== Series Details ==

Series: drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log (rev2)
URL : https://patchwork.freedesktop.org/series/34125/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4070_full -> Patchwork_8757_full =

== Summary - WARNING ==

Minor unknown changes coming with Patchwork_8757_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_8757_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://patchwork.freedesktop.org/api/1.0/series/34125/revisions/2/mbox/

== Possible new issues ==

Here are the unknown changes that may have been introduced in Patchwork_8757_full:

=== IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-bsd1:
      shard-kbl:          PASS -> SKIP +3

    igt@gem_mocs_settings@mocs-rc6-vebox:
      shard-kbl:          SKIP -> PASS +2

    igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
      shard-glk:          SKIP -> PASS +90

    igt@kms_flip@flip-vs-panning-vs-hang-interruptible:
      shard-glk:          PASS -> SKIP +60

== Known issues ==

Here are the changes found in Patchwork_8757_full that come from known issues:

=== IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_flush@basic-wb-set-default:
      shard-glk:          PASS -> FAIL (fdo#105900)

    igt@kms_cursor_legacy@flip-vs-cursor-atomic:
      shard-hsw:          PASS -> FAIL (fdo#102670)

    igt@kms_flip@2x-dpms-vs-vblank-race:
      shard-hsw:          PASS -> FAIL (fdo#103060) +1

    igt@kms_flip@absolute-wf_vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#106087)

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          SKIP -> FAIL (fdo#100368) +1

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
      shard-glk:          PASS -> DMESG-WARN (fdo#103774)

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_flip@2x-plain-flip-ts-check-interruptible:
      shard-hsw:          FAIL (fdo#100368) -> PASS +1

    igt@kms_frontbuffer_tracking@basic:
      shard-glk:          FAIL (fdo#103167) -> SKIP

    igt@kms_setmode@basic:
      shard-glk:          FAIL (fdo#99912) -> PASS

    igt@kms_sysfs_edid_timing:
      shard-apl:          WARN (fdo#100047) -> PASS

    
    ==== Warnings ====

    igt@kms_sysfs_edid_timing:
      shard-glk:          FAIL (fdo#100047) -> WARN (fdo#100047)

fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103774 https://bugs.freedesktop.org/show_bug.cgi?id=103774
fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
fdo#106087 https://bugs.freedesktop.org/show_bug.cgi?id=106087
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912

== Participating hosts (6 -> 5) ==

Missing (1): shard-glkb

== Build changes ==

* Linux: CI_DRM_4070 -> Patchwork_8757

CI_DRM_4070: 47f407780a2b330f097892203401986838eb9795 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4441: 83ba5b7d3bde48b383df41792fc9c955a5a23bdb @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_8757: a10cd605896d1202fb6fae524200e2fd8b4e9bef @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4441: e60d247eb359f044caf0c09904da14e39d7adca1 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8757/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx