media: i2c: lm3560: add support for lm3559 chip
Subsystems (2)
PATCH 1/1 media: i2c: lm3560: add support for lm3559 chip
Add support for LM3559, as found in Motorola Droid 4 phone, for example. SW interface seems to be identical.
drivers/media/i2c/lm3560.c +2 -1
@@ -1,6 +1,6 @@/* * drivers/media/i2c/lm3560.c -* General device driver for TI lm3560, FLASH LED Driver +* General device driver for TI lm3559, lm3560, FLASH LED Driver * * Copyright (C) 2013 Texas Instruments *
@@ -465,6 +479,7 @@ static int lm3560_remove(struct i2c_client *client) }static const struct i2c_device_id lm3560_id_table[] = { + {LM3559_NAME ,0 }, {LM3560_NAME ,0 }, {} };
include/media/i2c/lm3560.h +1 -0
@@ -22,6 +22,7 @@#include <media/v4l2-subdev.h> +#define LM3559_NAME "lm3559"#define LM3560_NAME "lm3560"#define LM3560_I2C_ADDR (0x53)
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180506/36b8089d/attachment.sig>
Quoted 5 lines · Pavel Machek
Add support for LM3559, as found in Motorola Droid 4 phone, for example. SW interface seems to be identical.
Signed-off-by Pavel Machek <[email protected]>
Ping?
Could this and media: i2c: lm3560: use conservative defaults be applied for v4.19? This is not too complex...
Pavel
Quoted 34 lines
drivers/media/i2c/lm3560.c +2
-1@@ -1,6 +1,6 @@/* * drivers/media/i2c/lm3560.c -* General device driver for TI lm3560, FLASH LED Driver +* General device driver for TI lm3559, lm3560, FLASH LED Driver * * Copyright (C) 2013 Texas Instruments * @@ -465,6 +479,7 @@ static int lm3560_remove(struct i2c_client *client) }static const struct i2c_device_id lm3560_id_table[] = { + {LM3559_NAME ,0 }, {LM3560_NAME ,0 }, {} };include/media/i2c/lm3560.h +1
-0@@ -22,6 +22,7 @@#include <media/v4l2-subdev.h> +#define LM3559_NAME "lm3559"#define LM3560_NAME "lm3560"#define LM3560_I2C_ADDR (0x53)
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180623/0e179ed3/attachment.sig>
Hi Pavel,
Quoted 8 lines · Pavel Machek
Quoted 4 lines
Add support for LM3559, as found in Motorola Droid 4 phone, for example. SW interface seems to be identical.
Signed-off-by Pavel Machek <[email protected]>Ping?
fping daniel
daniel is alive. :)
Quoted 5 lines
Could this and media: i2c: lm3560: use conservative defaults be applied for v4.19? This is not too complex...
Pavel
The lm3559 datasheet should be reviewed first
to know whether those products have same register map and field data for each register.
Quoted 36 lines
Quoted 34 lines
drivers/media/i2c/lm3560.c +2
-1@@ -1,6 +1,6 @@/* * drivers/media/i2c/lm3560.c -* General device driver for TI lm3560, FLASH LED Driver +* General device driver for TI lm3559, lm3560, FLASH LED Driver * * Copyright (C) 2013 Texas Instruments * @@ -465,6 +479,7 @@ static int lm3560_remove(struct i2c_client *client) }static const struct i2c_device_id lm3560_id_table[] = { + {LM3559_NAME ,0 }, {LM3560_NAME ,0 }, {} };include/media/i2c/lm3560.h +1
-0@@ -22,6 +22,7 @@#include <media/v4l2-subdev.h> +#define LM3559_NAME "lm3559"#define LM3560_NAME "lm3560"#define LM3560_I2C_ADDR (0x53)