Skip to contentSkip to conversation

t6050-replace: don't disable stdin for the whole test script

PATCH In review SZEDER Gábor 2 participants 3 messages May 7, 2018 – May 9, 2018

lore
Share & tools
lore

SZEDER Gábor

author
#0 lore raw

PATCH 1/1 t6050-replace: don't disable stdin for the whole test script

The test script 't6050-replace.sh' starts off with redirecting the whole test script's stdin from /dev/null. This redirection has been there since the test script was introduced in a3e8267225 (replace_object: add a test case, 2009-01-23), but the commit message doesn't explain why it was deemed necessary. AFAICT, it has never been necessary, and t6050 runs just fine and succeeds even without it, not only the current version but past versions as well.

Besides being unnecessary, this redirection is also harmful, as it prevents the test helper functions 'test_pause' and 'debug' from working properly in t6050, because we can't enter any commands to the shell and the debugger, respectively.

So let's remove that redirection.

Signed-off-by SZEDER Gábor <[email protected]>
---
 t/t6050-replace.sh | 2 --
 1 file changed, 2 deletions(-)
t/t6050-replace.sh +0 -2
index c630aba657..199fbc78a3 100755
@@ -4,8 +4,6 @@
 #
 test_description='Tests replace refs functionality'
 
-exec </dev/null
-
 . ./test-lib.sh
 . "$TEST_DIRECTORY/lib-gpg.sh"
Signature · 1 line
2.17.0.583.gcecc8b8e24
#1 lore raw

Hi Gábor,

Quoted 8 lines · SZEDER Gábor

The test script 't6050-replace.sh' starts off with redirecting the whole test script's stdin from /dev/null. This redirection has been there since the test script was introduced in a3e8267225 (replace_object: add a test case, 2009-01-23), but the commit message doesn't explain why it was deemed necessary. AFAICT, it has never been necessary, and t6050 runs just fine and succeeds even without it, not only the current version but past versions as well.

Quoted 4 lines

Besides being unnecessary, this redirection is also harmful, as it prevents the test helper functions 'test_pause' and 'debug' from working properly in t6050, because we can't enter any commands to the shell and the debugger, respectively.

The redirection might have been necessary before 781f76b1582 (test-lib:
redirect stdin of tests, 2011-12-15), but it definitely is not necessary now.

Thanks,
Dscho

author
#2 lore raw
Quoted 10 lines · Johannes Schindelin
Quoted 8 lines · SZEDER Gábor

The test script 't6050-replace.sh' starts off with redirecting the whole test script's stdin from /dev/null. This redirection has been there since the test script was introduced in a3e8267225 (replace_object: add a test case, 2009-01-23), but the commit message doesn't explain why it was deemed necessary. AFAICT, it has never been necessary, and t6050 runs just fine and succeeds even without it, not only the current version but past versions as well.

Quoted 8 lines
Quoted 4 lines

Besides being unnecessary, this redirection is also harmful, as it prevents the test helper functions 'test_pause' and 'debug' from working properly in t6050, because we can't enter any commands to the shell and the debugger, respectively.

The redirection might have been necessary before 781f76b1582 (test-lib:
redirect stdin of tests, 2011-12-15), but it definitely is not necessary now.

That doesn't seem to be an issue in a3e8267225 (or in any other commits touching t6050 since):

  $ echo foobar | ( ./t6050-replace.sh ; read input ; echo $input )
  *   ok 1: set up buggy branch
  *   ok 2: replace the author
  * passed all 2 test(s)
  foobar