Skip to contentSkip to conversation

babeltrace: switch source URI

PATCH In review Trevor Woerner 3 participants 5 messages May 7, 2018 – May 8, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 babeltrace: switch source URI

It looks like http://www.efficios.com/files/babeltrace is down, therefore switch to https://github.com/efficios/babeltrace/archive.

The md5sum/sha256sum updates are (I'm guessing) a result of switching from .tar.bz2 to .tar.gz.

---
 meta/recipes-kernel/lttng/babeltrace_1.5.5.bb | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
meta/recipes-kernel/lttng/babeltrace_1.5.5.bb +3 -4
index 92d86b92e8..2098264c67 100644
@@ -10,10 +10,9 @@ DEPENDS = "glib-2.0 util-linux popt bison-native flex-native"
 
 inherit autotools pkgconfig
 
-SRC_URI = "http://www.efficios.com/files/babeltrace/babeltrace-${PV}.tar.bz2 \
-"
+SRC_URI = "https://github.com/efficios/babeltrace/archive/v${PV}.tar.gz"
 
 EXTRA_OECONF = "--disable-debug-info"
 
-SRC_URI[md5sum] = "7decafd46093e4e47c14e7307d498986"
-SRC_URI[sha256sum] = "409146789b4a6b81f6a275fcad932a030743d444f6de5bd4a34aaf17aa72e8ac"
+SRC_URI[md5sum] = "aa70da8947b2104b976302d8f65ddee5"
+SRC_URI[sha256sum] = "ce11a5725e7f4838b4a1cc20966eca77bf77a80c43a072062708d7eac7ebf272"
Signature · 1 line
2.17.0.rc2.3.gc2a499e6c
#1 lore raw

There is already a fix for this, see:
http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150423.html

Using github archives is even worse as they are regenerated from time to time. Also when you really want to use v${PV}.tar.gz archive, then use downloadfilename parameter to fetch it with some more meaningful filename and to prevent possible conflicts with other badly named tarballs.

Quoted 43 lines · Trevor Woerner

It looks like http://www.efficios.com/files/babeltrace is down, therefore switch to https://github.com/efficios/babeltrace/archive.

The md5sum/sha256sum updates are (I'm guessing) a result of switching from .tar.bz2 to .tar.gz.

---
 meta/recipes-kernel/lttng/babeltrace_1.5.5.bb | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
meta/recipes-kernel/lttng/babeltrace_1.5.5.bb +0 -0
index 92d86b92e8..2098264c67 100644
@@ -10,10 +10,9 @@ DEPENDS = "glib-2.0 util-linux popt bison-native

flex-native"

inherit autotools pkgconfig

-SRC_URI = "http://www.efficios.com/files/babeltrace/babeltrace-${ PV}.tar.bz2 \
-"

meta/recipes-kernel/lttng/babeltrace_1.5.5.bb +1 -2
+SRC_URI = "https://github.com/efficios/babeltrace/archive/v${PV}.tar.gz"
 
 EXTRA_OECONF = "--disable-debug-info"
 
-SRC_URI[md5sum] = "7decafd46093e4e47c14e7307d498986"
-SRC_URI[sha256sum] = "409146789b4a6b81f6a275fcad932a

030743d444f6de5bd4a34aaf17aa72e8ac"

meta/recipes-kernel/lttng/babeltrace_1.5.5.bb +2 -0
+SRC_URI[md5sum] = "aa70da8947b2104b976302d8f65ddee5"
+SRC_URI[sha256sum] = "ce11a5725e7f4838b4a1cc20966eca

77bf77a80c43a072062708d7eac7ebf272"
--
2.17.0.rc2.3.gc2a499e6c

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

Hi Martin,

Quoted 2 lines · Martin Jansa

There is already a fix for this, see:
http://lists.openembedded.org/pipermail/openembedded-core/2018-May/150423.html

Oops, I should have checked, sorry!

Quoted 2 lines

Using github archives is even worse as they are regenerated from time to time.

Crazy! But good to know.

Quoted 3 lines

Also when you really want to use v${PV}.tar.gz archive, then use downloadfilename parameter to fetch it with some more meaningful filename and to prevent possible conflicts with other badly named tarballs.

Oh, I see, in one's own DL_DIR. So (not that this patch is relevant anymore) instead of:

	-SRC_URI = "http://www.efficios.com/files/babeltrace/babeltrace-${PV}.tar.bz2 \
	-"
	+SRC_URI = "https://github.com/efficios/babeltrace/archive/v${PV}.tar.gz"

better:

	-SRC_URI = "http://www.efficios.com/files/babeltrace/babeltrace-${PV}.tar.bz2 \
	-"
	+SRC_URI = "https://github.com/efficios/babeltrace/archive/v${PV}.tar.gz;downloadfilename=babeltrace-v${PV}.tar.gz"

In this case, would the checksums need a tweak too, or do they know to look for the downloadfilename file name?

#3 lore raw

Checksums don't need any special treatment with downloadfilename parameter.

Quoted 41 lines · Trevor Woerner

Hi Martin,

Quoted 2 lines · Martin Jansa

There is already a fix for this, see:
http://lists.openembedded.org/pipermail/openembedded-core/

2018-May/150423.html

Oops, I should have checked, sorry!

Quoted 2 lines

Using github archives is even worse as they are regenerated from time to time.

Crazy! But good to know.

Quoted 3 lines

Also when you really want to use v${PV}.tar.gz archive, then use downloadfilename parameter to fetch it with some more meaningful filename and to prevent possible conflicts with other badly named

tarballs.

Oh, I see, in one's own DL_DIR. So (not that this patch is relevant anymore)
instead of:

        -SRC_URI = "http://www.efficios.com/files/babeltrace/babeltrace-${

PV}.tar.bz2 \
-"
+SRC_URI = "https://github.com/efficios/
babeltrace/archive/v${PV}.tar.gz"

better:

        -SRC_URI = "http://www.efficios.com/files/babeltrace/babeltrace-${

PV}.tar.bz2 \
-"
+SRC_URI = "https://github.com/efficios/
babeltrace/archive/v${PV}.tar.gz;downloadfilename=babeltrace-v${PV}.tar.gz "

In this case, would the checksums need a tweak too, or do they know to look for the downloadfilename file name?

#4 lore raw
In reply to Martin Jansa
Quoted 9 lines · Martin Jansa

There is already a fix for this, see:
http://lists.openembedded.org/pipermail/openembedded-core/
2018-May/150423.html

Using github archives is even worse as they are regenerated from time to time. Also when you really want to use v${PV}.tar.gz archive, then use downloadfilename parameter to fetch it with some more meaningful filename and to prevent possible conflicts with other badly named tarballs.

http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html
has a bit more background to this problem fwiw.

Ross