Skip to contentSkip to conversation

arm: oxnas: remove non-necessary flush_cache_all()

PATCH New Jisheng Zhang 1 participant 1 message May 7, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: oxnas: remove non-necessary flush_cache_all()

I believe the flush_cache_all() after scu_enable() is to "Ensure that the data accessed by CPU0 before the SCU was initialised is visible to the other CPUs." as commented in scu_enable(). So flush_cache_all() here is a duplication of the one in scu_enable(), remove it.

---
 arch/arm/mach-oxnas/platsmp.c | 1 -
 1 file changed, 1 deletion(-)
arch/arm/mach-oxnas/platsmp.c +0 -1
index 442cc8a2f7dc..1a8e1e9fc222 100644
@@ -85,7 +85,6 @@ static void __init ox820_smp_prepare_cpus(unsigned int max_cpus)
 		goto unmap_scu;
 
 	scu_enable(scu_base);
-	flush_cache_all();
 
 unmap_scu:
 	iounmap(scu_base);
Signature · 1 line
2.17.0